Skip to contentSkip to conversation

Staging: rtl8188eu: Add blank line after declarations

PATCH In review Melike Yurtoglu 2 participants 2 messages Feb 23, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8188eu: Add blank line after declarations

WARNING: "Missing a blank line after declarations" That was found by running checkpatch

---
 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c +1 -0
index 3c651d5..2c23aa9 100644
@@ -538,6 +538,7 @@ int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid)
 	struct odm_ra_info *pRaInfo = &dm_odm->RAInfo[macid];
 	u8 WirelessMode = 0xFF; /* invalid value */
 	u8 max_rate_idx = 0x13; /* MCS7 */
+
 	if (dm_odm->pWirelessMode != NULL)
 		WirelessMode = *(dm_odm->pWirelessMode);
 
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 14 lines · Melike Yurtoglu

WARNING: "Missing a blank line after declarations" That was found by running checkpatch

---
 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c +0 -0
index 3c651d5..2c23aa9 100644

drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid) · line 544

Quoted 7 lines
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c +1 -0
@@ -538,6 +538,7 @@ int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid)
 	struct odm_ra_info *pRaInfo = &dm_odm->RAInfo[macid];
 	u8 WirelessMode = 0xFF; /* invalid value */
 	u8 max_rate_idx = 0x13; /* MCS7 */
+
 	if (dm_odm->pWirelessMode != NULL)
 		WirelessMode = *(dm_odm->pWirelessMode);
 

Patch looks fine - I as always prefer focusing on a slightly more personal commit message, and less so on the checkpatch warning, but I think this one is fine. I don't think you need to re-post this patch.

Jes