Skip to contentSkip to conversation

Staging: iio: Move export_symbol below its function

PATCH In review Melike Yurtoglu 2 participants 2 messages Feb 23, 2015 – Feb 24, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: iio: Move export_symbol below its function

WARNING: "EXPORT_SYMBOL(foo); should immediately follow its function/variable"
That was found by running checkpatch.

---
 drivers/staging/iio/addac/adt7316.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/addac/adt7316.c +1 -1
index 5b11b42..18bfbf0 100644
@@ -2069,6 +2069,7 @@ static struct attribute_group adt7516_event_attribute_group = {
 };
 
 #ifdef CONFIG_PM_SLEEP
+EXPORT_SYMBOL_GPL(adt7316_pm_ops);
 static int adt7316_disable(struct device *dev)
 {
 	struct iio_dev *dev_info = dev_get_drvdata(dev);
@@ -2086,7 +2087,6 @@ static int adt7316_enable(struct device *dev)
 }
 
 SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
-EXPORT_SYMBOL_GPL(adt7316_pm_ops);
 #endif
 
 static const struct iio_info adt7316_info = {
Signature · 1 line
1.8.3.2
#1 lore raw

Hi Melike,

Quoted 22 lines · Melike Yurtoglu

WARNING: "EXPORT_SYMBOL(foo); should immediately follow its function/variable"
That was found by running checkpatch.

---
 drivers/staging/iio/addac/adt7316.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/addac/adt7316.c +1 -0
index 5b11b42..18bfbf0 100644
@@ -2069,6 +2069,7 @@ static struct attribute_group adt7516_event_attribute_group = {
 };
 
 #ifdef CONFIG_PM_SLEEP
+EXPORT_SYMBOL_GPL(adt7316_pm_ops);
 static int adt7316_disable(struct device *dev)
 {
 	struct iio_dev *dev_info = dev_get_drvdata(dev);

drivers/staging/iio/addac/adt7316.c static int adt7316_enable(struct device *dev) · line 2089

Quoted 4 lines
drivers/staging/iio/addac/adt7316.c +0 -1
@@ -2086,7 +2087,6 @@ static int adt7316_enable(struct device *dev)
 }
 
 SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
-EXPORT_SYMBOL_GPL(adt7316_pm_ops);

The EXPORT_SYMBOL() is rightly under the variable definition - adt7316_pm_ops. So why this cleanup?

Regards
Preeti U Murthy

Quoted 4 lines
drivers/staging/iio/addac/adt7316.c +0 -0
 #endif
 
 static const struct iio_info adt7316_info = {