Skip to contentSkip to conversation

ARM: vexpress: update CONFIG_USB_ISP1760 option

PATCH New Sudeep Holla 2 participants 5 messages Feb 24, 2015 – Feb 26, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: vexpress: update CONFIG_USB_ISP1760 option

Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ to drivers/usb/isp1760/") moved the isp1760 driver and changed the Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable directly anymore. This results in driver being not compiled in when using vexpress_defconfig and the USB is non-functional.

This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to get back USB functional on vexpress platforms.

Cc Liviu Dudau <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
---
 arch/arm/configs/vexpress_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/vexpress_defconfig +1 -1
index f489fdaa19b8..37fe607a4ede 100644
@@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y
 CONFIG_USB=y
 CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
 CONFIG_USB_MON=y
-CONFIG_USB_ISP1760_HCD=y
 CONFIG_USB_STORAGE=y
+CONFIG_USB_ISP1760=y
 CONFIG_MMC=y
 CONFIG_MMC_ARMMMCI=y
 CONFIG_NEW_LEDS=y
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: vexpress: update CONFIG_USB_ISP1760 option

Quoted 31 lines · Sudeep Holla

Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ to drivers/usb/isp1760/") moved the isp1760 driver and changed the Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable directly anymore. This results in driver being not compiled in when using vexpress_defconfig and the USB is non-functional.

This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to get back USB functional on vexpress platforms.

Cc Liviu Dudau <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
---
 arch/arm/configs/vexpress_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/vexpress_defconfig +1 -2
index f489fdaa19b8..37fe607a4ede 100644
@@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y
 CONFIG_USB=y
 CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
 CONFIG_USB_MON=y
-CONFIG_USB_ISP1760_HCD=y
 CONFIG_USB_STORAGE=y
+CONFIG_USB_ISP1760=y
 CONFIG_MMC=y
 CONFIG_MMC_ARMMMCI=y
 CONFIG_NEW_LEDS=y
--
Quoted 1 line

1.9.1

I tested this change and confirm that it does indeed re-activate USB functionality.

Mathieu

Quoted 6 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

PATCH 1/1 ARM: vexpress: update CONFIG_USB_ISP1760 option

Quoted 28 lines · Mathieu Poirier
Quoted 27 lines · Sudeep Holla

Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ to drivers/usb/isp1760/") moved the isp1760 driver and changed the Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable directly anymore. This results in driver being not compiled in when using vexpress_defconfig and the USB is non-functional.

This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to get back USB functional on vexpress platforms.

Cc Liviu Dudau <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
---
  arch/arm/configs/vexpress_defconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/vexpress_defconfig +1 -1
index f489fdaa19b8..37fe607a4ede 100644
@@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y
  CONFIG_USB=y
  CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
  CONFIG_USB_MON=y
-CONFIG_USB_ISP1760_HCD=y
  CONFIG_USB_STORAGE=y
+CONFIG_USB_ISP1760=y
Quoted 8 lines
Quoted 5 lines
arch/arm/configs/vexpress_defconfig +0 -1
  CONFIG_MMC=y
  CONFIG_MMC_ARMMMCI=y
  CONFIG_NEW_LEDS=y
--

1.9.1

I tested this change and confirm that it does indeed re-activate USB functionality.

Thanks indeed. So I assume we can add

Regards,
Sudeep

#3 lore raw

PATCH 1/1 ARM: vexpress: update CONFIG_USB_ISP1760 option

Quoted 45 lines · Sudeep Holla
Quoted 32 lines · Mathieu Poirier
Quoted 30 lines · Sudeep Holla

Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ to drivers/usb/isp1760/") moved the isp1760 driver and changed the Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable directly anymore. This results in driver being not compiled in when using vexpress_defconfig and the USB is non-functional.

This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to get back USB functional on vexpress platforms.

Cc Liviu Dudau <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
---
  arch/arm/configs/vexpress_defconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/vexpress_defconfig +1 -1
index f489fdaa19b8..37fe607a4ede 100644
@@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y
  CONFIG_USB=y
  CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
  CONFIG_USB_MON=y
-CONFIG_USB_ISP1760_HCD=y
  CONFIG_USB_STORAGE=y
+CONFIG_USB_ISP1760=y
  CONFIG_MMC=y
Quoted 8 lines
Quoted 4 lines
arch/arm/configs/vexpress_defconfig +0 -1
  CONFIG_MMC_ARMMMCI=y
  CONFIG_NEW_LEDS=y
--

1.9.1

I tested this change and confirm that it does indeed re-activate USB functionality.

Quoted 3 lines

Thanks indeed. So I assume we can add

You sure can.

Quoted 4 lines

Regards,
Sudeep

#4 lore raw

PATCH 1/1 ARM: vexpress: update CONFIG_USB_ISP1760 option

Hi Arnd,

Quoted 46 lines · Mathieu Poirier
Quoted 45 lines · Sudeep Holla
Quoted 40 lines · Mathieu Poirier
Quoted 33 lines · Sudeep Holla

Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ to drivers/usb/isp1760/") moved the isp1760 driver and changed the Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable directly anymore. This results in driver being not compiled in when using vexpress_defconfig and the USB is non-functional.

This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to get back USB functional on vexpress platforms.

Cc Liviu Dudau <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
---
   arch/arm/configs/vexpress_defconfig | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/vexpress_defconfig +1 -2
index f489fdaa19b8..37fe607a4ede 100644
@@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y
   CONFIG_USB=y
   CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
   CONFIG_USB_MON=y
-CONFIG_USB_ISP1760_HCD=y
   CONFIG_USB_STORAGE=y
+CONFIG_USB_ISP1760=y
   CONFIG_MMC=y
   CONFIG_MMC_ARMMMCI=y
   CONFIG_NEW_LEDS=y
--
Quoted 1 line

1.9.1

I tested this change and confirm that it does indeed re-activate USB functionality.

Quoted 6 lines
Quoted 3 lines

Thanks indeed. So I assume we can add

You sure can.

This has to go as fix, without this USB is not enabled with vexpress_defconfig and breaks for people using rootfs on USB on vepress platform.

Regards,
Sudeep