backlight: pwm: Add backlight-boot-off property
Subsystems (4)
cover backlight: pwm: Add backlight-boot-off property
Add backlight-boot-off property, so we can keeping the backlight disabled at boot until it is enabled implicitly by a panel driver, or explicitly by userspace
huang lin (2):
Documentation: devicetree: add backlight-boot-off property in
pwm-backlight
backlight: pwm: Add backlight-boot-off property
Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt | 1 + drivers/video/backlight/pwm_bl.c | 4 ++++ 2 files changed, 5 insertions(+)
Signature · 6 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/2 Documentation: devicetree: add backlight-boot-off property in pwm-backlight
Add the backlight-boot-ff property, so we can keeping the backlight disabled at boot until it is enabled implicitly by a panel driver, or explicitly by userspace.
---
Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt +1 -0
@@ -17,6 +17,7 @@ Optional properties: "pwms" property (see PWM binding[0]) - enable-gpios: contains a single GPIO specifier for the GPIO which enables and disables the backlight (see GPIO binding[1]) + - backlight-boot-off: turn off backlight when pwm backlight probe [0]: Documentation/devicetree/bindings/pwm/pwm.txt [1]: Documentation/devicetree/bindings/gpio/gpio.txt
Signature · 1 line
1.9.1
PATCH 2/2 backlight: pwm: Add backlight-boot-off property
In reply to huang linAdd backlight-boot-off property, so we can keeping the backlight disabled at boot until it is enabled implicitly by a panel driver, or explicitly by userspace
---
drivers/video/backlight/pwm_bl.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/video/backlight/pwm_bl.c +4 -0
@@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) } bl->props.brightness = data->dft_brightness; + +if (of_find_property (pdev->dev.of_node,"backlight-boot-off" ,NULL )) + bl->props.power =FB_BLANK_POWERDOWN ; +backlight_update_status (bl);platform_set_drvdata (pdev, bl);
Signature · 1 line
1.9.1
Hi Huang,
Quoted 16 lines · huang lin
Add backlight-boot-off property, so we can keeping the backlight disabled at boot until it is enabled implicitly by a panel driver, or explicitly by userspace
Signed-off-by huang lin <[email protected]>---
drivers/video/backlight/pwm_bl.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/video/backlight/pwm_bl.c +0
-0
drivers/video/backlight/pwm_bl.c static int pwm_backlight_probe(struct platform_device *pdev) · line 325
Quoted 7 lines
drivers/video/backlight/pwm_bl.c +4
-0@@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) } bl->props.brightness = data->dft_brightness; + +if (of_find_property (pdev->dev.of_node,"backlight-boot-off" ,NULL )) + bl->props.power =FB_BLANK_POWERDOWN ; +
You need to check this. Originally, Thierry proposed it.
http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
Quoted 11 lines
drivers/video/backlight/pwm_bl.c +0
-1backlight_update_status (bl);platform_set_drvdata (pdev, bl); --1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 21 lines · Ajay kumar
Hi Huang,
Quoted 18 lines · huang lin
Add backlight-boot-off property, so we can keeping the backlight disabled at boot until it is enabled implicitly by a panel driver, or explicitly by userspace
Signed-off-by huang lin <[email protected]>---
drivers/video/backlight/pwm_bl.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/video/backlight/pwm_bl.c +0
-0@@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) }
Quoted 7 lines
drivers/video/backlight/pwm_bl.c static int pwm_backlight_probe(struct platform_device *pdev) · line 325
Quoted 5 lines
drivers/video/backlight/pwm_bl.c +4
-0bl->props.brightness = data->dft_brightness; + +if (of_find_property (pdev->dev.of_node,"backlight-boot-off" ,NULL )) + bl->props.power =FB_BLANK_POWERDOWN ; +You need to check this. Originally, Thierry proposed it.
http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
I have applied Thierry patch , and it can work. I think it should be merged, since i use three type of edp panels,
they have same issue: when the backlight probe, the panel will visual glitches.
Quoted 14 lines
Quoted 12 lines
drivers/video/backlight/pwm_bl.c +0
-1backlight_update_status (bl);platform_set_drvdata (pdev, bl); --1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 21 lines
黄林 福州瑞芯微电子有限公司 Fuzhou Rockchip Electronics Co.Ltd 福建省福州市铜盘路软件大道89号软件园A区21号楼(350003) Addr:No.21 Building, A District, No.89, software Boulevard Fuzhou, Fujian,PRC Email:[email protected] Tel:+86-591-83991906/07 **************************************************************************************** 保密提示:本邮件及其附件含有机密信息,仅发送给本邮件所指特定收件人。若非该特定收件人,请 勿复制、 使用或披露本邮件的任何内容。若误收本邮件,请从系统中永久性删除本邮件及所有附件, 并以回复邮件或其他方式即刻告知发件人。福州瑞芯微电子有限公司拥有本邮件信息的著作权及解释 权,禁止任何未经授权许可的侵权行为。 IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material in its entirety in any format. Thank you. ********************************************************************************
Quoted 37 lines · hl
Quoted 25 lines · Ajay kumar
Hi Huang,
Quoted 21 lines · huang lin
Add backlight-boot-off property, so we can keeping the backlight disabled at boot until it is enabled implicitly by a panel driver, or explicitly by userspace
Signed-off-by huang lin <[email protected]>---
drivers/video/backlight/pwm_bl.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/video/backlight/pwm_bl.c +0
-0@@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev) }Quoted 9 lines
drivers/video/backlight/pwm_bl.c static int pwm_backlight_probe(struct platform_device *pdev) · line 325
Quoted 6 lines
drivers/video/backlight/pwm_bl.c +4
-0bl->props.brightness = data->dft_brightness; + +if (of_find_property (pdev->dev.of_node,"backlight-boot-off" ,NULL )) + bl->props.power =FB_BLANK_POWERDOWN ; +You need to check this. Originally, Thierry proposed it.
http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
Quoted 4 lines
I have applied Thierry patch , and it can work. I think it should be merged, since i use three type of edp panels,
they have same issue: when the backlight probe, the panel will visual glitches.
Right, the same problem exists on Exynos5800-peach-pi display!
I had tested this long back, and I think its not merged since the DT property has an issue that "it doesn't really represent h/w property of the device".
Quoted 45 lines
Quoted 8 lines
Quoted 8 lines
drivers/video/backlight/pwm_bl.c +0
-0backlight_update_status (bl);platform_set_drvdata(pdev, bl);--
1.9.1Quoted 7 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
黄林
福州瑞芯微电子有限公司
Fuzhou Rockchip Electronics Co.Ltd 福建省福州市铜盘路软件大道89号软件园A区21号楼(350003)
Addr:No.21 Building, A District, No.89, software Boulevard Fuzhou, Fujian,PRC
Email:[email protected]
Tel:+86-591-83991906/07****************************************************************************************
保密提示:本邮件及其附件含有机密信息,仅发送给本邮件所指特定收件人。若非该特定收件人,请
勿复制、 使用或披露本邮件的任何内容。若误收本邮件,请从系统中永久性删除本邮件及所有附件, 并以回复邮件或其他方式即刻告知发件人。福州瑞芯微电子有限公司拥有本邮件信息的著作权及解释
权,禁止任何未经授权许可的侵权行为。
IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd
.The contents
of this email and any attachments may contain information that is privileged, confidential
and/or exempt from disclosure under applicable law and relevant NDA. If you are not the
intended recipient, you are hereby notified that any disclosure, copying, distribution,
or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender
as soon as possible and destroy the material in its entirety in any format. Thank you.
********************************************************************************