sched/deadline: fix rt runtime corrupt when dl refuse a smaller bandwidth
PATCH RESEND v2 1/1 sched/deadline: fix rt runtime corrupt when dl refuse a smaller bandwidth
Dl class will refuse the bandwidth being set to some value smaller than the currently allocated bandwidth in any of the root_domains through sched_rt_runtime_us and sched_rt_period_us. RT runtime will be set according to sched_rt_runtime_us before dl class verify if the new bandwidth is suitable in the case of !CONFIG_RT_GROUP_SCHED.
However, rt runtime will be corrupt if dl refuse the new bandwidth since there is no undo to reset the rt runtime to the old value.
This patch fix it by verifying new bandwidth for deadline in advance.
---
v1 -> v2:
* move sched_dl_global_constraints before sched_rt_global_constraints, and change the name of the former to sched_dl_global_validate().
kernel/sched/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/sched/core.c +3 -3
@@ -7815,7 +7815,7 @@ static int sched_rt_global_constraints(void) }#endif /* CONFIG_RT_GROUP_SCHED */ -static int sched_dl_global_constraints (void ) +static int sched_dl_global_validate (void ) {u64 runtime =global_rt_runtime ();u64 period =global_rt_period ();
@@ -7916,11 +7916,11 @@ int sched_rt_handler(struct ctl_table *table, int write,if (ret) goto undo; - ret =sched_rt_global_constraints (); + ret =sched_dl_global_validate ();if (ret) goto undo; - ret =sched_dl_global_constraints (); + ret =sched_rt_global_constraints ();if (ret) goto undo;
Signature · 1 line
1.9.1
Hi,
Quoted 11 lines · Wanpeng Li
Dl class will refuse the bandwidth being set to some value smaller than the currently allocated bandwidth in any of the
root_domainsthroughsched_rt_runtime_usandsched_rt_period_us. RT runtime will be set according tosched_rt_runtime_usbefore dl class verify if the new bandwidth is suitable in the case of !CONFIG_RT_GROUP_SCHED.However, rt runtime will be corrupt if dl refuse the new bandwidth since there is no undo to reset the rt runtime to the old value.
This patch fix it by verifying new bandwidth for deadline in advance.
Looks good, thanks!
Quoted 38 lines
Cc Juri Lelli <[email protected]>Signed-off-by Wanpeng Li <[email protected]>---
v1 -> v2:
* movesched_dl_global_constraintsbeforesched_rt_global_constraints, and change the name of the former tosched_dl_global_validate().kernel/sched/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)kernel/sched/core.c +3
-3@@ -7815,7 +7815,7 @@ static int sched_rt_global_constraints(void) }#endif /* CONFIG_RT_GROUP_SCHED */ -static int sched_dl_global_constraints (void ) +static int sched_dl_global_validate (void ) {u64 runtime =global_rt_runtime ();u64 period =global_rt_period ();@@ -7916,11 +7916,11 @@ int sched_rt_handler(struct ctl_table *table, int write,if (ret) goto undo; - ret =sched_rt_global_constraints (); + ret =sched_dl_global_validate ();if (ret) goto undo; - ret =sched_dl_global_constraints (); + ret =sched_rt_global_constraints ();if (ret) goto undo;