Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Subsystems (2)
PATCH 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Commit 2e82e9252695a612ab0cbf40fa0c7368515f6506 'Exynos: Clock: Cleanup soc_get_periph_rate' introduced a bug in I2C config. This patch makes cros_ec keyboard working again on Samsung Chromebook (snow).
--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/armv7/exynos/clock.c +2 -2
@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 : src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0); + div =readl (&clk->div_top1);break ;default :debug ("%s: invalid peripheral %d" , __func__, peripheral);
Signature · 1 line
1.8.4.5
PATCH 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Joonyoung,
Quoted 19 lines · Guillaume GARDET
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: Cleanupsoc_get_periph_rate' introduced a bug in I2C config. This patch makescros_eckeyboard working again on Samsung Chromebook (snow).Signed-off-by Guillaume GARDET <[email protected]>Cc Akshay Saraswat <[email protected]>Cc Minkyu Kang <[email protected]>Cc Joonyoung Shim <[email protected]>--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/cpu/armv7/exynos/clock.c +0
-0
arch/arm/cpu/armv7/exynos/clock.c static unsigned long exynos5_get_periph_rate(int peripheral) · line 430
Quoted 10 lines
arch/arm/cpu/armv7/exynos/clock.c +2
-2@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 : src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0); + div =readl (&clk->div_top1);break ;default :debug ("%s: invalid peripheral %d" , __func__, peripheral);
Could you please check this patch?
Thanks,
Minkyu Kang.
PATCH 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Le 28/02/2015 08:59, Minkyu Kang a ?crit :
Quoted 25 lines
Joonyoung,
Quoted 22 lines · Guillaume GARDET
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: Cleanupsoc_get_periph_rate' introduced a bug in I2C config. This patch makescros_eckeyboard working again on Samsung Chromebook (snow).Signed-off-by Guillaume GARDET <[email protected]>Cc Akshay Saraswat <[email protected]>Cc Minkyu Kang <[email protected]>Cc Joonyoung Shim <[email protected]>--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/cpu/armv7/exynos/clock.c +0
-1@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 : src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0);
Quoted 8 lines
arch/arm/cpu/armv7/exynos/clock.c static unsigned long exynos5_get_periph_rate(int peripheral) · line 430
Quoted 7 lines
arch/arm/cpu/armv7/exynos/clock.c +2
-1- sub_div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0); + div =readl (&clk->div_top1);break ;default :debug ("%s: invalid peripheral %d" , __func__, peripheral);Could you please check this patch?
Ping.
This patch must be applied before the release, otherwise, keyboard on Samsung Chromebook will no work at all.
Guillaume
Quoted 4 lines
Thanks,
Minkyu Kang.
PATCH 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Hi,
Quoted 19 lines · Guillaume Gardet
Le 28/02/2015 08:59, Minkyu Kang a ?crit :
Quoted 16 lines
Joonyoung,
Quoted 13 lines · Guillaume GARDET
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: Cleanupsoc_get_periph_rate' introduced a bug in I2C config. This patch makescros_eckeyboard working again on Samsung Chromebook (snow).Signed-off-by Guillaume GARDET <[email protected]>Cc Akshay Saraswat <[email protected]>Cc Minkyu Kang <[email protected]>Cc Joonyoung Shim <[email protected]>--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
arch/arm/cpu/armv7/exynos/clock.c +0
-0Quoted 8 lines
arch/arm/cpu/armv7/exynos/clock.c static unsigned long exynos5_get_periph_rate(int peripheral) · line 427
Quoted 8 lines
arch/arm/cpu/armv7/exynos/clock.c +2
-2@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 : src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0); + div =readl (&clk->div_top1);
Could you keep order of assign statements of div and sub_div variables?
div = readl(&clk->div_top1);sub_div = readl(&clk->div_top0);
Thanks.
PATCH v2 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Commit 2e82e9252695a612ab0cbf40fa0c7368515f6506 'Exynos: Clock: Cleanup soc_get_periph_rate' introduced a bug in I2C config. This patch makes cros_ec keyboard working again on Samsung Chromebook (snow).
Changes in V2: reorder lines as requested by Joonyoung Shim.
--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/armv7/exynos/clock.c +2 -2
@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 : src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0);break ;default :debug ("%s: invalid peripheral %d" , __func__, peripheral);
Signature · 1 line
1.8.4.5
PATCH v2 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Ping.
Guillaume
Le 11/03/2015 10:34, Guillaume GARDET a ?crit :
Quoted 30 lines
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: Cleanupsoc_get_periph_rate' introduced a bug in I2C config. This patch makescros_eckeyboard working again on Samsung Chromebook (snow).Changes in V2: reorder lines as requested by Joonyoung Shim.
Signed-off-by Guillaume GARDET <[email protected]>Cc Akshay Saraswat <[email protected]>Cc Minkyu Kang <[email protected]>Cc Joonyoung Shim <[email protected]>--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/cpu/armv7/exynos/clock.c +2
-2@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 : src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0);break ;default :debug ("%s: invalid peripheral %d" , __func__, peripheral);
PATCH 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
hi,
Quoted 43 lines · On 20 March 2015 at 02:06, Guillaume Gardet <guillaume.gardet at free.fr…
Ping.
Guillaume
Le 11/03/2015 10:34, Guillaume GARDET a ?crit :
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: CleanupQuoted 35 lines
soc_get_periph_rate' introduced a bug in I2C config. This patch makescros_ec
keyboard working again on Samsung Chromebook (snow).Changes in V2: reorder lines as requested by Joonyoung Shim.
Signed-off-by Guillaume GARDET <[email protected]<javascript:_e(%7B%7D,'cvml','[email protected]');>>
Cc: Akshay Saraswat <[email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>>
Cc: Minkyu Kang <[email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>>
Cc: Joonyoung Shim <[email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>>--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/cpu/armv7/exynos/clock.c +2
-2@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 : src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0);break ;default :
Quoted 9 lines
Quoted 2 lines
debug("%s: invalid peripheral %d", __func__, peripheral);_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de <javascript:_e(%7B%7D,'cvml','[email protected]');>
http://lists.denx.de/mailman/listinfo/u-boot
This patch will be merged at next week!
Thanks,
Minkyu Kang.
Signature · 7 lines
from. prom. www.promsoft.net -- Thanks. Minkyu Kang.
PATCH 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Hi Minkyu,
Quoted 58 lines · Minkyu Kang
hi,
Quoted 43 lines · On 20 March 2015 at 02:06, Guillaume Gardet <[email protected]…
Ping.
Guillaume
Le 11/03/2015 10:34, Guillaume GARDET a ?crit :
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: CleanupQuoted 35 lines
soc_get_periph_rate' introduced a bug in I2C config. This patch makescros_ec
keyboard working again on Samsung Chromebook (snow).Changes in V2: reorder lines as requested by Joonyoung Shim.
Signed-off-by Guillaume GARDET <[email protected]<javascript:_e(%7B%7D,'cvml','[email protected]');>>
Cc: Akshay Saraswat <[email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>>
Cc: Minkyu Kang <[email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>>
Cc: Joonyoung Shim <[email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>>--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/cpu/armv7/exynos/clock.c +2
-2@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 : src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0);break ;default :Quoted 9 lines
Quoted 2 lines
debug("%s: invalid peripheral %d", __func__, peripheral);_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de <javascript:_e(%7B%7D,'cvml','[email protected]');>
http://lists.denx.de/mailman/listinfo/u-boot
Quoted 1 line
This patch will be merged at next week!
Great! Also where are we with the peach Pi display series? Can that go in also?
Regards,
Simon
PATCH 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Hi,
Quoted 68 lines · Simon Glass
Hi Minkyu,
Quoted 3 lines · On 24 March 2015 at 01:45, Minkyu Kang <[email protected] <javascript:;>>…
hi,
On 20 March 2015 at 02:06, Guillaume Gardet <[email protected]
<javascript:;>
Quoted 1 line
<javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>>
Quoted 8 lines · wrote:
Quoted 8 lines
Ping.
Guillaume
Le 11/03/2015 10:34, Guillaume GARDET a ?crit :
Quoted 8 lines
Quoted 8 lines
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: CleanupQuoted 7 lines
soc_get_periph_rate' introduced a bug in I2C config. This patch makescros_ec
keyboard working again on Samsung Chromebook (snow).Changes in V2: reorder lines as requested by Joonyoung Shim.
Signed-off-by Guillaume GARDET <[email protected]<javascript:;>
Quoted 1 line
Quoted 1 line
Quoted 1 line
<javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>
');>>
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Cc: Akshay Saraswat <[email protected] <javascript:;> <javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>>
Cc: Minkyu Kang <[email protected] <javascript:;> <javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>>
Cc: Joonyoung Shim <[email protected] <javascript:;> <javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>>
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/cpu/armv7/exynos/clock.c +0
-0@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 :Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
arch/arm/cpu/armv7/exynos/clock.c +2
-2src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0);break ;default :debug("%s: invalid peripheral %d", __func__,peripheral);
Quoted 9 lines
Quoted 8 lines
Quoted 1 line
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de <javascript:;> <javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>
http://lists.denx.de/mailman/listinfo/u-boot
Quoted 4 lines
Quoted 1 line
This patch will be merged at next week!
Great! Also where are we with the peach Pi display series? Can that go in also?
sure. I'll check it.
Quoted 4 lines
Regards,
Simon
Signature · 2 lines
Thanks. Minkyu Kang.
PATCH 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
Quoted 45 lines · Minkyu Kang
Hi,
Quoted 41 lines · Simon Glass
Hi Minkyu,
Quoted 3 lines · On 24 March 2015 at 01:45, Minkyu Kang <[email protected] <javascript:;>>…
hi,
On 20 March 2015 at 02:06, Guillaume Gardet <[email protected]
<javascript:;>
Quoted 1 line
<javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>>
Quoted 8 lines · wrote:
Quoted 8 lines
Ping.
Guillaume
Le 11/03/2015 10:34, Guillaume GARDET a ?crit :
Quoted 8 lines
Quoted 8 lines
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: CleanupQuoted 7 lines
soc_get_periph_rate' introduced a bug in I2C config. This patch makescros_ec
keyboard working again on Samsung Chromebook (snow).Changes in V2: reorder lines as requested by Joonyoung Shim.
Signed-off-by Guillaume GARDET <[email protected]<javascript:;>
Quoted 1 line
Quoted 1 line
Quoted 1 line
<javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>
');>>
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Cc: Akshay Saraswat <[email protected] <javascript:;> <javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>>
Cc: Minkyu Kang <[email protected] <javascript:;> <javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>>
Cc: Joonyoung Shim <[email protected] <javascript:;> <javascript:_e(%7B%7D,'cvml','[email protected] <javascript:;>');>>
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
PATCH v2 1/1 Exynos: Clock: Fix exynos5_get_periph_rate for I2C.
In reply to Guillaume GardetQuoted 32 lines · Guillaume Gardet
Ping.
Guillaume
Le 11/03/2015 10:34, Guillaume GARDET a ?crit :
Quoted 25 lines
Commit
2e82e9252695a612ab0cbf40fa0c7368515f6506'Exynos: Clock: Cleanupsoc_get_periph_rate' introduced a bug in I2C config. This patch makescros_ec
keyboard working again on Samsung Chromebook (snow).Changes in V2: reorder lines as requested by Joonyoung Shim.
Signed-off-by Guillaume GARDET <[email protected]>Cc Akshay Saraswat <[email protected]>Cc Minkyu Kang <[email protected]>Cc Joonyoung Shim <[email protected]>--- arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/cpu/armv7/exynos/clock.c +0
-0@@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)case PERIPH_ID_I2C6 :case PERIPH_ID_I2C7 :
Quoted 8 lines
Quoted 8 lines
arch/arm/cpu/armv7/exynos/clock.c +2
-2src =EXYNOS_SRC_MPLL ; - div =readl (&clk->div_top0); - sub_div =readl (&clk->div_top1); + div =readl (&clk->div_top1); + sub_div =readl (&clk->div_top0);break ;default :debug("%s: invalid peripheral %d", __func__, peripheral);
Tested on snow.