mx31: Fix boot hang by avoiding vector relocation

PATCH New Fabio Estevam 4 participants 6 messages Feb 23, 2015 – Mar 2, 2015 Arm (32-bit)

lore

Share & tools

lore

Fabio Estevam

author

2015-02-23 12:09 UTC #0 lore raw

PATCH 1/2 mx31: Fix boot hang by avoiding vector relocation

Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx31 does not boot anymore.

Add a specific relocate_vectors macro that skips the vector relocation, as the i.MX31 SoC does not provide RAM at the high vectors address (0xFFFF0000), and (0x00000000) maps to ROM.

This allows mx31 to boot again.

Cc Anatolij Gustschin <[email protected]>

Cc Magnus Lilja <[email protected]>

Signed-off-by Fabio Estevam <[email protected]>

---
Anatolij/Maguns,

I don't have access to a mx31 board.

Could you please test this patch?

Thanks

 arch/arm/cpu/arm1136/mx31/Makefile   |  4 ++++
 arch/arm/cpu/arm1136/mx31/relocate.S | 23 +++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 arch/arm/cpu/arm1136/mx31/relocate.S

arch/arm/cpu/arm1136/mx31/Makefile +4 -0

index 9670ed9..dcbd570 100644
@@ -8,3 +8,7 @@
 obj-y	+= generic.o
 obj-y	+= timer.o
 obj-y	+= devices.o
+
+ifndef CONFIG_SPL_BUILD
+obj-y  += relocate.o
+endif

arch/arm/cpu/arm1136/mx31/relocate.S new file +23 -0

new file mode 100644
index 0000000..1c556df
@@ -0,0 +1,23 @@
+/*
+ *  relocate - i.MX31-specific vector relocation
+ *
+ *  Copyright (c) 2013  Albert ARIBAUD <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#include <linux/linkage.h>
+
+/*
+ * The i.MX31 SoC is very specific with respect to exceptions: it
+ * does not provide RAM at the high vectors address (0xFFFF0000),
+ * thus only the low address (0x00000000) is useable; but that is
+ * in ROM, so let's avoid relocating the vectors.
+ */
+	.section	.text.relocate_vectors,"ax",%progbits
+
+ENTRY(relocate_vectors)
+
+	bx	lr
+
+ENDPROC(relocate_vectors)

Signature · 1 line

1.9.1

Fabio Estevam

author

2015-02-23 12:09 UTC #1 lore raw

PATCH 2/2 mx35: Fix boot hang by avoiding vector relocation

Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx35 does not boot anymore.

Add a specific relocate_vectors macro that skips the vector relocation, as the i.MX35 SoC does not provide RAM at the high vectors address (0xFFFF0000), and (0x00000000) maps to ROM.

This allows mx35 to boot again.

Cc Sebastian Priebe <[email protected]>

Signed-off-by Fabio Estevam <[email protected]>

---
Sebastian,

I don't have access to a mx35 board.

Could you please test this patch?

Thanks

 arch/arm/cpu/arm1136/mx35/Makefile   |  4 ++++
 arch/arm/cpu/arm1136/mx35/relocate.S | 23 +++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 arch/arm/cpu/arm1136/mx35/relocate.S

arch/arm/cpu/arm1136/mx35/Makefile +4 -0

index c533215..796db9c 100644
@@ -10,3 +10,7 @@
 obj-y	+= generic.o
 obj-y	+= timer.o
 obj-y	+= mx35_sdram.o
+
+ifndef CONFIG_SPL_BUILD
+obj-y  += relocate.o
+endif

arch/arm/cpu/arm1136/mx35/relocate.S new file +23 -0

new file mode 100644
index 0000000..43003f8
@@ -0,0 +1,23 @@
+/*
+ *  relocate - i.MX35-specific vector relocation
+ *
+ *  Copyright (c) 2013  Albert ARIBAUD <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#include <linux/linkage.h>
+
+/*
+ * The i.MX35 SoC is very specific with respect to exceptions: it
+ * does not provide RAM at the high vectors address (0xFFFF0000),
+ * thus only the low address (0x00000000) is useable; but that is
+ * in ROM, so let's avoid relocating the vectors.
+ */
+	.section	.text.relocate_vectors,"ax",%progbits
+
+ENTRY(relocate_vectors)
+
+	bx	lr
+
+ENDPROC(relocate_vectors)

Signature · 1 line

1.9.1

Stefano Babic

2015-03-01 15:45 UTC #2 lore raw

PATCH 2/2 mx35: Fix boot hang by avoiding vector relocation

Hi Fabio,

Quoted 11 lines · Fabio Estevam

Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx35 does not boot anymore.
Add a specific relocate_vectors macro that skips the vector relocation, as the i.MX35 SoC does not provide RAM at the high vectors address (0xFFFF0000), and (0x00000000) maps to ROM.
This allows mx35 to boot again.
Cc Sebastian Priebe <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Quoted 9 lines

---
Sebastian,
I don't have access to a mx35 board.
Could you please test this patch?
Thanks

Thanks for the patch !

I have found again a mx35pdk and I could test your patch. 2015.04-rc1 is running on that.

Tested-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Anatolij Gustschin

2015-02-23 13:03 UTC #3 lore raw

PATCH 1/2 mx31: Fix boot hang by avoiding vector relocation

In reply to Fabio Estevam

Hi Fabio,

Quoted 12 lines · On Mon, 23 Feb 2015 09:09:08 -0300 Fabio Estevam <[email protected]>…

Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx31 does not boot anymore.
Add a specific relocate_vectors macro that skips the vector relocation, as the i.MX31 SoC does not provide RAM at the high vectors address (0xFFFF0000), and (0x00000000) maps to ROM.
This allows mx31 to boot again.
Cc Anatolij Gustschin <[email protected]>
Cc Magnus Lilja <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Quoted 6 lines

---
Anatolij/Maguns,
I don't have access to a mx31 board.
Could you please test this patch?

Thanks for the patch! I'll get access to the imx31_phycore board at the beginning of the next week and will test it. Unfortunately I can't test it earlier.

Thanks,

Anatolij

Magnus Lilja

2015-02-24 17:40 UTC #4 lore raw

PATCH 1/2 mx31: Fix boot hang by avoiding vector relocation

Quoted 20 lines · Anatolij Gustschin

Hi Fabio,
Quoted 15 lines · On Mon, 23 Feb 2015 09:09:08 -0300 Fabio Estevam <[email protected]>…
Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx31 does not boot anymore.
Add a specific relocate_vectors macro that skips the vector relocation, as the i.MX31 SoC does not provide RAM at the high vectors address (0xFFFF0000), and (0x00000000) maps to ROM.
This allows mx31 to boot again.
Cc Anatolij Gustschin <[email protected]>
Cc Magnus Lilja <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
Anatolij/Maguns,

Quoted 7 lines

Quoted 3 lines
I don't have access to a mx31 board.
Could you please test this patch?
Thanks for the patch! I'll get access to the imx31_phycore board at the beginning of the next week and will test it. Unfortunately I can't test it earlier.

I might get around to test it before that but I can't promise that.

Regards, Magnus

Stefano Babic

2015-03-02 09:45 UTC #5 lore raw

PATCH 1/2 mx31: Fix boot hang by avoiding vector relocation

In reply to Fabio Estevam

Hi Fabio, Magnus, Anatolji, Sebastian,

Quoted 7 lines · Fabio Estevam

Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx31 does not boot anymore.
Add a specific relocate_vectors macro that skips the vector relocation, as the i.MX31 SoC does not provide RAM at the high vectors address (0xFFFF0000), and (0x00000000) maps to ROM.

Quoted 6 lines

This allows mx31 to boot again.
Cc Anatolij Gustschin <[email protected]>
Cc Magnus Lilja <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---

As boards are currently broken, I think can help if patches are merged even if they are not fully tested. I could at least test on a mx35, and board boots again.

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================