ARM: fix exynos randconfig build error
Subsystems (3)
PATCH 1/1 ARM: fix exynos randconfig build error
The following error was observed with SMP=n in v4.0-rc1:
arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr':arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration]
As the code unconditionally calls a function only available with SMP=y, make the Exynos PM support depend on SMP.
---
Alternatively, the code needs fixing not to call this function on non-SMP platforms.
arch/arm/mach-exynos/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-exynos/Kconfig +1 -0
@@ -131,6 +131,7 @@ config EXYNOS5420_MCPM config EXYNOS_CPU_SUSPEND bool + depends on SMP select ARM_CPU_SUSPEND default PM_SLEEP || ARM_EXYNOS_CPUIDLE
Signature · 1 line
1.8.3.1
PATCH 1/1 ARM: fix exynos randconfig build error
2015-02-25 12:26 GMT+01:00 Russell King <[email protected]>:
Quoted 9 lines
The following error was observed with SMP=n in v4.0-rc1:
arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr':arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration]As the code unconditionally calls a function only available with SMP=y, make the Exynos PM support depend on SMP.
Signed-off-by Russell King <[email protected]>
Hi,
Thanks for the patch but this already waits for Kukjin top be picked up. The first patch was similar to yours (adds dependency on SMP), sent on 4th of February:
https://patchwork.ozlabs.org/patch/436231/
But later Bartlomiej fixed this in other way (allowing to use cpuidle on non-SMP):
https://patchwork.ozlabs.org/patch/436445/
Unfortunately none of them were picked up.
Best regards,
Krzysztof
PATCH 1/1 ARM: fix exynos randconfig build error
Quoted 18 lines · Krzysztof Kozlowski
2015-02-25 12:26 GMT+01:00 Russell King <[email protected]>:
Quoted 9 lines
The following error was observed with SMP=n in v4.0-rc1:
arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr':arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration]As the code unconditionally calls a function only available with SMP=y, make the Exynos PM support depend on SMP.
Signed-off-by Russell King <[email protected]>Hi,
Thanks for the patch but this already waits for Kukjin top be picked up. The first patch was similar to yours (adds dependency on SMP), sent on 4th of February:
https://patchwork.ozlabs.org/patch/436231/
Quoted 6 lines
But later Bartlomiej fixed this in other way (allowing to use cpuidle on non-SMP):
https://patchwork.ozlabs.org/patch/436445/Unfortunately none of them were picked up.
I've missed the fix, sorry.
BTW, as you know, all of exynos SoCs are based on SMP so generally (in normal case) there is no reason to use non-SMP on exynos platforms...even though I understand the build error should be fixed...
Anyway, I'll have a look Bart's patch and Russell's fix in this weekend.
Thanks for your kindly pointing out.
Kukjin
PATCH 1/1 ARM: fix exynos randconfig build error
Quoted 25 lines · Kukjin Kim
Quoted 18 lines · Krzysztof Kozlowski
2015-02-25 12:26 GMT+01:00 Russell King <[email protected]>:
Quoted 9 lines
The following error was observed with SMP=n in v4.0-rc1:
arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr':arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration]As the code unconditionally calls a function only available with SMP=y, make the Exynos PM support depend on SMP.
Signed-off-by Russell King <[email protected]>Hi,
Thanks for the patch but this already waits for Kukjin top be picked up. The first patch was similar to yours (adds dependency on SMP), sent on 4th of February:
https://patchwork.ozlabs.org/patch/436231/Quoted 6 lines
But later Bartlomiej fixed this in other way (allowing to use cpuidle on non-SMP):
https://patchwork.ozlabs.org/patch/436445/Unfortunately none of them were picked up.
Quoted 8 lines
I've missed the fix, sorry.
BTW, as you know, all of exynos SoCs are based on SMP so generally (in normal case) there is no reason to use non-SMP on exynos platforms...even though I understand the build error should be fixed...
Anyway, I'll have a look Bart's patch and Russell's fix in this weekend.
Firstly, let me take rmk's patch for the randconfig build error...BTW I'm still wondering exynos stuff needs to support non-SMP and need to think more about its usefulness?...
- Kukjin
PATCH 1/1 ARM: fix exynos randconfig build error
Hi,
Quoted 28 lines · Kukjin Kim
Quoted 27 lines · Kukjin Kim
Quoted 18 lines · Krzysztof Kozlowski
2015-02-25 12:26 GMT+01:00 Russell King <[email protected]>:
Quoted 9 lines
The following error was observed with SMP=n in v4.0-rc1:
arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr':arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration]As the code unconditionally calls a function only available with SMP=y, make the Exynos PM support depend on SMP.
Signed-off-by Russell King <[email protected]>Hi,
Thanks for the patch but this already waits for Kukjin top be picked up. The first patch was similar to yours (adds dependency on SMP), sent on 4th of February:
https://patchwork.ozlabs.org/patch/436231/Quoted 6 lines
But later Bartlomiej fixed this in other way (allowing to use cpuidle on non-SMP):
https://patchwork.ozlabs.org/patch/436445/Unfortunately none of them were picked up.
I've missed the fix, sorry.
Quoted 8 lines
Quoted 6 lines
BTW, as you know, all of exynos SoCs are based on SMP so generally (in normal case) there is no reason to use non-SMP on exynos platforms...even though I understand the build error should be fixed...
Anyway, I'll have a look Bart's patch and Russell's fix in this weekend.
Firstly, let me take rmk's patch for the randconfig build error...BTW
What is wrong with picking my patch instead? It is non-invasive and fixes cpuidle support on UP (which is a regression from previous kernels)?
https://lkml.org/lkml/2015/2/4/521
Quoted 2 lines
I'm still wondering exynos stuff needs to support non-SMP and need to think more about its usefulness?...
Currently UP is supported and at least I find it useful for testing/debug purposes. If you want to to make Exynos SMP only thats OK but it should be done globally for Exynos arch support not just for cpuidle support.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
PATCH 1/1 ARM: fix exynos randconfig build error
Quoted 44 lines · Bartlomiej Zolnierkiewicz
Hi,
Quoted 28 lines · Kukjin Kim
Quoted 27 lines · Kukjin Kim
Quoted 18 lines · Krzysztof Kozlowski
2015-02-25 12:26 GMT+01:00 Russell King <[email protected]>:
Quoted 9 lines
The following error was observed with SMP=n in v4.0-rc1:
arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr':arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration]As the code unconditionally calls a function only available with SMP=y, make the Exynos PM support depend on SMP.
Signed-off-by Russell King <[email protected]>Hi,
Thanks for the patch but this already waits for Kukjin top be picked up. The first patch was similar to yours (adds dependency on SMP), sent on 4th of February:
https://patchwork.ozlabs.org/patch/436231/Quoted 6 lines
But later Bartlomiej fixed this in other way (allowing to use cpuidle on non-SMP):
https://patchwork.ozlabs.org/patch/436445/Unfortunately none of them were picked up.
I've missed the fix, sorry.
Quoted 8 lines
Quoted 6 lines
BTW, as you know, all of exynos SoCs are based on SMP so generally (in normal case) there is no reason to use non-SMP on exynos platforms...even though I understand the build error should be fixed...
Anyway, I'll have a look Bart's patch and Russell's fix in this weekend.
Firstly, let me take rmk's patch for the randconfig build error...BTW
What is wrong with picking my patch instead? It is non-invasive and fixes cpuidle support on UP (which is a regression from previous kernels)?
Quoted 8 lines
https://lkml.org/lkml/2015/2/4/521
Quoted 2 lines
I'm still wondering exynos stuff needs to support non-SMP and need to think more about its usefulness?...
Currently UP is supported and at least I find it useful for testing/debug purposes. If you want to to make Exynos SMP only thats OK but it should be done globally for Exynos arch support not just for cpuidle support.
Has either of these happened yet? I don't see either in arm-soc.
(lkml.org seems to be - as seems typical - having problems. The above URL now returns a blank message.)
Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
PATCH 1/1 ARM: fix exynos randconfig build error
Hi,
Quoted 50 lines · Russell King - ARM Linux
Quoted 49 lines · Bartlomiej Zolnierkiewicz
Hi,
Quoted 28 lines · Kukjin Kim
Quoted 27 lines · Kukjin Kim
Quoted 18 lines · Krzysztof Kozlowski
2015-02-25 12:26 GMT+01:00 Russell King <[email protected]>:
Quoted 9 lines
The following error was observed with SMP=n in v4.0-rc1:
arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr':arch/arm/mach-exynos/pm.c:246:4: error: implicit declaration of function 'arch_send_wakeup_ipi_mask' [-Werror=implicit-function-declaration]As the code unconditionally calls a function only available with SMP=y, make the Exynos PM support depend on SMP.
Signed-off-by Russell King <[email protected]>Hi,
Thanks for the patch but this already waits for Kukjin top be picked up. The first patch was similar to yours (adds dependency on SMP), sent on 4th of February:
https://patchwork.ozlabs.org/patch/436231/Quoted 6 lines
But later Bartlomiej fixed this in other way (allowing to use cpuidle on non-SMP):
https://patchwork.ozlabs.org/patch/436445/Unfortunately none of them were picked up.
I've missed the fix, sorry.
Quoted 8 lines
Quoted 6 lines
BTW, as you know, all of exynos SoCs are based on SMP so generally (in normal case) there is no reason to use non-SMP on exynos platforms...even though I understand the build error should be fixed...
Anyway, I'll have a look Bart's patch and Russell's fix in this weekend.
Firstly, let me take rmk's patch for the randconfig build error...BTW
What is wrong with picking my patch instead? It is non-invasive and fixes cpuidle support on UP (which is a regression from previous kernels)?
https://lkml.org/lkml/2015/2/4/521
Quoted 2 lines
I'm still wondering exynos stuff needs to support non-SMP and need to think more about its usefulness?...
Quoted 8 lines
Quoted 3 lines
Currently UP is supported and at least I find it useful for testing/debug purposes. If you want to to make Exynos SMP only thats OK but it should be done globally for Exynos arch support not just for cpuidle support.
Has either of these happened yet? I don't see either in arm-soc.
(lkml.org seems to be - as seems typical - having problems. The above URL now returns a blank message.)
My fix has been in Kukjin's tree (and thus linux-next) for the last two weeks:
http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=v4.0-samsung-fixes-2&id=cfdda3535f87e752780ca18a57d13db58f6a6913
Unfortunately it seems that Samsung fixes branch has not been pushed to arm-soc tree yet.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics