Skip to contentSkip to conversation

net: i40e: fix build, depends on CONFIGFS_FS

PATCH In review Randy Dunlap 3 participants 4 messages Mar 3, 2015

Subsystems (3)
Networking Network drivers Intel Ethernet
lore
Share & tools
lore

Randy Dunlap

author
#0 lore raw

PATCH 1/1 net: i40e: fix build, depends on CONFIGFS_FS

From: Randy Dunlap <[email protected]>

i40e uses configfs interfaces so it should depend on CONFIGFS_FS.

Fixes these build errors:

drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x2fcdca): undefined reference to config_item_init_type_name' drivers/built-in.o: In function i40e_configfs_init':
(.text+0x2fcee6): undefined reference to config_group_init' drivers/built-in.o: In function i40e_configfs_init':
(.text+0x2fcf0c): undefined reference to configfs_register_subsystem' drivers/built-in.o: In function i40e_configfs_exit':
(.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem'

Signed-off-by Randy Dunlap <[email protected]>
Cc Linux NICS <[email protected]>
Cc Jeff Kirsher <[email protected]>
---
 drivers/net/ethernet/intel/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/intel/Kconfig +1 -0
@@ -256,6 +256,7 @@ config I40E
 	tristate "Intel(R) Ethernet Controller XL710 Family support"
 	select PTP_1588_CLOCK
 	depends on PCI
+	depends on CONFIGFS_FS
 	---help---
 	  This driver supports Intel(R) Ethernet Controller XL710 Family of
 	  devices.  For more information on how to identify your adapter, go
maintainer
#1 lore raw

From: Randy Dunlap <[email protected]>
Date: Tue, 03 Mar 2015 11:35:38 -0800

Quoted 15 lines

From: Randy Dunlap <[email protected]>

i40e uses configfs interfaces so it should depend on CONFIGFS_FS.

Fixes these build errors:

drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x2fcdca): undefined reference to config_item_init_type_name' drivers/built-in.o: In function i40e_configfs_init':
(.text+0x2fcee6): undefined reference to config_group_init' drivers/built-in.o: In function i40e_configfs_init':
(.text+0x2fcf0c): undefined reference to configfs_register_subsystem' drivers/built-in.o: In function i40e_configfs_exit':
(.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem'

Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>

Intel guys, I am furiously mad.

I've told you guys a thousand times to use portable, reasonable mechanisms to configure your hardware. Using facilities that can be used for other cards from other vendors with similar facilities.

If such portable netdevice configuration frameworks do not exist, create it.

Every time you make a device specific mechanism for configuration, a small kitten dies somewhere in the world.

Please remove all of this configfs crap for twiddling bandwidth et al. knobs, before I do it for you.

Thanks.

#2 lore raw
Quoted 26 lines · David Miller

From: Randy Dunlap <[email protected]>
Date: Tue, 03 Mar 2015 11:35:38 -0800

Quoted 15 lines

From: Randy Dunlap <[email protected]>

i40e uses configfs interfaces so it should depend on CONFIGFS_FS.

Fixes these build errors:

drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x2fcdca): undefined reference to config_item_init_type_name' drivers/built-in.o: In function i40e_configfs_init':
(.text+0x2fcee6): undefined reference to config_group_init' drivers/built-in.o: In function i40e_configfs_init':
(.text+0x2fcf0c): undefined reference to configfs_register_subsystem' drivers/built-in.o: In function i40e_configfs_exit':
(.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem'

Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>

Intel guys, I am furiously mad.

I've told you guys a thousand times to use portable, reasonable mechanisms to configure your hardware. Using facilities that can be used for other cards from other vendors with similar facilities.

Quoted 8 lines

If such portable netdevice configuration frameworks do not exist, create it.

Every time you make a device specific mechanism for configuration, a small kitten dies somewhere in the world.

Please remove all of this configfs crap for twiddling bandwidth et al. knobs, before I do it for you.

Sorry Dave, I did not see the configfs changes as being in the same boat as some of the debugfs changes which were unacceptable.

I am working with Greg Rose and Jesse Brandeburg to address your concerns with these recent changes.

#3 lore raw
In reply to Randy Dunlap
Quoted 17 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

i40e uses configfs interfaces so it should depend on CONFIGFS_FS.

Fixes these build errors:

drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x2fcdca): undefined reference to `config_item_init_type_name'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x2fcee6): undefined reference to config_group_init' drivers/built-in.o: In function i40e_configfs_init':
(.text+0x2fcf0c): undefined reference to configfs_register_subsystem' drivers/built-in.o: In function i40e_configfs_exit':
(.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem'

Quoted 6 lines
Signed-off-by Randy Dunlap <[email protected]>
Cc Linux NICS <[email protected]>
Cc Jeff Kirsher <[email protected]>
---
 drivers/net/ethernet/intel/Kconfig |    1 +
 1 file changed, 1 insertion(+)

I have a patch from Greg Rose already that fixes this, which I was just about to push.