Skip to contentSkip to conversation

umad.h: Remove umad_reg_flags from enum declaration

PATCH In review Hal Rosenstock 2 participants 2 messages Mar 3, 2015 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 umad.h: Remove umad_reg_flags from enum declaration

This causes it to be a global variable which causes linking issues when used by multiple files linked together. It results in multiple definition of `umad_reg_flags'.

Found-by Rafi Weiner <rafiw-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

include/infiniband/umad.h +1 -1
index 6c3e7dc..1db4505 100644
@@ -201,7 +201,7 @@ int umad_unregister(int portid, int agentid);
 
 enum {
 	UMAD_USER_RMPP = (1 << 0)
-} umad_reg_flags;
+};
 
 struct umad_reg_attr {
 	uint8_t    mgmt_class;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 54F61829.3070903-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 10 lines

-----Original Message-----
From: [email protected] [mailto:linux-rdma- [email protected]] On Behalf Of Hal Rosenstock
Sent: Tuesday, March 03, 2015 12:23 PM
To: linux-rdma ([email protected])
Cc: Weiny, Ira; rafiw-VPRAkNaXOzVWk0Htik3J/[email protected]
Subject: [PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration

Quoted 6 lines

This causes it to be a global variable which causes linking issues when used by multiple files linked together. It results in multiple definition of `umad_reg_flags'.

Found-by Rafi Weiner <rafiw-VPRAkNaXOzVWk0Htik3J/[email protected]>
Reviewed-by Ira Weiny <[email protected]>
Quoted 2 lines
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html