Skip to contentSkip to conversation

samsung: board: fix: Define loop iterator as an unsigned int to suppress gcc 4.8 warning

PATCH New Lukasz Majewski 2 participants 2 messages Mar 4, 2015

lore
Share & tools
lore

Lukasz Majewski

author
#0 lore raw

PATCH 1/1 samsung: board: fix: Define loop iterator as an unsigned int to suppress gcc 4.8 warning

This patch suppress following warning:

board/samsung/common/board.c:95:32: warning: iteration 4u invokes undefined behavior [-Waggressive-loop-optimizations]

   addr = CONFIG_SYS_SDRAM_BASE + (i * SDRAM_BANK_SIZE);
                                ^

board/samsung/common/board.c:94:2: note: containing loop

about possible signed integer overflow at gcc 4.8.2 (odroid board)

Signed-off-by Lukasz Majewski <[email protected]>
---
 board/samsung/common/board.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/samsung/common/board.c +2 -2
index 7b10877..d8cf5ab 100644
@@ -89,7 +89,7 @@ int board_init(void)
 
 int dram_init(void)
 {
-	int i;
+	unsigned int i;
 	u32 addr;
 
 	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {

@@ -101,7 +101,7 @@ int dram_init(void)
 
 void dram_init_banksize(void)
 {
-	int i;
+	unsigned int i;
 	u32 addr, size;
 
 	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
Signature · 1 line
2.0.0.rc2
#1 lore raw

PATCH 1/1 samsung: board: fix: Define loop iterator as an unsigned int to suppress gcc 4.8 warning

Quoted 29 lines · Lukasz Majewski

This patch suppress following warning:

board/samsung/common/board.c:95:32: warning: iteration 4u invokes undefined behavior [-Waggressive-loop-optimizations]

   addr = CONFIG_SYS_SDRAM_BASE + (i * SDRAM_BANK_SIZE);
                                ^

board/samsung/common/board.c:94:2: note: containing loop

about possible signed integer overflow at gcc 4.8.2 (odroid board)

Signed-off-by Lukasz Majewski <[email protected]>
---
 board/samsung/common/board.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/samsung/common/board.c +1 -1
index 7b10877..d8cf5ab 100644
@@ -89,7 +89,7 @@ int board_init(void)
 
 int dram_init(void)
 {
-	int i;
+	unsigned int i;
 	u32 addr;
 
 	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {

board/samsung/common/board.c int dram_init(void) · line 107

Quoted 8 lines
board/samsung/common/board.c +1 -1
@@ -101,7 +101,7 @@ int dram_init(void)
 
 void dram_init_banksize(void)
 {
-	int i;
+	unsigned int i;
 	u32 addr, size;
 
 	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {

applied to u-boot-samsung.

Thanks,
Minkyu Kang.