Non-consecutive handle values in GATT

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

      if (gatt_db_attribute_get_handle(attr) !=
                            chrc_data->value_handle)
            goto failed;

    The value of chrc_data->value_handle is correct and matches GATT table

one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

    /* We set handle of characteristic value, which will be added next */
    put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

    Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

BR, Andrey
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Andrejs,

Quoted 35 lines · Andrejs Hanins

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

      if (gatt_db_attribute_get_handle(attr) !=
                            chrc_data->value_handle)
            goto failed;

    The value of chrc_data->value_handle is correct and matches GATT table

one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

    /* We set handle of characteristic value, which will be added next */
    put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

    Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

Quoted 1 line

This is interesting. The gatt-db was initially designed for the server-role, with the assumption being that the handles of a service will be contiguous. So, it allows gaps between separate service ranges but not between individual attributes between the handles of a service. This assumption is OK for server-role but now that we also use gatt-db for the client role, then maybe this assumption is incorrect in some cases.

So I guess we need a way to enter individual attributes with arbitrary handles directly into the database, since it currently creates a contiguous array to store the attributes of a service. I remember Luiz was talking about changing the way the gatt-db addition/removal works on IRC so maybe he can provide more input here. Fwiw, we never encountered this issue because in practice I've never seen a database implementation that skips attribute handles within a service.

Quoted 7 lines

BR, Andrey
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Cheers,
Arman
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Andrejs,

Quoted 35 lines · Arman Uguray

Hi Andrejs,

Quoted 32 lines · Andrejs Hanins

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

     if (gatt_db_attribute_get_handle(attr) !=
                           chrc_data->value_handle)
           goto failed;

The value of chrc_data->value_handle is correct and matches GATT table
one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

   /* We set handle of characteristic value, which will be added next */
   put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

   Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

Quoted 3 lines

Quoted 3 lines

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

Can you share what device are you using? Is it on the market already? I'm just curious as I haven't seen any device doing it on last couple UPFs

But indeed, it looks like this is something we need to fix.

\Lukasz

Quoted 31 lines

This is interesting. The gatt-db was initially designed for the server-role, with the assumption being that the handles of a service will be contiguous. So, it allows gaps between separate service ranges but not between individual attributes between the handles of a service. This assumption is OK for server-role but now that we also use gatt-db for the client role, then maybe this assumption is incorrect in some cases.

So I guess we need a way to enter individual attributes with arbitrary handles directly into the database, since it currently creates a contiguous array to store the attributes of a service. I remember Luiz was talking about changing the way the gatt-db addition/removal works on IRC so maybe he can provide more input here. Fwiw, we never encountered this issue because in practice I've never seen a database implementation that skips attribute handles within a service.

Quoted 7 lines

BR, Andrey
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Cheers,
Arman
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 45 lines · Lukasz Rymanowski

Hi Andrejs,

Quoted 38 lines · Arman Uguray

Hi Andrejs,

Quoted 35 lines · Andrejs Hanins

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

     if (gatt_db_attribute_get_handle(attr) !=
                           chrc_data->value_handle)
           goto failed;

The value of chrc_data->value_handle is correct and matches GATT table
one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

   /* We set handle of characteristic value, which will be added next */
   put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

   Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

Quoted 4 lines

Can you share what device are you using? Is it on the market already? I'm just curious as I haven't seen any device doing it on last couple UPFs

But indeed, it looks like this is something we need to fix.

It's a Broadcom dev kit for LE development. I'm running one of Broadcom examples which has non-consecutive handle values within single service. Of course, there is a full control over GATT and we can change handle values to be on +1 basis, no big deal, but in general BT core specs do not require it, so fix is nice to have to be on a safe side in case there will be such device in a wild. I spent a day to understand it digging the code :)

Quoted 10 lines

\Lukasz

Quoted 9 lines

This is interesting. The gatt-db was initially designed for the server-role, with the assumption being that the handles of a service will be contiguous. So, it allows gaps between separate service ranges but not between individual attributes between the handles of a service. This assumption is OK for server-role but now that we also use gatt-db for the client role, then maybe this assumption is incorrect in some cases.

Quoted 7 lines

Quoted 7 lines

So I guess we need a way to enter individual attributes with arbitrary handles directly into the database, since it currently creates a contiguous array to store the attributes of a service. I remember Luiz was talking about changing the way the gatt-db addition/removal works on IRC so maybe he can provide more input here. Fwiw, we never encountered this issue because in practice I've never seen a database implementation that skips attribute handles within a service.

Hi Andrejs,

Quoted 45 lines · Andrejs Hanins

Quoted 45 lines · Lukasz Rymanowski

Hi Andrejs,

Quoted 38 lines · Arman Uguray

Hi Andrejs,

Quoted 35 lines · Andrejs Hanins

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

     if (gatt_db_attribute_get_handle(attr) !=
                           chrc_data->value_handle)
           goto failed;

The value of chrc_data->value_handle is correct and matches GATT table
one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

   /* We set handle of characteristic value, which will be added next */
   put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

   Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

Quoted 6 lines

Quoted 4 lines

Can you share what device are you using? Is it on the market already? I'm just curious as I haven't seen any device doing it on last couple UPFs

But indeed, it looks like this is something we need to fix.

It's a Broadcom dev kit for LE development. I'm running one of Broadcom examples which has non-consecutive handle values within single service. Of course, there is a full control over GATT and we can change handle values to be on +1 basis, no big deal, but in general BT core specs do not require it, so fix is nice to have to be on a safe side in case there will be such device in a wild. I spent a day to understand it digging the code :)

I guess because it is a low level API you can basically use whatever handles you want, probably OS API would not allow that but as you said we may encounter devices out in the market that do that already.

Quoted 10 lines

Quoted 10 lines

\Lukasz

Quoted 9 lines

This is interesting. The gatt-db was initially designed for the server-role, with the assumption being that the handles of a service will be contiguous. So, it allows gaps between separate service ranges but not between individual attributes between the handles of a service. This assumption is OK for server-role but now that we also use gatt-db for the client role, then maybe this assumption is incorrect in some cases.

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

So I guess we need a way to enter individual attributes with arbitrary handles directly into the database, since it currently creates a contiguous array to store the attributes of a service. I remember Luiz was talking about changing the way the gatt-db addition/removal works on IRC so maybe he can provide more input here. Fwiw, we never encountered this issue because in practice I've never seen a database implementation that skips attribute handles within a service.

Well that was not exactly the problem I was discussing, but anyway it is a problem that we need to fix. Id probably start by adding a unit test where a service skips handles and then fix the gatt_db implementation to handle that, speaking about implementation we could either go with list but the entries would then need to store the handles separately or we keep the current array and leave the gaps with NULL pointers, I guess the later is still more efficient since we are talking about a special case and storing the handles per list entry might increase our memory consumption.

Hi Andrejs,

Quoted 77 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 45 lines · Andrejs Hanins

Quoted 45 lines · Lukasz Rymanowski

Hi Andrejs,

Quoted 38 lines · Arman Uguray

Hi Andrejs,

Quoted 35 lines · Andrejs Hanins

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

     if (gatt_db_attribute_get_handle(attr) !=
                           chrc_data->value_handle)
           goto failed;

The value of chrc_data->value_handle is correct and matches GATT table
one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

   /* We set handle of characteristic value, which will be added next */
   put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

   Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

Quoted 6 lines

Quoted 4 lines

Can you share what device are you using? Is it on the market already? I'm just curious as I haven't seen any device doing it on last couple UPFs

But indeed, it looks like this is something we need to fix.

It's a Broadcom dev kit for LE development. I'm running one of Broadcom examples which has non-consecutive handle values within single service. Of course, there is a full control over GATT and we can change handle values to be on +1 basis, no big deal, but in general BT core specs do not require it, so fix is nice to have to be on a safe side in case there will be such device in a wild. I spent a day to understand it digging the code :)

I guess because it is a low level API you can basically use whatever handles you want, probably OS API would not allow that but as you said we may encounter devices out in the market that do that already.

Quoted 10 lines

Quoted 10 lines

\Lukasz

Quoted 9 lines

This is interesting. The gatt-db was initially designed for the server-role, with the assumption being that the handles of a service will be contiguous. So, it allows gaps between separate service ranges but not between individual attributes between the handles of a service. This assumption is OK for server-role but now that we also use gatt-db for the client role, then maybe this assumption is incorrect in some cases.

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

So I guess we need a way to enter individual attributes with arbitrary handles directly into the database, since it currently creates a contiguous array to store the attributes of a service. I remember Luiz was talking about changing the way the gatt-db addition/removal works on IRC so maybe he can provide more input here. Fwiw, we never encountered this issue because in practice I've never seen a database implementation that skips attribute handles within a service.

Quoted 9 lines

Well that was not exactly the problem I was discussing, but anyway it is a problem that we need to fix. Id probably start by adding a unit test where a service skips handles and then fix the gatt_db implementation to handle that, speaking about implementation we could either go with list but the entries would then need to store the handles separately or we keep the current array and leave the gaps with NULL pointers, I guess the later is still more efficient since we are talking about a special case and storing the handles per list entry might increase our memory consumption.

I just posted a patch-set that attempts to fix this, at least with unit test Ive created it seems to work but I would appreciate if you could try with your setup as well.

HCI Event: Command Status (0x0f) plen 4

HCI Event: LE Meta Event (0x3e) plen 19

ACL data: handle 64 flags 0x02 dlen 7

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 18

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 26

ACL data: handle 64 flags 0x02 dlen 9

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 9

ACL data: handle 64 flags 0x02 dlen 9

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 9

ACL data: handle 64 flags 0x02 dlen 20

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 9

HCI Event: Command Status (0x0f) plen 4

HCI Event: Disconn Complete (0x05) plen 4

Hi Luiz,

Quoted 91 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 77 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 45 lines · Andrejs Hanins

Quoted 45 lines · Lukasz Rymanowski

Hi Andrejs,

Quoted 38 lines · Arman Uguray

Hi Andrejs,

Quoted 35 lines · Andrejs Hanins

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

     if (gatt_db_attribute_get_handle(attr) !=
                           chrc_data->value_handle)
           goto failed;

The value of chrc_data->value_handle is correct and matches GATT table
one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

   /* We set handle of characteristic value, which will be added next */
   put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

   Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

Quoted 6 lines

Quoted 4 lines

Can you share what device are you using? Is it on the market already? I'm just curious as I haven't seen any device doing it on last couple UPFs

But indeed, it looks like this is something we need to fix.

It's a Broadcom dev kit for LE development. I'm running one of Broadcom examples which has non-consecutive handle values within single service. Of course, there is a full control over GATT and we can change handle values to be on +1 basis, no big deal, but in general BT core specs do not require it, so fix is nice to have to be on a safe side in case there will be such device in a wild. I spent a day to understand it digging the code :)

I guess because it is a low level API you can basically use whatever handles you want, probably OS API would not allow that but as you said we may encounter devices out in the market that do that already.

Quoted 10 lines

Quoted 10 lines

\Lukasz

Quoted 9 lines

This is interesting. The gatt-db was initially designed for the server-role, with the assumption being that the handles of a service will be contiguous. So, it allows gaps between separate service ranges but not between individual attributes between the handles of a service. This assumption is OK for server-role but now that we also use gatt-db for the client role, then maybe this assumption is incorrect in some cases.

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

So I guess we need a way to enter individual attributes with arbitrary handles directly into the database, since it currently creates a contiguous array to store the attributes of a service. I remember Luiz was talking about changing the way the gatt-db addition/removal works on IRC so maybe he can provide more input here. Fwiw, we never encountered this issue because in practice I've never seen a database implementation that skips attribute handles within a service.

Quoted 9 lines

Well that was not exactly the problem I was discussing, but anyway it is a problem that we need to fix. Id probably start by adding a unit test where a service skips handles and then fix the gatt_db implementation to handle that, speaking about implementation we could either go with list but the entries would then need to store the handles separately or we keep the current array and leave the gaps with NULL pointers, I guess the later is still more efficient since we are talking about a special case and storing the handles per list entry might increase our memory consumption.

Quoted 3 lines

I just posted a patch-set that attempts to fix this, at least with unit test Ive created it seems to work but I would appreciate if you could try with your setup as well.

Tried on 0d468ec37cf42915f5873a40185b5f3a588c28ba and it still fails for my device. FYI - iOS and Android can successfully connect to this device and discover characteristics. Here is some analysis I made which might help you:

< HCI Command: LE Create Connection (0x08|0x000d) plen 25
bdaddr 20:73:6A:17:69:31 type 0
interval 96 window 48 initiator_filter 0 own_bdaddr_type 0 min_interval 40 max_interval 56 latency 0 supervision_to 42 min_ce 0 max_ce 0

Quoted 1 line

HCI Event: Command Status (0x0f) plen 4

    LE Create Connection (0x08|0x000d) status 0x00 ncmd 1

Quoted 1 line

HCI Event: LE Meta Event (0x3e) plen 19

    LE Connection Complete
      status 0x00 handle 64, role master
      bdaddr 20:73:6A:17:69:31 (Public)

< ACL data: handle 64 flags 0x00 dlen 7
ATT: MTU req (0x02)
client rx mtu 517

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 7

ATT: MTU resp (0x03)
server rx mtu 23
< ACL data: handle 64 flags 0x00 dlen 11

    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 18

    ATT: Read By Group resp (0x11)
      attr handle 0x0100, end group handle 0x0121
      value 0x00 0x18
      attr handle 0x0200, end group handle 0x0200
      value 0x01 0x18
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0201, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 26

    ATT: Read By Group resp (0x11)
      attr handle 0x0300, end group handle 0x0320
      value 0xbf 0x90 0x21 0x8e 0xc0 0x68 0x4c 0x00 0x84 0x01 0x2d 0xba 0x08 0xab 0x32 0x88
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0321, end 0xffff
      type-uuid 0x2800

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0321
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2801

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0001
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2802

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0100
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2802

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0300
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2803                    <---- Characteristics in range 0x0100-0x0121 are requested.

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a 
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a  <---- Rsp: Chrc with descriptor handle 0x0120, value handle 0x0121 and standard 16bit UUID=0x2a01 ("Characteristic appearance")

< ACL data: handle 64 flags 0x00 dlen 11

    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803     <--- Here request is made for a single attribute with handle 0x0121 which is supposed to have UUID 0x2a01, as per previous response, but the request suggests that type should be UUID 0x2803 (Characteristic descriptor), which is wrong.

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121  <---- As expected, there is no such attribute with handle 0x0121 and UUID 0x2803. A valid att request is for handle 0x0121 and UUID 0x2a01.

< HCI Command: Disconnect (0x01|0x0006) plen 3
handle 64 reason 0x13
Reason: Remote User Terminated Connection

Quoted 1 line

HCI Event: Command Status (0x0f) plen 4

    Disconnect (0x01|0x0006) status 0x00 ncmd 1

Quoted 1 line

HCI Event: Disconn Complete (0x05) plen 4

status 0x00 handle 64 reason 0x16
Reason: Connection Terminated by Local Host

HCI Event: Command Status (0x0f) plen 4

HCI Event: LE Meta Event (0x3e) plen 19

ACL data: handle 64 flags 0x02 dlen 7

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 18

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 26

ACL data: handle 64 flags 0x02 dlen 9

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 9

ACL data: handle 64 flags 0x02 dlen 9

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 9

ACL data: handle 64 flags 0x02 dlen 20

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 9

ACL data: handle 64 flags 0x02 dlen 9

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 27

HCI Event: Number of Completed Packets (0x13) plen 5

ACL data: handle 64 flags 0x02 dlen 9

Luiz,

Quoted 202 lines · Andrejs Hanins

Hi Luiz,

Quoted 91 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 77 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 45 lines · Andrejs Hanins

Quoted 45 lines · Lukasz Rymanowski

Hi Andrejs,

Quoted 38 lines · Arman Uguray

Hi Andrejs,

Quoted 35 lines · Andrejs Hanins

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

     if (gatt_db_attribute_get_handle(attr) !=
                           chrc_data->value_handle)
           goto failed;

The value of chrc_data->value_handle is correct and matches GATT table
one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

   /* We set handle of characteristic value, which will be added next */
   put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

   Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

Quoted 6 lines

Quoted 4 lines

Can you share what device are you using? Is it on the market already? I'm just curious as I haven't seen any device doing it on last couple UPFs

But indeed, it looks like this is something we need to fix.

It's a Broadcom dev kit for LE development. I'm running one of Broadcom examples which has non-consecutive handle values within single service. Of course, there is a full control over GATT and we can change handle values to be on +1 basis, no big deal, but in general BT core specs do not require it, so fix is nice to have to be on a safe side in case there will be such device in a wild. I spent a day to understand it digging the code :)

I guess because it is a low level API you can basically use whatever handles you want, probably OS API would not allow that but as you said we may encounter devices out in the market that do that already.

Quoted 10 lines

Quoted 10 lines

\Lukasz

Quoted 9 lines

This is interesting. The gatt-db was initially designed for the server-role, with the assumption being that the handles of a service will be contiguous. So, it allows gaps between separate service ranges but not between individual attributes between the handles of a service. This assumption is OK for server-role but now that we also use gatt-db for the client role, then maybe this assumption is incorrect in some cases.

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

So I guess we need a way to enter individual attributes with arbitrary handles directly into the database, since it currently creates a contiguous array to store the attributes of a service. I remember Luiz was talking about changing the way the gatt-db addition/removal works on IRC so maybe he can provide more input here. Fwiw, we never encountered this issue because in practice I've never seen a database implementation that skips attribute handles within a service.

Quoted 9 lines

Well that was not exactly the problem I was discussing, but anyway it is a problem that we need to fix. Id probably start by adding a unit test where a service skips handles and then fix the gatt_db implementation to handle that, speaking about implementation we could either go with list but the entries would then need to store the handles separately or we keep the current array and leave the gaps with NULL pointers, I guess the later is still more efficient since we are talking about a special case and storing the handles per list entry might increase our memory consumption.

Quoted 3 lines

I just posted a patch-set that attempts to fix this, at least with unit test Ive created it seems to work but I would appreciate if you could try with your setup as well.

Tried on 0d468ec37cf42915f5873a40185b5f3a588c28ba and it still fails for my device. FYI - iOS and Android can successfully connect to this device and discover characteristics. Here is some analysis I made which might help you:

< HCI Command: LE Create Connection (0x08|0x000d) plen 25
bdaddr 20:73:6A:17:69:31 type 0
interval 96 window 48 initiator_filter 0 own_bdaddr_type 0 min_interval 40 max_interval 56 latency 0 supervision_to 42 min_ce 0 max_ce 0

Quoted 1 line

HCI Event: Command Status (0x0f) plen 4

    LE Create Connection (0x08|0x000d) status 0x00 ncmd 1

Quoted 1 line

HCI Event: LE Meta Event (0x3e) plen 19

    LE Connection Complete
      status 0x00 handle 64, role master
      bdaddr 20:73:6A:17:69:31 (Public)

< ACL data: handle 64 flags 0x00 dlen 7
ATT: MTU req (0x02)
client rx mtu 517

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 7

ATT: MTU resp (0x03)
server rx mtu 23
< ACL data: handle 64 flags 0x00 dlen 11

    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 18

    ATT: Read By Group resp (0x11)
      attr handle 0x0100, end group handle 0x0121
      value 0x00 0x18
      attr handle 0x0200, end group handle 0x0200
      value 0x01 0x18
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0201, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 26

    ATT: Read By Group resp (0x11)
      attr handle 0x0300, end group handle 0x0320
      value 0xbf 0x90 0x21 0x8e 0xc0 0x68 0x4c 0x00 0x84 0x01 0x2d 0xba 0x08 0xab 0x32 0x88
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0321, end 0xffff
      type-uuid 0x2800

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0321
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2801

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0001
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2802

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0100
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2802

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0300
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2803                    <---- Characteristics in range 0x0100-0x0121 are requested.

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a  <---- Rsp: Chrc with descriptor handle 0x0120, value handle 0x0121 and standard 16bit UUID=0x2a01 ("Characteristic appearance")

< ACL data: handle 64 flags 0x00 dlen 11

    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803     <--- Here request is made for a single attribute with handle 0x0121 which is supposed to have UUID 0x2a01, as per previous response, but the request suggests that type should be UUID 0x2803 (Characteristic descriptor), which is wrong.

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121  <---- As expected, there is no such attribute with handle 0x0121 and UUID 0x2803. A valid att request is for handle 0x0121 and UUID 0x2a01.

Quoted 9 lines

< HCI Command: Disconnect (0x01|0x0006) plen 3
handle 64 reason 0x13
Reason: Remote User Terminated Connection

Quoted 1 line

HCI Event: Command Status (0x0f) plen 4

    Disconnect (0x01|0x0006) status 0x00 ncmd 1

Quoted 1 line

HCI Event: Disconn Complete (0x05) plen 4

status 0x00 handle 64 reason 0x16
Reason: Connection Terminated by Local Host

Sorry, the test above was made with latest master *without* your patches. I re-run the test with a patch from e-mail, but discovery still fails, however the dump output is slightly different:

< HCI Command: LE Create Connection (0x08|0x000d) plen 25
bdaddr 20:73:6A:17:69:31 type 0
interval 96 window 48 initiator_filter 0 own_bdaddr_type 0 min_interval 40 max_interval 56 latency 0 supervision_to 42 min_ce 0 max_ce 0

Quoted 1 line

HCI Event: Command Status (0x0f) plen 4

    LE Create Connection (0x08|0x000d) status 0x00 ncmd 1

Quoted 1 line

HCI Event: LE Meta Event (0x3e) plen 19

    LE Connection Complete
      status 0x00 handle 64, role master
      bdaddr 20:73:6A:17:69:31 (Public)

< ACL data: handle 64 flags 0x00 dlen 7
ATT: MTU req (0x02)
client rx mtu 517

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 7

ATT: MTU resp (0x03)
server rx mtu 23
< ACL data: handle 64 flags 0x00 dlen 11

    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 18

    ATT: Read By Group resp (0x11)
      attr handle 0x0100, end group handle 0x0121
      value 0x00 0x18
      attr handle 0x0200, end group handle 0x0200
      value 0x01 0x18
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0201, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 26

    ATT: Read By Group resp (0x11)
      attr handle 0x0300, end group handle 0x0320
      value 0xbf 0x90 0x21 0x8e 0xc0 0x68 0x4c 0x00 0x84 0x01 0x2d 0xba 0x08 0xab 0x32 0x88
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0321, end 0xffff
      type-uuid 0x2800

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0321
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2801

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0001
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2802

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0100
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2802

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0300
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2803

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803      <--- as without patch, this seems to be suspicious. Single att read request with wrong UUID.

Quoted 3 lines

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121
< ACL data: handle 64 flags 0x00 dlen 9
    ATT: Find Information req (0x04)
      start 0x0112, end 0x011f

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Find Information req (0x04) on handle 0x0112
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 27

    ATT: Read By Type resp (0x09)
      length: 21
        handle 0x0310, value 0x3e 0x11 0x03 0x34 0x5b 0xe2 0x12 0x5e 0xb1 0x45 0x03 0xb6 0x29 0x24 0x55 0x8a 0x11 0x1e 0x36
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0311, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0311

Hi Andrejs,

Quoted 296 lines · Andrejs Hanins

Luiz,

Quoted 202 lines · Andrejs Hanins

Hi Luiz,

Quoted 91 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 77 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 45 lines · Andrejs Hanins

Quoted 45 lines · Lukasz Rymanowski

Hi Andrejs,

Quoted 38 lines · Arman Uguray

Hi Andrejs,

Quoted 35 lines · Andrejs Hanins

Hello,

I'm experimenting with an LE peripheral device which provides GATT
services described by attributes with non-consecutive handle values, i.e. there are "gaps" between handle values. According to the Bluetooth Core specification 4.0 (Volume 3, Part G, "2.5.1 Overview") it is allowed:

Although the Attribute Handle values are in increasing order, following
Attribute Handle values may differ by more than one.

Based on my experiments, BlueZ 5.28 and also git-master as of today does
not support non-consecutive handle values GATT table. As a result, I can't connect to my device because gatt-client fails to initialize properly. The failing place is in discover_descs():

     if (gatt_db_attribute_get_handle(attr) !=
                           chrc_data->value_handle)
           goto failed;

The value of chrc_data->value_handle is correct and matches GATT table
one the device, but the attr->handle has the value of previous attribute (Primary Service UUID in my case) +2. This handle value calculation happens in gatt_db_service_add_characteristic() which has strange code:

   /* We set handle of characteristic value, which will be added next */
   put_le16(get_handle_at_index(service, i - 1) + 2, &value[1]);

   Before trying to fix the problem by myself it would be great to hear

some comments about this issue. Does it seem like a bug or I missed something?

As a note, I can successfully connect to my LE peripheral from an iPhone
LightBlue app, which does not posses any issues during GATT discovery and can read/write the characteristic on the device.

Quoted 6 lines

Quoted 4 lines

Can you share what device are you using? Is it on the market already? I'm just curious as I haven't seen any device doing it on last couple UPFs

But indeed, it looks like this is something we need to fix.

It's a Broadcom dev kit for LE development. I'm running one of Broadcom examples which has non-consecutive handle values within single service. Of course, there is a full control over GATT and we can change handle values to be on +1 basis, no big deal, but in general BT core specs do not require it, so fix is nice to have to be on a safe side in case there will be such device in a wild. I spent a day to understand it digging the code :)

I guess because it is a low level API you can basically use whatever handles you want, probably OS API would not allow that but as you said we may encounter devices out in the market that do that already.

Quoted 10 lines

Quoted 10 lines

\Lukasz

Quoted 9 lines

This is interesting. The gatt-db was initially designed for the server-role, with the assumption being that the handles of a service will be contiguous. So, it allows gaps between separate service ranges but not between individual attributes between the handles of a service. This assumption is OK for server-role but now that we also use gatt-db for the client role, then maybe this assumption is incorrect in some cases.

Quoted 7 lines

Quoted 7 lines

Quoted 7 lines

So I guess we need a way to enter individual attributes with arbitrary handles directly into the database, since it currently creates a contiguous array to store the attributes of a service. I remember Luiz was talking about changing the way the gatt-db addition/removal works on IRC so maybe he can provide more input here. Fwiw, we never encountered this issue because in practice I've never seen a database implementation that skips attribute handles within a service.

Quoted 9 lines

Well that was not exactly the problem I was discussing, but anyway it is a problem that we need to fix. Id probably start by adding a unit test where a service skips handles and then fix the gatt_db implementation to handle that, speaking about implementation we could either go with list but the entries would then need to store the handles separately or we keep the current array and leave the gaps with NULL pointers, I guess the later is still more efficient since we are talking about a special case and storing the handles per list entry might increase our memory consumption.

Quoted 3 lines

I just posted a patch-set that attempts to fix this, at least with unit test Ive created it seems to work but I would appreciate if you could try with your setup as well.

Tried on 0d468ec37cf42915f5873a40185b5f3a588c28ba and it still fails for my device. FYI - iOS and Android can successfully connect to this device and discover characteristics. Here is some analysis I made which might help you:

< HCI Command: LE Create Connection (0x08|0x000d) plen 25
bdaddr 20:73:6A:17:69:31 type 0
interval 96 window 48 initiator_filter 0 own_bdaddr_type 0 min_interval 40 max_interval 56 latency 0 supervision_to 42 min_ce 0 max_ce 0

Quoted 1 line

HCI Event: Command Status (0x0f) plen 4

    LE Create Connection (0x08|0x000d) status 0x00 ncmd 1

Quoted 1 line

HCI Event: LE Meta Event (0x3e) plen 19

    LE Connection Complete
      status 0x00 handle 64, role master
      bdaddr 20:73:6A:17:69:31 (Public)

< ACL data: handle 64 flags 0x00 dlen 7
ATT: MTU req (0x02)
client rx mtu 517

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 7

ATT: MTU resp (0x03)
server rx mtu 23
< ACL data: handle 64 flags 0x00 dlen 11

    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 18

    ATT: Read By Group resp (0x11)
      attr handle 0x0100, end group handle 0x0121
      value 0x00 0x18
      attr handle 0x0200, end group handle 0x0200
      value 0x01 0x18
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0201, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 26

    ATT: Read By Group resp (0x11)
      attr handle 0x0300, end group handle 0x0320
      value 0xbf 0x90 0x21 0x8e 0xc0 0x68 0x4c 0x00 0x84 0x01 0x2d 0xba 0x08 0xab 0x32 0x88
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0321, end 0xffff
      type-uuid 0x2800

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0321
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2801

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0001
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2802

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0100
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2802

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0300
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2803                    <---- Characteristics in range 0x0100-0x0121 are requested.

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a  <---- Rsp: Chrc with descriptor handle 0x0120, value handle 0x0121 and standard 16bit UUID=0x2a01 ("Characteristic appearance")

< ACL data: handle 64 flags 0x00 dlen 11

    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803     <--- Here request is made for a single attribute with handle 0x0121 which is supposed to have UUID 0x2a01, as per previous response, but the request suggests that type should be UUID 0x2803 (Characteristic descriptor), which is wrong.

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121  <---- As expected, there is no such attribute with handle 0x0121 and UUID 0x2803. A valid att request is for handle 0x0121 and UUID 0x2a01.

Quoted 9 lines

< HCI Command: Disconnect (0x01|0x0006) plen 3
handle 64 reason 0x13
Reason: Remote User Terminated Connection

Quoted 1 line

HCI Event: Command Status (0x0f) plen 4

    Disconnect (0x01|0x0006) status 0x00 ncmd 1

Quoted 1 line

HCI Event: Disconn Complete (0x05) plen 4

status 0x00 handle 64 reason 0x16
Reason: Connection Terminated by Local Host

Sorry, the test above was made with latest master *without* your patches. I re-run the test with a patch from e-mail, but discovery still fails, however the dump output is slightly different:

< HCI Command: LE Create Connection (0x08|0x000d) plen 25
bdaddr 20:73:6A:17:69:31 type 0
interval 96 window 48 initiator_filter 0 own_bdaddr_type 0 min_interval 40 max_interval 56 latency 0 supervision_to 42 min_ce 0 max_ce 0

Quoted 1 line

HCI Event: Command Status (0x0f) plen 4

    LE Create Connection (0x08|0x000d) status 0x00 ncmd 1

Quoted 1 line

HCI Event: LE Meta Event (0x3e) plen 19

    LE Connection Complete
      status 0x00 handle 64, role master
      bdaddr 20:73:6A:17:69:31 (Public)

< ACL data: handle 64 flags 0x00 dlen 7
ATT: MTU req (0x02)
client rx mtu 517

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 7

ATT: MTU resp (0x03)
server rx mtu 23
< ACL data: handle 64 flags 0x00 dlen 11

    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 18

    ATT: Read By Group resp (0x11)
      attr handle 0x0100, end group handle 0x0121
      value 0x00 0x18
      attr handle 0x0200, end group handle 0x0200
      value 0x01 0x18
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0201, end 0xffff
      type-uuid 0x2800

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 26

    ATT: Read By Group resp (0x11)
      attr handle 0x0300, end group handle 0x0320
      value 0xbf 0x90 0x21 0x8e 0xc0 0x68 0x4c 0x00 0x84 0x01 0x2d 0xba 0x08 0xab 0x32 0x88
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0321, end 0xffff
      type-uuid 0x2800

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0321
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Group req (0x10)
      start 0x0001, end 0xffff
      type-uuid 0x2801

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Group req (0x10) on handle 0x0001
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2802

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0100
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2802

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0300
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0100, end 0x0121
      type-uuid 0x2803

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

Quoted 8 lines

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803      <--- as without patch, this seems to be suspicious. Single att read request with wrong UUID.

Maybe this is off by 1 error except if start 0x0100, end 0x0121 range actually exclude the last, but it would be still wrong the start 0x0121, end 0x0121, anyway this seems to be some other problem.

Quoted 31 lines

Quoted 3 lines

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121
< ACL data: handle 64 flags 0x00 dlen 9
    ATT: Find Information req (0x04)
      start 0x0112, end 0x011f

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Find Information req (0x04) on handle 0x0112
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 27

    ATT: Read By Type resp (0x09)
      length: 21
        handle 0x0310, value 0x3e 0x11 0x03 0x34 0x5b 0xe2 0x12 0x5e 0xb1 0x45 0x03 0xb6 0x29 0x24 0x55 0x8a 0x11 0x1e 0x36
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0311, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 4 lines

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0311

Can you collect the trace in binary format, e.g. btmon -w <file>, I can perhaps try to create the very same database for unit tests, also it would be good to have bluetoothd traces.

Quoted 10 lines

Quoted 9 lines

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803      <--- as without patch, this seems to be suspicious. Single att read request with wrong UUID.

Quoted 3 lines

Maybe this is off by 1 error except if start 0x0100, end 0x0121 range actually exclude the last, but it would be still wrong the start 0x0121, end 0x0121, anyway this seems to be some other problem.

Quoted 33 lines

Quoted 33 lines

Quoted 4 lines

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121
< ACL data: handle 64 flags 0x00 dlen 9
    ATT: Find Information req (0x04)
      start 0x0112, end 0x011f

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Find Information req (0x04) on handle 0x0112
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 27

    ATT: Read By Type resp (0x09)
      length: 21
        handle 0x0310, value 0x3e 0x11 0x03 0x34 0x5b 0xe2 0x12 0x5e 0xb1 0x45 0x03 0xb6 0x29 0x24 0x55 0x8a 0x11 0x1e 0x36
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0311, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

Quoted 7 lines

Quoted 3 lines

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0311

Can you collect the trace in binary format, e.g. btmon -w <file>, I can perhaps try to create the very same database for unit tests, also it would be good to have bluetoothd traces.

Traces attached.

Hi Andrejs,

Quoted 10 lines

Quoted 10 lines

Quoted 9 lines

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803      <--- as without patch, this seems to be suspicious. Single att read request with wrong UUID.

Quoted 3 lines

Quoted 3 lines

Maybe this is off by 1 error except if start 0x0100, end 0x0121 range actually exclude the last, but it would be still wrong the start 0x0121, end 0x0121, anyway this seems to be some other problem.

Actually this is fine, we are discovering the characteristics since they may not fit in a single frame we just continue from where we stop at 0x0121 until the end of the service range with just happen to be 0x0121.

Quoted 33 lines

Quoted 33 lines

Quoted 33 lines

Quoted 4 lines

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121
< ACL data: handle 64 flags 0x00 dlen 9
    ATT: Find Information req (0x04)
      start 0x0112, end 0x011f

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Find Information req (0x04) on handle 0x0112
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 27

    ATT: Read By Type resp (0x09)
      length: 21
        handle 0x0310, value 0x3e 0x11 0x03 0x34 0x5b 0xe2 0x12 0x5e 0xb1 0x45 0x03 0xb6 0x29 0x24 0x55 0x8a 0x11 0x1e 0x36
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0311, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

Quoted 8 lines

Quoted 7 lines

Quoted 3 lines

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0311

Can you collect the trace in binary format, e.g. btmon -w <file>, I can perhaps try to create the very same database for unit tests, also it would be good to have bluetoothd traces.

Traces attached.

Can you please enable bt_gatt_client debug with the following patch:

src/device.c +5 -0

index aaa9f43..6a23adc 100644
@@ -3989,6 +3989,11 @@ static void
 gatt_client_service_changed(uint16_t start_handle,
        DBG("start 0x%04x, end: 0x%04x", start_handle, end_handle);
 }
 
+static void gatt_debug(const char *str, void *user_data)
+{
+       DBG("%s", str);
+}
+
 static void gatt_client_init(struct btd_device *device)
 {

        gatt_client_cleanup(device);

Hi Luiz,

Quoted 87 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 10 lines

Quoted 10 lines

Quoted 9 lines

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803      <--- as without patch, this seems to be suspicious. Single att read request with wrong UUID.

Quoted 3 lines

Quoted 3 lines

Maybe this is off by 1 error except if start 0x0100, end 0x0121 range actually exclude the last, but it would be still wrong the start 0x0121, end 0x0121, anyway this seems to be some other problem.

Actually this is fine, we are discovering the characteristics since they may not fit in a single frame we just continue from where we stop at 0x0121 until the end of the service range with just happen to be 0x0121.

Quoted 33 lines

Quoted 33 lines

Quoted 33 lines

Quoted 4 lines

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121
< ACL data: handle 64 flags 0x00 dlen 9
    ATT: Find Information req (0x04)
      start 0x0112, end 0x011f

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Find Information req (0x04) on handle 0x0112
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 27

    ATT: Read By Type resp (0x09)
      length: 21
        handle 0x0310, value 0x3e 0x11 0x03 0x34 0x5b 0xe2 0x12 0x5e 0xb1 0x45 0x03 0xb6 0x29 0x24 0x55 0x8a 0x11 0x1e 0x36
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0311, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

Quoted 8 lines

Quoted 7 lines

Quoted 3 lines

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0311

Can you collect the trace in binary format, e.g. btmon -w <file>, I can perhaps try to create the very same database for unit tests, also it would be good to have bluetoothd traces.

Traces attached.

Can you please enable bt_gatt_client debug with the following patch:

src/device.c +5 -0

index aaa9f43..6a23adc 100644
@@ -3989,6 +3989,11 @@ static void
 gatt_client_service_changed(uint16_t start_handle,
        DBG("start 0x%04x, end: 0x%04x", start_handle, end_handle);
 }
 
+static void gatt_debug(const char *str, void *user_data)
+{
+       DBG("%s", str);
+}
+
 static void gatt_client_init(struct btd_device *device)
 {

        gatt_client_cleanup(device);

src/device.c +0 -0

@@ -4000,6 +4005,8 @@ static void gatt_client_init(struct btd_device *device)
                return;
        }
 

src/device.c static void gatt_client_init(struct btd_device *device) · line 4012

Quoted 6 lines

src/device.c +2 -0

+       bt_gatt_client_set_debug(device->client, gatt_debug, NULL, NULL);
+
        /* Notify attio so it can react to notifications */
        g_slist_foreach(device->attios, attio_connected, device->attrib);
 

See attachments. Fresh dumps from both btmon and daemon. With your patch "shared/gatt-client: Fix handling of services" applied.

Hi Andrejs,

Quoted 90 lines · Andrejs Hanins

Hi Luiz,

Quoted 87 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 10 lines

Quoted 10 lines

Quoted 9 lines

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803      <--- as without patch, this seems to be suspicious. Single att read request with wrong UUID.

Quoted 3 lines

Quoted 3 lines

Maybe this is off by 1 error except if start 0x0100, end 0x0121 range actually exclude the last, but it would be still wrong the start 0x0121, end 0x0121, anyway this seems to be some other problem.

Actually this is fine, we are discovering the characteristics since they may not fit in a single frame we just continue from where we stop at 0x0121 until the end of the service range with just happen to be 0x0121.

Quoted 33 lines

Quoted 33 lines

Quoted 33 lines

Quoted 4 lines

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121
< ACL data: handle 64 flags 0x00 dlen 9
    ATT: Find Information req (0x04)
      start 0x0112, end 0x011f

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Find Information req (0x04) on handle 0x0112
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 27

    ATT: Read By Type resp (0x09)
      length: 21
        handle 0x0310, value 0x3e 0x11 0x03 0x34 0x5b 0xe2 0x12 0x5e 0xb1 0x45 0x03 0xb6 0x29 0x24 0x55 0x8a 0x11 0x1e 0x36
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0311, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

Quoted 8 lines

Quoted 7 lines

Quoted 3 lines

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0311

Can you collect the trace in binary format, e.g. btmon -w <file>, I can perhaps try to create the very same database for unit tests, also it would be good to have bluetoothd traces.

Traces attached.

Can you please enable bt_gatt_client debug with the following patch:

src/device.c +5 -0

index aaa9f43..6a23adc 100644
@@ -3989,6 +3989,11 @@ static void
 gatt_client_service_changed(uint16_t start_handle,
        DBG("start 0x%04x, end: 0x%04x", start_handle, end_handle);
 }
 
+static void gatt_debug(const char *str, void *user_data)
+{
+       DBG("%s", str);
+}
+
 static void gatt_client_init(struct btd_device *device)
 {

        gatt_client_cleanup(device);

src/device.c +0 -0

@@ -4000,6 +4005,8 @@ static void gatt_client_init(struct btd_device *device)
                return;
        }
 

Quoted 7 lines

src/device.c static void gatt_client_init(struct btd_device *device) · line 4012

Quoted 6 lines

src/device.c +2 -0

+       bt_gatt_client_set_debug(device->client, gatt_debug, NULL, NULL);
+
        /* Notify attio so it can react to notifications */
        g_slist_foreach(device->attios, attio_connected, device->attrib);
 

See attachments. Fresh dumps from both btmon and daemon. With your patch "shared/gatt-client: Fix handling of services" applied.

Still not sure what is going own, it seems the 10 is BT_ATT_ERROR_ATTRIBUTE_NOT_FOUND but I suspect there is something else wrong since in this case we should just proceed to the next operation. Anyway I will send some cleanup patches and Im also planning to have proper errors so in future we can tell what is going on.

Hi Andrejs,

Quoted 101 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 90 lines · Andrejs Hanins

Hi Luiz,

Quoted 87 lines · Luiz Augusto von Dentz

Hi Andrejs,

Quoted 10 lines

Quoted 10 lines

Quoted 9 lines

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 20

    ATT: Read By Type resp (0x09)
      length: 7
        handle 0x0110, value 0x02 0x11 0x01 0x00 0x2a
        handle 0x0120, value 0x02 0x21 0x01 0x01 0x2a
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0121, end 0x0121
      type-uuid 0x2803      <--- as without patch, this seems to be suspicious. Single att read request with wrong UUID.

Quoted 3 lines

Quoted 3 lines

Maybe this is off by 1 error except if start 0x0100, end 0x0121 range actually exclude the last, but it would be still wrong the start 0x0121, end 0x0121, anyway this seems to be some other problem.

Actually this is fine, we are discovering the characteristics since they may not fit in a single frame we just continue from where we stop at 0x0121 until the end of the service range with just happen to be 0x0121.

Quoted 33 lines

Quoted 33 lines

Quoted 33 lines

Quoted 4 lines

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0121
< ACL data: handle 64 flags 0x00 dlen 9
    ATT: Find Information req (0x04)
      start 0x0112, end 0x011f

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Find Information req (0x04) on handle 0x0112
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0300, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 1

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 27

    ATT: Read By Type resp (0x09)
      length: 21
        handle 0x0310, value 0x3e 0x11 0x03 0x34 0x5b 0xe2 0x12 0x5e 0xb1 0x45 0x03 0xb6 0x29 0x24 0x55 0x8a 0x11 0x1e 0x36
< ACL data: handle 64 flags 0x00 dlen 11
    ATT: Read By Type req (0x08)
      start 0x0311, end 0x0320
      type-uuid 0x2803

Quoted 1 line

HCI Event: Number of Completed Packets (0x13) plen 5

handle 64 packets 2

Quoted 1 line

ACL data: handle 64 flags 0x02 dlen 9

Quoted 8 lines

Quoted 7 lines

Quoted 3 lines

    ATT: Error (0x01)
      Error: Attribute not found (10)
      Read By Type req (0x08) on handle 0x0311

Can you collect the trace in binary format, e.g. btmon -w <file>, I can perhaps try to create the very same database for unit tests, also it would be good to have bluetoothd traces.

Traces attached.

Can you please enable bt_gatt_client debug with the following patch:

src/device.c +5 -0

index aaa9f43..6a23adc 100644
@@ -3989,6 +3989,11 @@ static void
 gatt_client_service_changed(uint16_t start_handle,
        DBG("start 0x%04x, end: 0x%04x", start_handle, end_handle);
 }
 
+static void gatt_debug(const char *str, void *user_data)
+{
+       DBG("%s", str);
+}
+
 static void gatt_client_init(struct btd_device *device)
 {

        gatt_client_cleanup(device);

src/device.c +0 -0

@@ -4000,6 +4005,8 @@ static void gatt_client_init(struct btd_device *device)
                return;
        }
 

Quoted 7 lines

src/device.c static void gatt_client_init(struct btd_device *device) · line 4012

Quoted 6 lines

src/device.c +2 -0

+       bt_gatt_client_set_debug(device->client, gatt_debug, NULL, NULL);
+
        /* Notify attio so it can react to notifications */
        g_slist_foreach(device->attios, attio_connected, device->attrib);
 

See attachments. Fresh dumps from both btmon and daemon. With your patch "shared/gatt-client: Fix handling of services" applied.

Quoted 5 lines

Still not sure what is going own, it seems the 10 is BT_ATT_ERROR_ATTRIBUTE_NOT_FOUND but I suspect there is something else wrong since in this case we should just proceed to the next operation. Anyway I will send some cleanup patches and Im also planning to have proper errors so in future we can tell what is going on.

Can you confirm that you have the following attributes:

bluetoothd[12005]: src/device.c:gatt_debug() Primary services found: 3 bluetoothd[12005]: src/device.c:gatt_debug() start: 0x0100, end:
0x0121, uuid: 00001800-0000-1000-8000-00805f9b34fb bluetoothd[12005]: src/device.c:gatt_debug() start: 0x0200, end:
0x0200, uuid: 00001801-0000-1000-8000-00805f9b34fb bluetoothd[12005]: src/device.c:gatt_debug() start: 0x0300, end:
0x0320, uuid: 8832ab08-ba2d-0184-004c-68c08e2190bf bluetoothd[12005]: src/device.c:gatt_debug() Characteristics found: 2 bluetoothd[12005]: src/device.c:gatt_debug() start: 0x0110, end:
0x011f, value: 0x0111, props: 0x02, uuid: 00002a00-0000-1 bluetoothd[12005]: src/device.c:gatt_debug() start: 0x0120, end:
0x0121, value: 0x0121, props: 0x02, uuid: 00002a01-0000-1 bluetoothd[12005]: src/device.c:gatt_debug() Characteristics found: 1 bluetoothd[12005]: src/device.c:gatt_debug() start: 0x0310, end:
0x0320, value: 0x0311, props: 0x3e, uuid: 361e118a-5524-2

Anything missing?