Skip to contentSkip to conversation

package/mono-gtksharp: new package

PATCH New Angelo Compagnucci 2 participants 6 messages Feb 14, 2015 – Mar 5, 2015

lore
Share & tools
lore

Angelo Compagnucci

author
#0 lore raw

PATCH 1/1 package/mono-gtksharp: new package

This patch adds gtksharp package for mono.

Signed-off-by Angelo Compagnucci <[email protected]>

---

Changes: I superseeded previous patch to adhere the package naming, so gtksharp becames mono-gtksharp.

 package/Config.in                      |  5 +++++
 package/mono-gtksharp/Config.in        |  7 +++++++
 package/mono-gtksharp/mono-gtksharp.mk | 16 ++++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/mono-gtksharp/Config.in
 create mode 100644 package/mono-gtksharp/mono-gtksharp.mk
package/Config.in +5 -0
index fe3d3d0..fbba20c 100644
@@ -464,6 +464,11 @@ menu "Lua libraries/modules"
 endmenu
 endif
 	source "package/mono/Config.in"
+if BR2_PACKAGE_MONO
+menu "Mono libraries/modules"
+	source "package/mono-gtksharp/Config.in"
+endmenu
+endif
 	source "package/nodejs/Config.in"
 	source "package/perl/Config.in"
 if BR2_PACKAGE_PERL
package/mono-gtksharp/Config.in new file +7 -0
new file mode 100644
index 0000000..b3f16f0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_MONO_GTKSHARP
+	bool "gtk#"
+	depends on BR2_PACKAGE_LIBGTK3
+	help
+	  Gtk# is a .NET language binding for the GTK+ toolkit.
+
+	  http://www.mono-project.com/docs/gui/gtksharp/
package/mono-gtksharp/mono-gtksharp.mk new file +16 -0
new file mode 100644
index 0000000..58412eb
@@ -0,0 +1,16 @@
+################################################################################
+#
+# gtksharp
+#
+################################################################################
+
+MONO_GTKSHARP_VERSION_MAJOR = 2.99
+MONO_GTKSHARP_VERSION = $(MONO_GTKSHARP_VERSION_MAJOR).3
+MONO_GTKSHARP_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk-sharp/$(MONO_GTKSHARP_VERSION_MAJOR)/
+MONO_GTKSHARP_SOURCE = gtk-sharp-$(MONO_GTKSHARP_VERSION).tar.xz
+MONO_GTKSHARP_LICENSE = LGPLv2
+MONO_GTKSHARP_LICENSE_FILES = COPYING
+MONO_GTKSHARP_INSTALL_STAGING = YES
+MONO_GTKSHARP_DEPENDENCIES = mono libgtk3
+
+$(eval $(autotools-package))
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 package/mono-gtksharp: new package

Hello List,

2015-02-14 11:16 GMT+01:00 Angelo Compagnucci <[email protected]>:

Quoted 67 lines

This patch adds gtksharp package for mono.

Signed-off-by Angelo Compagnucci <[email protected]>

---

Changes: I superseeded previous patch to adhere the package naming, so gtksharp becames mono-gtksharp.

 package/Config.in                      |  5 +++++
 package/mono-gtksharp/Config.in        |  7 +++++++
 package/mono-gtksharp/mono-gtksharp.mk | 16 ++++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/mono-gtksharp/Config.in
 create mode 100644 package/mono-gtksharp/mono-gtksharp.mk
package/Config.in +5 -0
index fe3d3d0..fbba20c 100644
@@ -464,6 +464,11 @@ menu "Lua libraries/modules"
 endmenu
 endif
        source "package/mono/Config.in"
+if BR2_PACKAGE_MONO
+menu "Mono libraries/modules"
+       source "package/mono-gtksharp/Config.in"
+endmenu
+endif
        source "package/nodejs/Config.in"
        source "package/perl/Config.in"
 if BR2_PACKAGE_PERL
package/mono-gtksharp/Config.in new file +7 -0
new file mode 100644
index 0000000..b3f16f0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_MONO_GTKSHARP
+       bool "gtk#"
+       depends on BR2_PACKAGE_LIBGTK3
+       help
+         Gtk# is a .NET language binding for the GTK+ toolkit.
+
+         http://www.mono-project.com/docs/gui/gtksharp/
package/mono-gtksharp/mono-gtksharp.mk new file +16 -1
new file mode 100644
index 0000000..58412eb
@@ -0,0 +1,16 @@
+################################################################################
+#
+# gtksharp
+#
+################################################################################
+
+MONO_GTKSHARP_VERSION_MAJOR = 2.99
+MONO_GTKSHARP_VERSION = $(MONO_GTKSHARP_VERSION_MAJOR).3
+MONO_GTKSHARP_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk-sharp/$(MONO_GTKSHARP_VERSION_MAJOR)/
+MONO_GTKSHARP_SOURCE = gtk-sharp-$(MONO_GTKSHARP_VERSION).tar.xz
+MONO_GTKSHARP_LICENSE = LGPLv2
+MONO_GTKSHARP_LICENSE_FILES = COPYING
+MONO_GTKSHARP_INSTALL_STAGING = YES
+MONO_GTKSHARP_DEPENDENCIES = mono libgtk3
+
+$(eval $(autotools-package))
--
Quoted 2 lines

1.9.1

Any news on this?

Thank you!

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#2 lore raw

PATCH 1/1 package/mono-gtksharp: new package

In reply to Angelo Compagnucci
Quoted 3 lines · Angelo Compagnucci

This patch adds gtksharp package for mono.

Signed-off-by Angelo Compagnucci <[email protected]>
Tested-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

A few comments below, but nothing obligatory.

Quoted 34 lines

---

Changes: I superseeded previous patch to adhere the package naming, so gtksharp becames mono-gtksharp.

 package/Config.in                      |  5 +++++
 package/mono-gtksharp/Config.in        |  7 +++++++
 package/mono-gtksharp/mono-gtksharp.mk | 16 ++++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/mono-gtksharp/Config.in
 create mode 100644 package/mono-gtksharp/mono-gtksharp.mk
package/Config.in +5 -0
index fe3d3d0..fbba20c 100644
@@ -464,6 +464,11 @@ menu "Lua libraries/modules"
 endmenu
 endif
 	source "package/mono/Config.in"
+if BR2_PACKAGE_MONO
+menu "Mono libraries/modules"
+	source "package/mono-gtksharp/Config.in"
+endmenu
+endif
 	source "package/nodejs/Config.in"
 	source "package/perl/Config.in"
 if BR2_PACKAGE_PERL
package/mono-gtksharp/Config.in new file +0 -0
new file mode 100644
index 0000000..b3f16f0

package/mono-gtksharp/Config.in line 3

Quoted 3 lines
package/mono-gtksharp/Config.in new file +3 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_MONO_GTKSHARP
+	bool "gtk#"
+	depends on BR2_PACKAGE_LIBGTK3

I think it would be appropriate to select libgtk3 rather than depending on it.

package/mono-gtksharp/Config.in line 5

Quoted 2 lines
package/mono-gtksharp/Config.in new file +2 -0
+	help
+	  Gtk# is a .NET language binding for the GTK+ toolkit.

Perhaps mention that it's GTK3.

Quoted 8 lines
package/mono-gtksharp/Config.in new file +2 -0
+
+	  http://www.mono-project.com/docs/gui/gtksharp/
package/mono-gtksharp/mono-gtksharp.mk new file +0 -0
new file mode 100644
index 0000000..58412eb

package/mono-gtksharp/mono-gtksharp.mk line 8

Quoted 8 lines
package/mono-gtksharp/mono-gtksharp.mk new file +8 -0
@@ -0,0 +1,16 @@
+################################################################################
+#
+# gtksharp
+#
+################################################################################
+
+MONO_GTKSHARP_VERSION_MAJOR = 2.99
+MONO_GTKSHARP_VERSION = $(MONO_GTKSHARP_VERSION_MAJOR).3

We normally prefer stable releases rather than beta releases, so that would be
2.12.25. However, that release still uses gtk2 rather than gtk3, so it does make complete sense to me to go for the beta.

package/mono-gtksharp/mono-gtksharp.mk line 11

Quoted 3 lines
package/mono-gtksharp/mono-gtksharp.mk new file +3 -0
+MONO_GTKSHARP_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk-sharp/$(MONO_GTKSHARP_VERSION_MAJOR)/
+MONO_GTKSHARP_SOURCE = gtk-sharp-$(MONO_GTKSHARP_VERSION).tar.xz
+MONO_GTKSHARP_LICENSE = LGPLv2

A few files, in particular all of the cairo library, is MIT rather than LGPLv2.
The others are combined with LGPLv2 code in a single DLL so LGPLv2 is correct, but the cairo library is a separate DLL that doesn't seem to depend on any other gtksharp library, so I'd make that

MONO_GTKSHARP_LICENSE = LGPLv2, MIT (cairo)

package/mono-gtksharp/mono-gtksharp.mk line 16

Quoted 6 lines
package/mono-gtksharp/mono-gtksharp.mk new file +5 -0
+MONO_GTKSHARP_LICENSE_FILES = COPYING
+MONO_GTKSHARP_INSTALL_STAGING = YES
+MONO_GTKSHARP_DEPENDENCIES = mono libgtk3
+
+$(eval $(autotools-package))

Perhaps add a hash file?

# sha256 from
https://download.gnome.org/sources/gtk-sharp/2.99/gtk-sharp-2.99.3.sha256sum
sha256	6440f571416267ae0cb5698071d087b31e3084693fa2c829b1db37ca7ea2c3a2
gtk-sharp-2.99.3.tar.xz

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#3 lore raw

PATCH 1/1 package/mono-gtksharp: new package

Dear Arnout Vandecappelle,

2015-03-05 1:12 GMT+01:00 Arnout Vandecappelle <[email protected]>:

Quoted 50 lines · Angelo Compagnucci
Quoted 3 lines

This patch adds gtksharp package for mono.

Signed-off-by Angelo Compagnucci <[email protected]>
Tested-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

A few comments below, but nothing obligatory.

Quoted 34 lines

---

Changes: I superseeded previous patch to adhere the package naming, so gtksharp becames mono-gtksharp.

 package/Config.in                      |  5 +++++
 package/mono-gtksharp/Config.in        |  7 +++++++
 package/mono-gtksharp/mono-gtksharp.mk | 16 ++++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/mono-gtksharp/Config.in
 create mode 100644 package/mono-gtksharp/mono-gtksharp.mk
package/Config.in +5 -0
index fe3d3d0..fbba20c 100644
@@ -464,6 +464,11 @@ menu "Lua libraries/modules"
 endmenu
 endif
      source "package/mono/Config.in"
+if BR2_PACKAGE_MONO
+menu "Mono libraries/modules"
+     source "package/mono-gtksharp/Config.in"
+endmenu
+endif
      source "package/nodejs/Config.in"
      source "package/perl/Config.in"
 if BR2_PACKAGE_PERL
package/mono-gtksharp/Config.in new file +0 -0
new file mode 100644
index 0000000..b3f16f0

package/mono-gtksharp/Config.in line 3

Quoted 3 lines
package/mono-gtksharp/Config.in new file +3 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_MONO_GTKSHARP
+     bool "gtk#"
+     depends on BR2_PACKAGE_LIBGTK3

I think it would be appropriate to select libgtk3 rather than depending on it.

Quoted 4 lines

package/mono-gtksharp/Config.in line 5

Quoted 2 lines
package/mono-gtksharp/Config.in new file +2 -0
+     help
+       Gtk# is a .NET language binding for the GTK+ toolkit.

Perhaps mention that it's GTK3.

Yes, you are right, probably it's best to name it gtk3.

Quoted 13 lines
Quoted 13 lines
package/mono-gtksharp/Config.in new file +2 -0
+
+       http://www.mono-project.com/docs/gui/gtksharp/
package/mono-gtksharp/mono-gtksharp.mk new file +4 -0
new file mode 100644
index 0000000..58412eb
@@ -0,0 +1,16 @@
+################################################################################
+#
+# gtksharp
+#
Quoted 8 lines

package/mono-gtksharp/mono-gtksharp.mk line 8

Quoted 4 lines
package/mono-gtksharp/mono-gtksharp.mk new file +4 -0
+################################################################################
+
+MONO_GTKSHARP_VERSION_MAJOR = 2.99
+MONO_GTKSHARP_VERSION = $(MONO_GTKSHARP_VERSION_MAJOR).3

We normally prefer stable releases rather than beta releases, so that would be
2.12.25. However, that release still uses gtk2 rather than gtk3, so it does make complete sense to me to go for the beta.

There are not stable releases of gtk#3, everyone uses the beta one, it's the de facto version.

Quoted 10 lines

package/mono-gtksharp/mono-gtksharp.mk line 11

Quoted 3 lines
package/mono-gtksharp/mono-gtksharp.mk new file +3 -0
+MONO_GTKSHARP_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk-sharp/$(MONO_GTKSHARP_VERSION_MAJOR)/
+MONO_GTKSHARP_SOURCE = gtk-sharp-$(MONO_GTKSHARP_VERSION).tar.xz
+MONO_GTKSHARP_LICENSE = LGPLv2

A few files, in particular all of the cairo library, is MIT rather than LGPLv2.
The others are combined with LGPLv2 code in a single DLL so LGPLv2 is correct, but the cairo library is a separate DLL that doesn't seem to depend on any other gtksharp library, so I'd make that

MONO_GTKSHARP_LICENSE = LGPLv2, MIT (cairo)

I don't think there are cairo files distributed with mono, the cairo folder contains a c# wrapper to cairo, but it's original code. Can you point me to the offending files?

Quoted 9 lines

package/mono-gtksharp/mono-gtksharp.mk line 16

Quoted 6 lines
package/mono-gtksharp/mono-gtksharp.mk new file +5 -0
+MONO_GTKSHARP_LICENSE_FILES = COPYING
+MONO_GTKSHARP_INSTALL_STAGING = YES
+MONO_GTKSHARP_DEPENDENCIES = mono libgtk3
+
+$(eval $(autotools-package))

Perhaps add a hash file?

Quoted 4 lines
# sha256 from
https://download.gnome.org/sources/gtk-sharp/2.99/gtk-sharp-2.99.3.sha256sum
sha256  6440f571416267ae0cb5698071d087b31e3084693fa2c829b1db37ca7ea2c3a2
gtk-sharp-2.99.3.tar.xz

Sure!

Quoted 13 lines

Regards,
Arnout

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#4 lore raw

PATCH 1/1 package/mono-gtksharp: new package

Quoted 4 lines · Angelo Compagnucci

Dear Arnout Vandecappelle,

2015-03-05 1:12 GMT+01:00 Arnout Vandecappelle <[email protected]>:

Quoted 1 line · Angelo Compagnucci

[snip]

Quoted 9 lines
Quoted 9 lines

package/mono-gtksharp/mono-gtksharp.mk line 11

Quoted 3 lines
package/mono-gtksharp/mono-gtksharp.mk new file +3 -0
+MONO_GTKSHARP_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk-sharp/$(MONO_GTKSHARP_VERSION_MAJOR)/
+MONO_GTKSHARP_SOURCE = gtk-sharp-$(MONO_GTKSHARP_VERSION).tar.xz
+MONO_GTKSHARP_LICENSE = LGPLv2

A few files, in particular all of the cairo library, is MIT rather than LGPLv2.
The others are combined with LGPLv2 code in a single DLL so LGPLv2 is correct, but the cairo library is a separate DLL that doesn't seem to depend on any other gtksharp library, so I'd make that

Quoted 5 lines
Quoted 1 line

MONO_GTKSHARP_LICENSE = LGPLv2, MIT (cairo)

I don't think there are cairo files distributed with mono, the cairo folder contains a c# wrapper to cairo, but it's original code. Can you point me to the offending files?

I am indeed referring to the C# wrapper of cairo. Gtk# builds a .so and .dll
for cairo, which AFAICS can be used independently from the rest of Gtk#, and which AFAICS is only derived from sources that carry a MIT license (i.e., everything in the cairo/ directory).

(cairo itself is still LGPLv2+, of course. However, since this is a different
shared library, the cairo# .dll and .so could be used with a differently-licensed implementation of the cairo ABI).

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#5 lore raw

PATCH 1/1 package/mono-gtksharp: new package

Dear Arnout Vandecappelle,

2015-03-05 13:12 GMT+01:00 Arnout Vandecappelle <[email protected]>:

Quoted 21 lines · Angelo Compagnucci
Quoted 4 lines

Dear Arnout Vandecappelle,

2015-03-05 1:12 GMT+01:00 Arnout Vandecappelle <[email protected]>:

Quoted 1 line · Angelo Compagnucci

[snip]

Quoted 9 lines
Quoted 9 lines

package/mono-gtksharp/mono-gtksharp.mk line 11

Quoted 3 lines
package/mono-gtksharp/mono-gtksharp.mk new file +3 -0
+MONO_GTKSHARP_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk-sharp/$(MONO_GTKSHARP_VERSION_MAJOR)/
+MONO_GTKSHARP_SOURCE = gtk-sharp-$(MONO_GTKSHARP_VERSION).tar.xz
+MONO_GTKSHARP_LICENSE = LGPLv2

A few files, in particular all of the cairo library, is MIT rather than LGPLv2.
The others are combined with LGPLv2 code in a single DLL so LGPLv2 is correct, but the cairo library is a separate DLL that doesn't seem to depend on any other gtksharp library, so I'd make that

Quoted 5 lines
Quoted 1 line

MONO_GTKSHARP_LICENSE = LGPLv2, MIT (cairo)

I don't think there are cairo files distributed with mono, the cairo folder contains a c# wrapper to cairo, but it's original code. Can you point me to the offending files?

Quoted 8 lines

I am indeed referring to the C# wrapper of cairo. Gtk# builds a .so and .dll
for cairo, which AFAICS can be used independently from the rest of Gtk#, and which AFAICS is only derived from sources that carry a MIT license (i.e., everything in the cairo/ directory).

(cairo itself is still LGPLv2+, of course. However, since this is a different
shared library, the cairo# .dll and .so could be used with a differently-licensed implementation of the cairo ABI).

Ops, you are totally right! I haven't noticed that the cairo wrapper was under another license!

For the other question about select/depends, Thomas in a previous thread said me to use depends instead of select!

Sincerely, Angelo

Quoted 11 lines

Regards,
Arnout

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo