drm/exynos: IS_ERR() vs NULL bug
Subsystems (3)
PATCH 1/1 drm/exynos: IS_ERR() vs NULL bug
of_iomap() doesn't return error pointers, it returns NULL on error.
drivers/gpu/drm/exynos/exynos7_drm_decon.c +2 -2
@@ -888,8 +888,8 @@ static int decon_probe(struct platform_device *pdev)of_node_put (i80_if_timings); ctx->regs =of_iomap (dev->of_node,0 ); -if (IS_ERR (ctx->regs)) { - ret =PTR_ERR (ctx->regs); +if (!ctx->regs) { + ret = -ENOMEM ; goto err_del_component; }
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Dan,
2015-02-20 Dan Carpenter <[email protected]>:
Quoted 9 lines
of_iomap()doesn't return error pointers, it returns NULL on error.Signed-off-by Dan Carpenter <[email protected]>drivers/gpu/drm/exynos/exynos7_drm_decon.c +0
-0
drivers/gpu/drm/exynos/exynos7_drm_decon.c static int decon_probe(struct platform_device *pdev) · line 894
Quoted 9 lines
drivers/gpu/drm/exynos/exynos7_drm_decon.c +2
-2@@ -888,8 +888,8 @@ static int decon_probe(struct platform_device *pdev)of_node_put (i80_if_timings); ctx->regs =of_iomap (dev->of_node,0 ); -if (IS_ERR (ctx->regs)) { - ret =PTR_ERR (ctx->regs); +if (!ctx->regs) { + ret = -ENOMEM ; goto err_del_component; }
Gustavo
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 1 line · Dan Carpenter
of_iomap()doesn't return error pointers, it returns NULL on error.
Applied.
Thanks,
Inki Dae
Quoted 9 lines
Signed-off-by Dan Carpenter <[email protected]>drivers/gpu/drm/exynos/exynos7_drm_decon.c +0
-0
drivers/gpu/drm/exynos/exynos7_drm_decon.c static int decon_probe(struct platform_device *pdev) · line 895
Quoted 10 lines
drivers/gpu/drm/exynos/exynos7_drm_decon.c +2
-2@@ -888,8 +888,8 @@ static int decon_probe(struct platform_device *pdev)of_node_put (i80_if_timings); ctx->regs =of_iomap (dev->of_node,0 ); -if (IS_ERR (ctx->regs)) { - ret =PTR_ERR (ctx->regs); +if (!ctx->regs) { + ret = -ENOMEM ; goto err_del_component; }
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel