Skip to contentSkip to conversation

tg3: Hold tp->lock before calling tg3_halt() from tg3_init_one()

PATCH In review Joseph Salisbury 1 participant 2 messages Mar 5, 2015 – Mar 6, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tg3: Hold tp->lock before calling tg3_halt() from tg3_init_one()

Hello,

Please consider including mainline commit d0af71a3573f1217b140c60b66f1a9b335fb058b in the next v3.18.y and v3.19.y stable releases. It was included in the mainline tree as of v4.0-rc1. It has been tested and confirmed to resolve:
http://bugs.launchpad.net/bugs/1428111 .

This commit fixes a regression introduced going from 3.16 to 3.19, so it may not be needed in earlier than 3.18 stable releases.

commit d0af71a3573f1217b140c60b66f1a9b335fb058b

Author: Jun'ichi Nomura \(NEC\) <[email protected]>
Date:   Thu Feb 12 01:26:24 2015 +0000
    tg3: Hold tp->lock before calling tg3_halt() from tg3_init_one()

Sincerely,
Joseph Salisbury

#1 lore raw
Quoted 12 lines · Joseph Salisbury

Hello,

Please consider including mainline commit d0af71a3573f1217b140c60b66f1a9b335fb058b in the next v3.18.y and v3.19.y stable releases. It was included in the mainline tree as of v4.0-rc1. It has been tested and confirmed to resolve:
http://bugs.launchpad.net/bugs/1428111 .

This commit fixes a regression introduced going from 3.16 to 3.19, so it may not be needed in earlier than 3.18 stable releases.

commit d0af71a3573f1217b140c60b66f1a9b335fb058b

Quoted 10 lines
Author: Jun'ichi Nomura \(NEC\) <[email protected]>
Date:   Thu Feb 12 01:26:24 2015 +0000
    tg3: Hold tp->lock before calling tg3_halt() from tg3_init_one()

Sincerely,
Joseph Salisbury

After some further testing, it looks like only 3.19 is affected by the bug. The upstream 3.18.y stable kernel does not require the commit.

Thanks,

Joe