boot/at91bootstrap3: Add the option to download via git

PATCH New Angelo Compagnucci 3 participants 7 messages Jan 30, 2015 – Mar 7, 2015 Arm/Microchip (AT91) SoC support

lore

Share & tools

lore

Angelo Compagnucci

author

2015-01-30 16:52 UTC #0 lore raw

PATCH 1/1 boot/at91bootstrap3: Add the option to download via git

Adding support for git downloading of a custom repository.

Signed-off-by Angelo Compagnucci <[email protected]>

---
 boot/at91bootstrap3/Config.in         | 35 +++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk |  8 +++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)

boot/at91bootstrap3/Config.in +35 -0

index 8ac40ed..6f2f7db 100644
@@ -8,8 +8,43 @@ config BR2_TARGET_AT91BOOTSTRAP3
 	  - Peripheral drivers such as PIO, PMC or SDRAMC...
 	  - Physical media algorithm such as DataFlash, NandFlash, NOR Flash...
 
+
 if BR2_TARGET_AT91BOOTSTRAP3
 
+choice
+
+	prompt "AT91 Bootstrap 3 version"
+
+config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	bool "3.7.1"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+	bool "Custom Git repository"
+	help
+	  This option allows Buildroot to get the AT91 Bootstrap 3 source
+	  code from a Git repository.
+
+endchoice
+
+if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
+	string "URL of custom repository"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
+	string "Custom repository version"
+	help
+	  Revision to use in the typical format used by Git
+	  E.G. a sha id, a tag, branch, ..
+
+endif
+
+config BR2_TARGET_AT91BOOTSTRAP3_VERSION
+	string
+	default "v3.7.1" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
+		if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
 config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
 	string "custom patch dir"
 	help

boot/at91bootstrap3/at91bootstrap3.mk +7 -1

index 098e7bf..39f2365 100644
@@ -4,8 +4,14 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.1
+AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
+AT91BOOTSTRAP3_SITE_METHOD = git
+else
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+endif
 
 AT91BOOTSTRAP3_INSTALL_IMAGES = YES
 AT91BOOTSTRAP3_INSTALL_TARGET = NO

Signature · 1 line

1.9.1

Angelo Compagnucci

author

2015-02-16 09:12 UTC #1 lore raw

PATCH 1/1 boot/at91bootstrap3: Add the option to download via git

Hello All,

Any news on this one?

Staiyng to this comment on at91bootstrap git tree [1] there is no infrastructure in place to add third parties boards.

Personally, I need this option cause I'm in the process to prepare a comprehensive board support for Acmesystems' products and ask for inclusion in the near future.

Thanks!

Sincerely, Angelo

[1] https://github.com/linux4sam/at91bootstrap/pull/2#issuecomment-27954225

2015-01-30 17:52 GMT+01:00 Angelo Compagnucci <[email protected]>:

Quoted 79 lines

Adding support for git downloading of a custom repository.

Signed-off-by Angelo Compagnucci <[email protected]>

---
 boot/at91bootstrap3/Config.in         | 35 +++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk |  8 +++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)

boot/at91bootstrap3/Config.in +35 -0

index 8ac40ed..6f2f7db 100644
@@ -8,8 +8,43 @@ config BR2_TARGET_AT91BOOTSTRAP3
          - Peripheral drivers such as PIO, PMC or SDRAMC...
          - Physical media algorithm such as DataFlash, NandFlash, NOR Flash...
 
+
 if BR2_TARGET_AT91BOOTSTRAP3
 
+choice
+
+       prompt "AT91 Bootstrap 3 version"
+
+config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+       bool "3.7.1"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+       bool "Custom Git repository"
+       help
+         This option allows Buildroot to get the AT91 Bootstrap 3 source
+         code from a Git repository.
+
+endchoice
+
+if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
+       string "URL of custom repository"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
+       string "Custom repository version"
+       help
+         Revision to use in the typical format used by Git
+         E.G. a sha id, a tag, branch, ..
+
+endif
+
+config BR2_TARGET_AT91BOOTSTRAP3_VERSION
+       string
+       default "v3.7.1" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+       default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
+               if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
 config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
        string "custom patch dir"
        help

boot/at91bootstrap3/at91bootstrap3.mk +7 -2

index 098e7bf..39f2365 100644
@@ -4,8 +4,14 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.1
+AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
+AT91BOOTSTRAP3_SITE_METHOD = git
+else
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+endif
 
 AT91BOOTSTRAP3_INSTALL_IMAGES = YES
 AT91BOOTSTRAP3_INSTALL_TARGET = NO
--

1.9.1

Signature · 1 line

Profile: http://it.linkedin.com/in/compagnucciangelo

Angelo Compagnucci

author

2015-03-04 14:55 UTC #2 lore raw

PATCH 1/1 boot/at91bootstrap3: Add the option to download via git

Hello List,

2015-02-16 10:12 GMT+01:00 Angelo Compagnucci <[email protected]>:

Quoted 92 lines

Hello All,

Any news on this one?

Staiyng to this comment on at91bootstrap git tree [1] there is no infrastructure in place to add third parties boards.

Personally, I need this option cause I'm in the process to prepare a comprehensive board support for Acmesystems' products and ask for inclusion in the near future.

Thanks!

Sincerely, Angelo

[1] https://github.com/linux4sam/at91bootstrap/pull/2#issuecomment-27954225

2015-01-30 17:52 GMT+01:00 Angelo Compagnucci <[email protected]>:

Quoted 74 lines

Adding support for git downloading of a custom repository.

Signed-off-by Angelo Compagnucci <[email protected]>

---
 boot/at91bootstrap3/Config.in         | 35 +++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk |  8 +++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)

boot/at91bootstrap3/Config.in +35 -0

index 8ac40ed..6f2f7db 100644
@@ -8,8 +8,43 @@ config BR2_TARGET_AT91BOOTSTRAP3
          - Peripheral drivers such as PIO, PMC or SDRAMC...
          - Physical media algorithm such as DataFlash, NandFlash, NOR Flash...
 
+
 if BR2_TARGET_AT91BOOTSTRAP3
 
+choice
+
+       prompt "AT91 Bootstrap 3 version"
+
+config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+       bool "3.7.1"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+       bool "Custom Git repository"
+       help
+         This option allows Buildroot to get the AT91 Bootstrap 3 source
+         code from a Git repository.
+
+endchoice
+
+if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
+       string "URL of custom repository"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
+       string "Custom repository version"
+       help
+         Revision to use in the typical format used by Git
+         E.G. a sha id, a tag, branch, ..
+
+endif
+
+config BR2_TARGET_AT91BOOTSTRAP3_VERSION
+       string
+       default "v3.7.1" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+       default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
+               if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
 config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
        string "custom patch dir"
        help

boot/at91bootstrap3/at91bootstrap3.mk +7 -1

index 098e7bf..39f2365 100644
@@ -4,8 +4,14 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.1
+AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
+AT91BOOTSTRAP3_SITE_METHOD = git
+else
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+endif

Quoted 10 lines

Quoted 5 lines
boot/at91bootstrap3/at91bootstrap3.mk +0 -1
 AT91BOOTSTRAP3_INSTALL_IMAGES = YES
 AT91BOOTSTRAP3_INSTALL_TARGET = NO
--
1.9.1
--
Profile: http://it.linkedin.com/in/compagnucciangelo

Any news on this?

Thank you!

Signature · 1 line

Profile: http://it.linkedin.com/in/compagnucciangelo

Yann E. MORIN

2015-03-06 22:53 UTC #3 lore raw

PATCH 1/1 boot/at91bootstrap3: Add the option to download via git

Angelo, All,

On 2015-03-04 15:55 +0100, Angelo Compagnucci spake thusly:

Quoted 1 line

Quoted 1 line
Quoted 1 line
Adding support for git downloading of a custom repository.

[--SNIP--]

Quoted 1 line

Any news on this?

Sorry it takes so long, but we are just getting out of a release cycle (i.e. the last month was a feature-freeze), and we're trying to catch up with the currently 363-or-so patches pending in our patch-tracker:
http://patchwork.ozlabs.org/project/buildroot/list/

One reason that it takes so much time is that there are very reviewers/testers that give feedback on patches (I have been myself not very active in that activity recently), and Peter and Thomas have to do the grunt work of the triaging, reviewing, testing and applying almost all on their own...

A little bit of help in reviewing those patches, testing them, triaging the duplicates and so on... is very welcome.

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Angelo Compagnucci

author

2015-03-07 09:08 UTC #4 lore raw

PATCH 1/1 boot/at91bootstrap3: Add the option to download via git

Dear Yann E. MORIN,

2015-03-06 23:53 GMT+01:00 Yann E. MORIN <[email protected]>:

Quoted 12 lines

Angelo, All,
On 2015-03-04 15:55 +0100, Angelo Compagnucci spake thusly:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Adding support for git downloading of a custom repository.
[--SNIP--]
Quoted 1 line
Any news on this?
Sorry it takes so long, but we are just getting out of a release cycle (i.e. the last month was a feature-freeze), and we're trying to catch up with the currently 363-or-so patches pending in our patch-tracker:
http://patchwork.ozlabs.org/project/buildroot/list/

Quoted 8 lines

One reason that it takes so much time is that there are very reviewers/testers that give feedback on patches (I have been myself not very active in that activity recently), and Peter and Thomas have to do the grunt work of the triaging, reviewing, testing and applying almost all on their own...
A little bit of help in reviewing those patches, testing them, triaging the duplicates and so on... is very welcome.

I usually contribute to several Open Source software and I usually tend to lend a hand because it's fun!
Unfortunately I'm still grasping the internal of Buildroot and I've not the necessary knowledge to help reviewing patches. I'm monitorin the mailing list everyday and in case I find something to work on, you can count on me!

I'm open to some sort of mentorship if someone wants to help me became proficient and helpful!

Sincerely, Angelo.

Quoted 11 lines

Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Signature · 1 line

Profile: http://it.linkedin.com/in/compagnucciangelo

Yann E. MORIN

2015-03-07 11:21 UTC #5 lore raw

PATCH 1/1 boot/at91bootstrap3: Add the option to download via git

Angelo, All,

On 2015-03-07 10:08 +0100, Angelo Compagnucci spake thusly:

Quoted 22 lines

2015-03-06 23:53 GMT+01:00 Yann E. MORIN <[email protected]>:
Quoted 12 lines
Angelo, All,
On 2015-03-04 15:55 +0100, Angelo Compagnucci spake thusly:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Adding support for git downloading of a custom repository.
[--SNIP--]
Quoted 1 line
Any news on this?
Sorry it takes so long, but we are just getting out of a release cycle (i.e. the last month was a feature-freeze), and we're trying to catch up with the currently 363-or-so patches pending in our patch-tracker:
http://patchwork.ozlabs.org/project/buildroot/list/
Quoted 8 lines
One reason that it takes so much time is that there are very reviewers/testers that give feedback on patches (I have been myself not very active in that activity recently), and Peter and Thomas have to do the grunt work of the triaging, reviewing, testing and applying almost all on their own...
A little bit of help in reviewing those patches, testing them, triaging the duplicates and so on... is very welcome.

Quoted 6 lines

I usually contribute to several Open Source software and I usually tend to lend a hand because it's fun!
Unfortunately I'm still grasping the internal of Buildroot and I've not the necessary knowledge to help reviewing patches. I'm monitorin the mailing list everyday and in case I find something to work on, you can count on me!

That's great, and it is appreciated! :-)

Quoted 2 lines

I'm open to some sort of mentorship if someone wants to help me became proficient and helpful!

Yes, sure. First, don't be afraid! Even a review that just looks at typoes is much welcome. Start with simple changes, such as a version bump and build-test it, in various configurations (mips, arm, ppc... with uclibc or glibc, with or without threads...); for example, I try to build for arm and i386with the "default" toolchain options then with a "fat" toolchain (LFS, threads...)

If you find typoes, just reply to the patch, pointing the typoes.

If you find the change to be OK, you can reply to the patch with a mail stating:

Reviewed-by Firstname NAME <[email protected]>

If you tested it, you can say something like (no need to be too verbose):

[Firstname: build-tested for mips; run-tested on armel]

Tested-by Firstname NAME <[email protected]>

Also, you can have a look at our manual, where we have a full section about how to contribute:
http://buildroot.net/downloads/manual/manual.html#_contributing_to_buildroot

And again, each contribution counts! So thanks for yours! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Arnout Vandecappelle

2015-03-07 16:01 UTC #6 lore raw

PATCH 1/1 boot/at91bootstrap3: Add the option to download via git

Quoted 1 line · Yann E. MORIN

Reviewed-by Firstname NAME <[email protected]>

Small correction: if you're not French, you are not required to shout your last
name :-)

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F