tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO

PATCH New Simon Glass 3 participants 10 messages Mar 10, 2015 – Mar 30, 2015

lore

Share & tools

lore

Simon Glass

author

2015-03-10 01:12 UTC #0 lore raw

PATCH 1/2 tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO

This CONFIG is not used, so drop it.

Signed-off-by Simon Glass <[email protected]>

---

 include/configs/seaboard.h | 3 ---
 1 file changed, 3 deletions(-)

include/configs/seaboard.h +0 -3

index 5f77051..44daadc 100644
@@ -27,9 +27,6 @@
 #define CONFIG_TEGRA_ENABLE_UARTD
 #define CONFIG_SYS_NS16550_COM1		NV_PA_APB_UARTD_BASE
 
-/* On Seaboard: GPIO_PI3 = Port I = 8, bit = 3 */
-#define CONFIG_UART_DISABLE_GPIO	GPIO_PI3
-
 #define CONFIG_MACH_TYPE		MACH_TYPE_SEABOARD
 
 #define CONFIG_BOARD_EARLY_INIT_F

Signature · 1 line

2.2.0.rc0.207.ga3a616c

Simon Glass

author

2015-03-10 01:12 UTC #1 lore raw

PATCH 2/2 tegra: seaboard: Correct the gpio_request() call

Requesting a GPIO without a name is not supposed anymore. This causes the request to fail. Add a name so that the serial console works on seaboard.

Signed-off-by Simon Glass <[email protected]>

---

 board/nvidia/seaboard/seaboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

board/nvidia/seaboard/seaboard.c +1 -1

index 25480e4..2d07001 100644
@@ -20,7 +20,7 @@
 void gpio_early_init_uart(void)
 {
 	/* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */
-	gpio_request(GPIO_PI3, NULL);
+	gpio_request(GPIO_PI3, "uart_en");
 	gpio_direction_output(GPIO_PI3, 0);
 }
 #endif

Signature · 1 line

2.2.0.rc0.207.ga3a616c

Simon Glass

author

2015-03-10 01:16 UTC #2 lore raw

PATCH 2/2 tegra: seaboard: Correct the gpio_request() call

Let's try this:

Reported-by Stephen Warren <[email protected]>

Quoted 25 lines · Simon Glass

Requesting a GPIO without a name is not supposed anymore. This causes the request to fail. Add a name so that the serial console works on seaboard.
Signed-off-by Simon Glass <[email protected]>
---
 board/nvidia/seaboard/seaboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/nvidia/seaboard/seaboard.c +1 -2
index 25480e4..2d07001 100644
@@ -20,7 +20,7 @@
 void gpio_early_init_uart(void)
 {
        /* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */
-       gpio_request(GPIO_PI3, NULL);
+       gpio_request(GPIO_PI3, "uart_en");
        gpio_direction_output(GPIO_PI3, 0);
 }
 #endif
--
2.2.0.rc0.207.ga3a616c

Simon Glass

author

2015-03-29 13:10 UTC #3 lore raw

PATCH 2/2 tegra: seaboard: Correct the gpio_request() call

Hi Tom,

Quoted 10 lines · Simon Glass

Let's try this:
Reported-by Stephen Warren <[email protected]>
Quoted 4 lines · Simon Glass
Requesting a GPIO without a name is not supposed anymore. This causes the request to fail. Add a name so that the serial console works on seaboard.
Signed-off-by Simon Glass <[email protected]>

Can you please apply this fix?

Quoted 5 lines

---

 board/nvidia/seaboard/seaboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 16 lines

Quoted 14 lines

board/nvidia/seaboard/seaboard.c +1 -2

index 25480e4..2d07001 100644
@@ -20,7 +20,7 @@
 void gpio_early_init_uart(void)
 {
        /* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */
-       gpio_request(GPIO_PI3, NULL);
+       gpio_request(GPIO_PI3, "uart_en");
        gpio_direction_output(GPIO_PI3, 0);
 }
 #endif
--

Quoted 2 lines

2.2.0.rc0.207.ga3a616c

Regards,
Simon

Stephen Warren

2015-03-10 02:49 UTC #4 lore raw

PATCH 1/2 tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO

In reply to Simon Glass

Quoted 1 line · Simon Glass

This CONFIG is not used, so drop it.

The series,

Tested-by Stephen Warren <[email protected]>

Acked-by Stephen Warren <[email protected]>

Simon Glass

author

2015-03-29 13:10 UTC #5 lore raw

PATCH 1/2 tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO

Hi Tom,

Quoted 6 lines · Stephen Warren

Quoted 1 line · Simon Glass
This CONFIG is not used, so drop it.
The series,
Tested-by Stephen Warren <[email protected]>
Acked-by Stephen Warren <[email protected]>

Can you please apply this fix?

Regards,
Simon

Tom Warren

2015-03-30 17:02 UTC #6 lore raw

PATCH 1/2 tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO

Simon,

This series applied to u-boot-tegra/next locally. I've got to look at some patches from Marcel to see if they've been ACK'd. Once I've collected any other pending patches, I'll push a new /next to Denx.

Tom

Quoted 15 lines

-----Original Message-----
From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
Sent: Sunday, March 29, 2015 6:10 AM
To: Stephen Warren
Cc: U-Boot Mailing List; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO
Hi Tom,
Quoted 3 lines · Stephen Warren
Quoted 1 line · Simon Glass
This CONFIG is not used, so drop it.

Quoted 8 lines

Quoted 3 lines
The series,
Tested-by Stephen Warren <[email protected]>
Acked-by Stephen Warren <[email protected]>
Can you please apply this fix?
Regards,
Simon

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Simon Glass

author

2015-03-30 17:14 UTC #7 lore raw

PATCH 1/2 tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO

Hi Tom,

Quoted 4 lines · Tom Warren

Simon,
This series applied to u-boot-tegra/next locally. I've got to look at some patches from Marcel to see if they've been ACK'd. Once I've collected any other pending patches, I'll push a new /next to Denx.

Thanks - also what do you think about applying the Nyan display patches? They work fine on my board, but apparently they are not perfect. Still it might be better than letting them sit. I can rebase and resend.

Regards,
Simon

Quoted 33 lines

Tom
Quoted 15 lines
-----Original Message-----
From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
Sent: Sunday, March 29, 2015 6:10 AM
To: Stephen Warren
Cc: U-Boot Mailing List; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO
Hi Tom,
Quoted 3 lines · Stephen Warren
Quoted 1 line · Simon Glass
This CONFIG is not used, so drop it.
Quoted 8 lines
Quoted 3 lines
The series,
Tested-by Stephen Warren <[email protected]>
Acked-by Stephen Warren <[email protected]>
Can you please apply this fix?
Regards,
Simon
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Tom Warren

2015-03-30 18:05 UTC #8 lore raw

PATCH 1/2 tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO

If you want to rework them against current u-boot-tegra/master and resend, I'll apply them, and maybe get a chance later this week to test them on my Nyan. Thanks.

Quoted 61 lines

-----Original Message-----
From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
Sent: Monday, March 30, 2015 10:15 AM
To: Tom Warren
Cc: Stephen Warren; U-Boot Mailing List; Stephen Warren
Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO
Hi Tom,
Quoted 4 lines · Tom Warren
Simon,
This series applied to u-boot-tegra/next locally. I've got to look at some
patches from Marcel to see if they've been ACK'd. Once I've collected any other pending patches, I'll push a new /next to Denx.
Thanks - also what do you think about applying the Nyan display patches? They work fine on my board, but apparently they are not perfect. Still it might be better than letting them sit. I can rebase and resend.
Regards,
Simon
Quoted 36 lines
Tom
Quoted 16 lines
-----Original Message-----
From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
Sent: Sunday, March 29, 2015 6:10 AM
To: Stephen Warren
Cc: U-Boot Mailing List; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO
Hi Tom,
Quoted 3 lines · Stephen Warren
Quoted 1 line · Simon Glass
This CONFIG is not used, so drop it.
Quoted 8 lines
Quoted 3 lines
The series,
Tested-by Stephen Warren <[email protected]>
Acked-by Stephen Warren <[email protected]>
Can you please apply this fix?
Regards,
Simon
----------------------------------------------------------------------
------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
----------------------------------------------------------------------
-------------

Simon Glass

author

2015-03-30 23:48 UTC #9 lore raw

PATCH 1/2 tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO

Hi Tom,

Quoted 2 lines · Tom Warren

If you want to rework them against current u-boot-tegra/master and resend, I'll apply them, and maybe get a chance later this week to test them on my Nyan. Thanks.

Thanks - I'm rebasing this now and waiting for buildman.

Regards,
Simon

Quoted 63 lines

Quoted 63 lines
-----Original Message-----
From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
Sent: Monday, March 30, 2015 10:15 AM
To: Tom Warren
Cc: Stephen Warren; U-Boot Mailing List; Stephen Warren
Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO
Hi Tom,
Quoted 4 lines · Tom Warren
Simon,
This series applied to u-boot-tegra/next locally. I've got to look at some
patches from Marcel to see if they've been ACK'd. Once I've collected any other pending patches, I'll push a new /next to Denx.
Thanks - also what do you think about applying the Nyan display patches? They work fine on my board, but apparently they are not perfect. Still it might be better than letting them sit. I can rebase and resend.
Regards,
Simon
Quoted 36 lines
Tom
Quoted 16 lines
-----Original Message-----
From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
Sent: Sunday, March 29, 2015 6:10 AM
To: Stephen Warren
Cc: U-Boot Mailing List; Tom Warren; Stephen Warren
Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO
Hi Tom,
Quoted 3 lines · Stephen Warren
Quoted 1 line · Simon Glass
This CONFIG is not used, so drop it.
Quoted 8 lines
Quoted 3 lines
The series,
Tested-by Stephen Warren <[email protected]>
Acked-by Stephen Warren <[email protected]>
Can you please apply this fix?
Regards,
Simon
----------------------------------------------------------------------
------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
----------------------------------------------------------------------
-------------