Skip to contentSkip to conversation

phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy

PATCH Applied Wan Jiabing 3 participants 3 messages Jan 7, 2022 – Jan 27, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy

Fix following coccicheck warning:
./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument to && or ||

The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.

---
 drivers/phy/mediatek/phy-mtk-tphy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/mediatek/phy-mtk-tphy.c +1 -1
index 6d307102f4f6..8ee7682b8e93 100644
@@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy, struct mtk_phy_instance *instanc
 		/* no efuse, ignore it */
 		if (!instance->efuse_intr &&
 		    !instance->efuse_rx_imp &&
-		    !instance->efuse_rx_imp) {
+		    !instance->efuse_tx_imp) {
 			dev_warn(dev, "no u3 intr efuse, but dts enable it\n");
 			instance->efuse_sw_en = 0;
 			break;
Signature · 1 line
2.34.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 25 lines · Wan Jiabing

Fix following coccicheck warning:
./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument to && or ||

The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.

---
 drivers/phy/mediatek/phy-mtk-tphy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/mediatek/phy-mtk-tphy.c +0 -0
index 6d307102f4f6..8ee7682b8e93 100644
@@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy,

struct mtk_phy_instance *instanc

drivers/phy/mediatek/phy-mtk-tphy.c +1 -1
 		/* no efuse, ignore it */
 		if (!instance->efuse_intr &&
 		    !instance->efuse_rx_imp &&
-		    !instance->efuse_rx_imp) {
+		    !instance->efuse_tx_imp) {
 			dev_warn(dev, "no u3 intr efuse, but dts enable

it\n");

drivers/phy/mediatek/phy-mtk-tphy.c static int phy_efuse_get(struct mtk_tphy *tphy, struct mtk_phy_instance *instanc · line 998

Quoted 2 lines
drivers/phy/mediatek/phy-mtk-tphy.c +0 -0
 			instance->efuse_sw_en = 0;
 			break;

Thanks a lot

maintainer Applied
#2 lore raw
In reply to Wan Jiabing
Quoted 5 lines · Wan Jiabing

Fix following coccicheck warning:
./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument to && or ||

The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.

Applied, thanks

Signature · 1 line
~Vinod