arm64: dts: nuvoton: drop unused syscon property from watchdog node
Subsystems (2)
Tomer Maimon
maintainerPATCH 1/1 arm64: dts: nuvoton: drop unused syscon property from watchdog node
The NPCM8XX DTSI currently includes a 'syscon' phandle in the watchdog node, but this property is not used by any upstream driver and is not documented in the NPCM watchdog binding. Since it was never reviewed and does not form part of the DT ABI, it can be safely removed.
--- arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 3 --- 1 file changed, 3 deletions(-)
arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi +0 -3
@@ -145,7 +145,6 @@ watchdog0: watchdog@801c { reg = <0x801c 0x4>; status = "disabled"; clocks = <&refclk>; - syscon = <&gcr>; }; watchdog1: watchdog@901c {
@@ -154,7 +153,6 @@ watchdog1: watchdog@901c { reg = <0x901c 0x4>; status = "disabled"; clocks = <&refclk>; - syscon = <&gcr>; }; watchdog2: watchdog@a01c {
@@ -163,7 +161,6 @@ watchdog2: watchdog@a01c { reg = <0xa01c 0x4>; status = "disabled"; clocks = <&refclk>; - syscon = <&gcr>; }; }; };
Signature · 1 line
2.34.1
Quoted 4 lines · Tomer Maimon
The NPCM8XX DTSI currently includes a 'syscon' phandle in the watchdog node, but this property is not used by any upstream driver and is not documented in the NPCM watchdog binding. Since it was never reviewed and does not form part of the DT ABI, it can be safely removed.
"Safely" is not certain or not true, because other users might rely on that, but that's acceptable impact of undocumented ABI.
However such wording should be avoided, because it creates impression that it is safe which later might be used by other developers ("but I saw patch saying it is safe...").
Quoted 27 lines
Signed-off-by Tomer Maimon <[email protected]>--- arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 3 --- 1 file changed, 3 deletions(-)arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi +0
-2@@ -145,7 +145,6 @@ watchdog0: watchdog@801c { reg = <0x801c 0x4>; status = "disabled"; clocks = <&refclk>; - syscon = <&gcr>; }; watchdog1: watchdog@901c {@@ -154,7 +153,6 @@ watchdog1: watchdog@901c { reg = <0x901c 0x4>; status = "disabled"; clocks = <&refclk>; - syscon = <&gcr>; }; watchdog2: watchdog@a01c {
arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi watchdog2: watchdog@a01c { · line 166
Quoted 7 lines
arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi +0
-1@@ -163,7 +161,6 @@ watchdog2: watchdog@a01c { reg = <0xa01c 0x4>; status = "disabled"; clocks = <&refclk>; - syscon = <&gcr>; }; }; };
Best regards,
Krzysztof
Andrew Jeffery
maintainerQuoted 6 lines · Tomer Maimon
The NPCM8XX DTSI currently includes a 'syscon' phandle in the watchdog node, but this property is not used by any upstream driver and is not documented in the NPCM watchdog binding. Since it was never reviewed and does not form part of the DT ABI, it can be safely removed.
Thanks, I've applied this to the BMC tree.
Signature · 1 line
Andrew Jeffery <[email protected]>