ACPI: Enable CONFIG_ACPI_DEBUG by default
PATCH 1/1 ACPI: Enable CONFIG_ACPI_DEBUG by default
From: Mario Limonciello <[email protected]>
CONFIG_ACPI_DEBUG can be helpful for getting debug messages on OEM systems to identify a BIOS bug. It's a relatively small size increase to turn it on by default (50kb) and that saves asking people to enable it when an issue comes up because it wasn't in defconfig.
Enable it by default.
--- drivers/acpi/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/acpi/Kconfig +1 -0
@@ -394,6 +394,7 @@ config ACPI_TABLE_OVERRIDE_VIA_BUILTIN_INITRD config ACPI_DEBUG bool "Debug Statements" + default y help The ACPI subsystem can produce debug output. Saying Y enables this output and increases the kernel size by around 50K.
Signature · 1 line
2.43.0
Quoted 10 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
CONFIG_ACPI_DEBUGcan be helpful for getting debug messages on OEM systems to identify a BIOS bug. It's a relatively small size increase to turn it on by default (50kb) and that saves asking people to enable it when an issue comes up because it wasn't in defconfig.Enable it by default.
Signed-off-by Mario Limonciello <[email protected]>
Rafael,
Any thoughts on this? Especially in seeing Ingo trying to modernize more of the defconfig [1]?
[1] https://lore.kernel.org/lkml/[email protected]/#t
Quoted 16 lines
--- drivers/acpi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/acpi/Kconfig +1
-0@@ -394,6 +394,7 @@ config ACPI_TABLE_OVERRIDE_VIA_BUILTIN_INITRD config ACPI_DEBUG bool "Debug Statements" + default y help The ACPI subsystem can produce debug output. Saying Y enables this output and increases the kernel size by around 50K.
Rafael J. Wysocki
maintainerQuoted 13 lines · Mario Limonciello
Quoted 10 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
CONFIG_ACPI_DEBUGcan be helpful for getting debug messages on OEM systems to identify a BIOS bug. It's a relatively small size increase to turn it on by default (50kb) and that saves asking people to enable it when an issue comes up because it wasn't in defconfig.Enable it by default.
Signed-off-by Mario Limonciello <[email protected]>
Quoted 7 lines
Rafael,
Any thoughts on this? Especially in seeing Ingo trying to modernize more of the defconfig [1]?
I'm not sure if this is a good idea TBH.
The risk is that people will start reporting issues that have been there already, but now they become visible due to enabling ACPI_DEBUG by default.
Quoted 17 lines
Quoted 16 lines
--- drivers/acpi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/acpi/Kconfig +1
-0@@ -394,6 +394,7 @@ config ACPI_TABLE_OVERRIDE_VIA_BUILTIN_INITRD config ACPI_DEBUG bool "Debug Statements" + default y help The ACPI subsystem can produce debug output. Saying Y enables this output and increases the kernel size by around 50K.
Quoted 19 lines · Rafael J. Wysocki
Quoted 18 lines · Mario Limonciello
Quoted 10 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
CONFIG_ACPI_DEBUGcan be helpful for getting debug messages on OEM systems to identify a BIOS bug. It's a relatively small size increase to turn it on by default (50kb) and that saves asking people to enable it when an issue comes up because it wasn't in defconfig.Enable it by default.
Signed-off-by Mario Limonciello <[email protected]>Rafael,
Any thoughts on this? Especially in seeing Ingo trying to modernize more of the defconfig [1]?
Quoted 8 lines
Quoted 2 lines
I'm not sure if this is a good idea TBH.
The risk is that people will start reporting issues that have been there already, but now they become visible due to enabling
ACPI_DEBUGby default.
As several distros already enable it by default I would have expected some "noise" like this to have settled down.
Do you have specific messages in mind you think could be turning noisy from the extra debug statements?
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
--- drivers/acpi/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/acpi/Kconfig +1
-0@@ -394,6 +394,7 @@ config ACPI_TABLE_OVERRIDE_VIA_BUILTIN_INITRD config ACPI_DEBUG bool "Debug Statements" + default y help The ACPI subsystem can produce debug output. Saying Y enables this output and increases the kernel size by around 50K.
Rafael J. Wysocki
maintainerQuoted 30 lines · Mario Limonciello
Quoted 19 lines · Rafael J. Wysocki
Quoted 18 lines · Mario Limonciello
Quoted 10 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
CONFIG_ACPI_DEBUGcan be helpful for getting debug messages on OEM systems to identify a BIOS bug. It's a relatively small size increase to turn it on by default (50kb) and that saves asking people to enable it when an issue comes up because it wasn't in defconfig.Enable it by default.
Signed-off-by Mario Limonciello <[email protected]>Rafael,
Any thoughts on this? Especially in seeing Ingo trying to modernize more of the defconfig [1]?
Quoted 8 lines
Quoted 2 lines
I'm not sure if this is a good idea TBH.
The risk is that people will start reporting issues that have been there already, but now they become visible due to enabling
ACPI_DEBUGby default.
Quoted 5 lines
As several distros already enable it by default I would have expected some "noise" like this to have settled down.
Do you have specific messages in mind you think could be turning noisy from the extra debug statements?
Nothing in particular, mostly messages coming from ACPICA, like the ones complaining about missing objects that have always been missing and the firmware is now too old for anyone to really care.
Those messages are only really useful when there is someone willing to fix the issues that trigger them. Otherwise, they are just noise.
Though if it is enabled by default by distros used by the vast majority of people, it could be enabled by default in the mainline too.
Do you know which distros enable it by default?
Quoted 37 lines · Rafael J. Wysocki
Quoted 30 lines · Mario Limonciello
Quoted 19 lines · Rafael J. Wysocki
Quoted 18 lines · Mario Limonciello
Quoted 10 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
CONFIG_ACPI_DEBUGcan be helpful for getting debug messages on OEM systems to identify a BIOS bug. It's a relatively small size increase to turn it on by default (50kb) and that saves asking people to enable it when an issue comes up because it wasn't in defconfig.Enable it by default.
Signed-off-by Mario Limonciello <[email protected]>Rafael,
Any thoughts on this? Especially in seeing Ingo trying to modernize more of the defconfig [1]?
Quoted 8 lines
Quoted 2 lines
I'm not sure if this is a good idea TBH.
The risk is that people will start reporting issues that have been there already, but now they become visible due to enabling
ACPI_DEBUGby default.Quoted 5 lines
As several distros already enable it by default I would have expected some "noise" like this to have settled down.
Do you have specific messages in mind you think could be turning noisy from the extra debug statements?
Quoted 6 lines
Nothing in particular, mostly messages coming from ACPICA, like the ones complaining about missing objects that have always been missing and the firmware is now too old for anyone to really care.
Those messages are only really useful when there is someone willing to fix the issues that trigger them. Otherwise, they are just noise.
Ah I see. I suppose we could always have this on by default and if it becomes untenable from reports flip it back to off.
Quoted 6 lines
Though if it is enabled by default by distros used by the vast majority of people, it could be enabled by default in the mainline too.
Do you know which distros enable it by default?
I know Ubuntu and CachyOS both do today. Fedora did it in some of their kernels and they're pushing a change to enable it in more of them right now.
Rafael J. Wysocki
maintainerQuoted 43 lines · Mario Limonciello
Quoted 41 lines · Rafael J. Wysocki
Quoted 30 lines · Mario Limonciello
Quoted 19 lines · Rafael J. Wysocki
Quoted 18 lines · Mario Limonciello
Quoted 10 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
CONFIG_ACPI_DEBUGcan be helpful for getting debug messages on OEM systems to identify a BIOS bug. It's a relatively small size increase to turn it on by default (50kb) and that saves asking people to enable it when an issue comes up because it wasn't in defconfig.Enable it by default.
Signed-off-by Mario Limonciello <[email protected]>Rafael,
Any thoughts on this? Especially in seeing Ingo trying to modernize more of the defconfig [1]?
Quoted 8 lines
Quoted 2 lines
I'm not sure if this is a good idea TBH.
The risk is that people will start reporting issues that have been there already, but now they become visible due to enabling
ACPI_DEBUGby default.Quoted 5 lines
As several distros already enable it by default I would have expected some "noise" like this to have settled down.
Do you have specific messages in mind you think could be turning noisy from the extra debug statements?
Nothing in particular, mostly messages coming from ACPICA, like the ones complaining about missing objects that have always been missing and the firmware is now too old for anyone to really care.
Quoted 5 lines
Quoted 2 lines
Those messages are only really useful when there is someone willing to fix the issues that trigger them. Otherwise, they are just noise.
Ah I see. I suppose we could always have this on by default and if it becomes untenable from reports flip it back to off.
The problem is that we'd only see the impact after the distros picked up the new default config, which would take some time and then it might not be practical to disable it again.
I guess enabling it by default could be combined with changing ACPI_DEBUG_DEFAULT to ACPI_LV_REPAIR, say, but then you'd probably still need to ask people to make it more verbose to see the interesting messages.
Quoted 9 lines
Quoted 6 lines
Though if it is enabled by default by distros used by the vast majority of people, it could be enabled by default in the mainline too.
Do you know which distros enable it by default?
I know Ubuntu and CachyOS both do today. Fedora did it in some of their kernels and they're pushing a change to enable it in more of them right now.
So why don't we let them do it and then decide?
Quoted 47 lines · Rafael J. Wysocki
Quoted 46 lines · Mario Limonciello
Quoted 43 lines · Rafael J. Wysocki
Quoted 30 lines · Mario Limonciello
Quoted 19 lines · Rafael J. Wysocki
Quoted 18 lines · Mario Limonciello
Quoted 10 lines · Mario Limonciello
From: Mario Limonciello <[email protected]>
CONFIG_ACPI_DEBUGcan be helpful for getting debug messages on OEM systems to identify a BIOS bug. It's a relatively small size increase to turn it on by default (50kb) and that saves asking people to enable it when an issue comes up because it wasn't in defconfig.Enable it by default.
Signed-off-by Mario Limonciello <[email protected]>Rafael,
Any thoughts on this? Especially in seeing Ingo trying to modernize more of the defconfig [1]?
Quoted 8 lines
Quoted 2 lines
I'm not sure if this is a good idea TBH.
The risk is that people will start reporting issues that have been there already, but now they become visible due to enabling
ACPI_DEBUGby default.Quoted 5 lines
As several distros already enable it by default I would have expected some "noise" like this to have settled down.
Do you have specific messages in mind you think could be turning noisy from the extra debug statements?
Nothing in particular, mostly messages coming from ACPICA, like the ones complaining about missing objects that have always been missing and the firmware is now too old for anyone to really care.
Those messages are only really useful when there is someone willing to fix the issues that trigger them. Otherwise, they are just noise.
Quoted 6 lines
Quoted 2 lines
Ah I see. I suppose we could always have this on by default and if it becomes untenable from reports flip it back to off.
The problem is that we'd only see the impact after the distros picked up the new default config, which would take some time and then it might not be practical to disable it again.
Good point.
Quoted 5 lines
I guess enabling it by default could be combined with changing
ACPI_DEBUG_DEFAULTtoACPI_LV_REPAIR, say, but then you'd probably still need to ask people to make it more verbose to see the interesting messages.
To me having ACPI_DEBUG enabled and ACPI_DEBUG_DEFAULT turned down is totally fine. I find that the trace_* parameters are totally fine for what I've used it for so far. IE set appropriate trace values, load your module and report results. Or set trace values on the kernel command line and report results for boot issues.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Though if it is enabled by default by distros used by the vast majority of people, it could be enabled by default in the mainline too.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Do you know which distros enable it by default?
I know Ubuntu and CachyOS both do today. Fedora did it in some of their kernels and they're pushing a change to enable it in more of them right now.
So why don't we let them do it and then decide?
Sure, we can revisit next cycle.