Skip to contentSkip to conversation

ARM: Kirkwood: remove leds-netxbig.h include from nas2big DTS

PATCH New Simon Guinot 2 participants 2 messages Mar 11, 2015 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Kirkwood: remove leds-netxbig.h include from nas2big DTS

This patch fixes the following build error introduced by the patch a9e58557e998 ("ARM: Kirkwood: add DT description for nas2big"):

DTC arch/arm/boot/dts/kirkwood-nas2big.dtb
/home/simon/workspace/lacie-nas.org/src/linux-lacie.git/arch/arm/boot/dts/kirkwood-nas2big.dts:16:
fatal error: dt-bindings/leds/leds-netxbig.h: No such file or directory compilation terminated.
scripts/Makefile.lib:292: recipe for target 'arch/arm/boot/dts/kirkwood-nas2big.dtb' failed

Since the leds-netxbig DT binding is not merged yet, the dt-bindings/leds/leds-netxbig.h header can't be used. Moreover there is no point in including leds-netxbig.h from the nas2big DTS anyway: since the LEDs characteristics are shared between all the netxbig boards, the LED node will be added in the kirkwood-netxbig DTSI file.

This patch fixes the build error by removing the useless leds-netxbig.h include.

---
 arch/arm/boot/dts/kirkwood-nas2big.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/kirkwood-nas2big.dts +0 -1
index d459c94fd1d4..7427ec50b829 100644
@@ -12,7 +12,6 @@
 
 /dts-v1/;
 
-#include <dt-bindings/leds/leds-netxbig.h>
 #include "kirkwood-netxbig.dtsi"
 
 / {
Signature · 1 line
2.1.1
#1 lore raw

PATCH 1/1 ARM: Kirkwood: remove leds-netxbig.h include from nas2big DTS

Hi Simon,

Quoted 10 lines · Simon Guinot

This patch fixes the following build error introduced by the patch a9e58557e998 ("ARM: Kirkwood: add DT description for nas2big"):

DTC arch/arm/boot/dts/kirkwood-nas2big.dtb
/home/simon/workspace/lacie-nas.org/src/linux-lacie.git/arch/arm/boot/dts/kirkwood-nas2big.dts:16:
fatal error: dt-bindings/leds/leds-netxbig.h: No such file or directory compilation terminated.
scripts/Makefile.lib:292: recipe for target 'arch/arm/boot/dts/kirkwood-nas2big.dtb' failed

Quoted 8 lines

Since the leds-netxbig DT binding is not merged yet, the dt-bindings/leds/leds-netxbig.h header can't be used. Moreover there is no point in including leds-netxbig.h from the nas2big DTS anyway: since the LEDs characteristics are shared between all the netxbig boards, the LED node will be added in the kirkwood-netxbig DTSI file.

This patch fixes the build error by removing the useless leds-netxbig.h include.

I squashed it in the previous commit (a9e58557e998 ("ARM: Kirkwood: add DT description for nas2big") in mvebu/dt and merged this branch in mvebu/for-next. So the build would be OK in next-20150312.

Thanks,

Gregory

Quoted 19 lines
---
 arch/arm/boot/dts/kirkwood-nas2big.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/kirkwood-nas2big.dts +0 -1
index d459c94fd1d4..7427ec50b829 100644
@@ -12,7 +12,6 @@
 
 /dts-v1/;
 
-#include <dt-bindings/leds/leds-netxbig.h>
 #include "kirkwood-netxbig.dtsi"
 
 / {
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com