net: ping: return an error exit code when connection fails

PATCH In review Mirko Damiani 2 participants 3 messages Mar 16, 2015 – Mar 17, 2015 Networking

Share & tools

Mirko Damiani

author

2015-03-16 15:03 UTC #0 lore raw

PATCH 1/1 net: ping: return an error exit code when connection fails

Hi,
ping command does not always returns 1 as exit code when connection to host fails. In particular it returns the exit code of the previous run.
This patch fixes this issue.

Signed-off-by Mirko Damiani <[email protected]>

---
 net/ping.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

net/ping.c +3 -3

index 2349f4b..4eb77cb 100644
@@ -67,6 +67,9 @@ static int do_ping(int argc, char *argv[])
         return 1;
     }
 
+    ping_state = PING_STATE_INIT;
+    ping_sequence_number = 0;
+
     ping_con = net_icmp_new(net_ping_ip, ping_handler, NULL);
     if (IS_ERR(ping_con)) {
         ret = PTR_ERR(ping_con);

@@ -78,9 +81,6 @@ static int do_ping(int argc, char *argv[])
     if (ret)
         goto out_unreg;
 
-    ping_state = PING_STATE_INIT;
-    ping_sequence_number = 0;
-
     while (ping_state == PING_STATE_INIT) {
         if (ctrlc()) {
             ret = -EINTR;

Signature · 7 lines

1.9.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

mirko

author

2015-03-16 16:09 UTC #1 lore raw

Il 2015-03-16 16:02 Mirko Damiani ha scritto:

Quoted 6 lines

Hi,
ping command does not always returns 1 as exit code when connection to host fails.
In particular it returns the exit code of the previous run. This patch fixes this issue.

Sorry, the same patch with proper tabulation characters.

Signed-off-by Mirko Damiani <[email protected]>

---
 net/ping.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

net/ping.c +3 -3

index 2349f4b..4eb77cb 100644
@@ -67,6 +67,9 @@ static int do_ping(int argc, char *argv[])
 		return 1;
 	}
 
+	ping_state = PING_STATE_INIT;
+	ping_sequence_number = 0;
+
 	ping_con = net_icmp_new(net_ping_ip, ping_handler, NULL);
 	if (IS_ERR(ping_con)) {
 		ret = PTR_ERR(ping_con);

@@ -78,9 +81,6 @@ static int do_ping(int argc, char *argv[])
 	if (ret)
 		goto out_unreg;
 
-	ping_state = PING_STATE_INIT;
-	ping_sequence_number = 0;
-
 	while (ping_state == PING_STATE_INIT) {
 		if (ctrlc()) {
 			ret = -EINTR;

Signature · 6 lines

1.9.1

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Sascha Hauer

2015-03-17 07:11 UTC #2 lore raw

Hi Mirko,

Quoted 9 lines · mirko

Il 2015-03-16 16:02 Mirko Damiani ha scritto:
Quoted 6 lines
Hi,
ping command does not always returns 1 as exit code when connection to host fails.
In particular it returns the exit code of the previous run. This patch fixes this issue.
Sorry, the same patch with proper tabulation characters.

I can confirm that this patch now has tabs instead of spaces, but it still does not apply because there are some spaces in the context which shouldn't be there. Anyway, applied it manually, thanks

Sascha

Signature · 9 lines

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox