Skip to contentSkip to conversation

parisc: Do not hardcode PAGE_SIZE dependend values in assembler

PATCH In review Helge Deller 1 participant 2 messages Mar 16, 2015 PA-RISC architecture

lore
Share & tools
lore

Helge Deller

author maintainer
#0 lore raw

PATCH 1/1 parisc: Do not hardcode PAGE_SIZE dependend values in assembler

arch/parisc/kernel/entry.S +2 -2
index 2ab16bb..c9bbf88 100644
@@ -640,9 +640,9 @@
 	 * Check "subtle" note in pacache.S re: r23/r26.
 	 */
 #ifdef CONFIG_64BIT
-	extrd,u,*=	\va,41,1,%r0
+	extrd,u,*=	\va,63-PAGE_SHIFT,1,%r0
 #else
-	extrw,u,=	\va,9,1,%r0
+	extrw,u,=	\va,31-PAGE_SHIFT,1,%r0
 #endif
 	or,COND(tr)	%r23,%r0,\pte
 	or		%r26,%r0,\pte
author maintainer
#1 lore raw

ignore this patch - it's wrong.

Helge

Quoted 19 lines · Helge Deller
arch/parisc/kernel/entry.S +2 -2
index 2ab16bb..c9bbf88 100644
@@ -640,9 +640,9 @@
  	 * Check "subtle" note in pacache.S re: r23/r26.
  	 */
  #ifdef CONFIG_64BIT
-	extrd,u,*=	\va,41,1,%r0
+	extrd,u,*=	\va,63-PAGE_SHIFT,1,%r0
  #else
-	extrw,u,=	\va,9,1,%r0
+	extrw,u,=	\va,31-PAGE_SHIFT,1,%r0
  #endif
  	or,COND(tr)	%r23,%r0,\pte
  	or		%r26,%r0,\pte