Skip to contentSkip to conversation

toolchain: disable internal for blackfin

PATCH New Gustavo Zacarias 2 participants 5 messages Mar 17, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain: disable internal for blackfin

The internal toolchain was a "best effort" approach - we strived to make it build properly and all but it's mostly untested.
Since it's got issues disable it until it's properly fixed and tested and leave the official ADI toolchain instead.

---
 toolchain/Config.in | 1 +
 1 file changed, 1 insertion(+)
toolchain/Config.in +1 -0
index 291db94..32a00a9 100644
@@ -41,6 +41,7 @@ choice
 
 config BR2_TOOLCHAIN_BUILDROOT
 	bool "Buildroot toolchain"
+	depends on !BR2_bfin
 	select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
 
 config BR2_TOOLCHAIN_EXTERNAL
Signature · 1 line
2.0.5
#1 lore raw

PATCH 1/1 toolchain: disable internal for blackfin

Dear Gustavo Zacarias,

Quoted 6 lines · Gustavo Zacarias

The internal toolchain was a "best effort" approach - we strived to make it build properly and all but it's mostly untested.
Since it's got issues disable it until it's properly fixed and tested and leave the official ADI toolchain instead.

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 toolchain: disable internal for blackfin

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 6 lines · Gustavo Zacarias

The internal toolchain was a "best effort" approach - we strived to make it build properly and all but it's mostly untested.
Since it's got issues disable it until it's properly fixed and tested and leave the official ADI toolchain instead.

Maybe some follow-up patches are possible, in binutils/Config.in.host and gcc/Config.in.host in the selection of versions?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 toolchain: disable internal for blackfin

Quoted 2 lines · Thomas Petazzoni

Maybe some follow-up patches are possible, in binutils/Config.in.host and gcc/Config.in.host in the selection of versions?

Do we want to completely remove traces about it?
Regards.

#4 lore raw

PATCH 1/1 toolchain: disable internal for blackfin

Dear Gustavo Zacarias,

Quoted 4 lines · Gustavo Zacarias
Quoted 2 lines

Maybe some follow-up patches are possible, in binutils/Config.in.host and gcc/Config.in.host in the selection of versions?

Do we want to completely remove traces about it?

Well to be honest, seeing how little contributions the Blackfin people are doing to upstream projects, I am not really hoping a radical improvement in the upstream support for Blackfin in the coming months (years?). So I'd prefer to remove the traces of Blackfin support.

Another option of course, would be to introduce support for the ADI specific gcc and binutils versions at
http://sourceforge.net/p/adi-toolchain/blackfin/ci/master/tree/. But it's one Git repository with everything, so not easy to package.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com