ARM: socfpga: dts: fix spi1 interrupt
Hello,
The socfpga.dtsi currently has the wrong interrupt number set for SPI master 1. Trying to use the master without this change results in the kernel boot process waiting forever for an interrupt that will never occur while attempting to probe any slave devices configured in the device tree as being under SPI master 1.
The change works for the Cyclone V, and according to the Arria 5 handbook should be good there too.
--- arch/arm/boot/dts/socfpga.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/socfpga.dtsi +1 -1
@@ -660,7 +660,7 @@ #address-cells = <1>; #size-cells = <0>; reg = <0xfff01000 0x1000>; - interrupts = <0 156 4>; + interrupts = <0 155 4>; num-cs = <4>; clocks = <&spi_m_clk>; status = "disabled";
Signature · 1 line
2.1.0
Hi!
Quoted 19 lines · Mark James
Hello,
The
socfpga.dtsicurrently has the wrong interrupt number set for SPI master 1. Trying to use the master without this change results in the kernel boot process waiting forever for an interrupt that will never occur while attempting to probe any slave devices configured in the device tree as being under SPI master 1.The change works for the Cyclone V, and according to the Arria 5 handbook should be good there too.
Signed-off-by Mark James <[email protected]>Acked-by Steffen Trumtrar <[email protected]>--- arch/arm/boot/dts/socfpga.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/socfpga.dtsi +0
-0
arch/arm/boot/dts/socfpga.dtsi line 666
Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1
-1@@ -660,7 +660,7 @@ #address-cells = <1>; #size-cells = <0>; reg = <0xfff01000 0x1000>; - interrupts = <0 156 4>; + interrupts = <0 155 4>; num-cs = <4>; clocks = <&spi_m_clk>; status = "disabled";
Thanks for sending the patch to the mainline list. One little nitpick about the patchformat though:
Please add linebreaks after 70-75 characters for readability. And remove the "Hello,\n\n" otherwise this would land in the final git commit, where it doesn't belong.
For reference have a look at Documentation/SubmittingPatches in the kernel tree.
Maybe Dinh can fix this up, otherwise he will tell you what to do.
Thanks,
Steffen
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 34 lines · Steffen Trumtrar
Hi!
Quoted 19 lines · Mark James
Hello,
The
socfpga.dtsicurrently has the wrong interrupt number set for SPI master 1. Trying to use the master without this change results in the kernel boot process waiting forever for an interrupt that will never occur while attempting to probe any slave devices configured in the device tree as being under SPI master 1.The change works for the Cyclone V, and according to the Arria 5 handbook should be good there too.
Signed-off-by Mark James <[email protected]>Acked-by Steffen Trumtrar <[email protected]>--- arch/arm/boot/dts/socfpga.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/socfpga.dtsi +0
-0arch/arm/boot/dts/socfpga.dtsi line 666
Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1
-1@@ -660,7 +660,7 @@ #address-cells = <1>; #size-cells = <0>; reg = <0xfff01000 0x1000>; - interrupts = <0 156 4>; + interrupts = <0 155 4>; num-cs = <4>; clocks = <&spi_m_clk>; status = "disabled";Thanks for sending the patch to the mainline list. One little nitpick about the patchformat though:
Quoted 8 lines
Please add linebreaks after 70-75 characters for readability. And remove the "Hello,\n\n" otherwise this would land in the final git commit, where it doesn't belong.
For reference have a look atDocumentation/SubmittingPatchesin the kernel tree.Maybe Dinh can fix this up, otherwise he will tell you what to do.
Yes, I can pick this up and fix up the commit.
Dinh
Hi Dinh,
Thank you for that - I thought I would be all good with what I sent having changed the settings in Thunderbird as per Documentation/email-clients.txt, evidently not! Will do some more reading before submitting any more patches.
Thanks again,
Mark
Quoted 48 lines · Dinh Nguyen
Quoted 34 lines · Steffen Trumtrar
Hi!
Quoted 19 lines · Mark James
Hello,
The
socfpga.dtsicurrently has the wrong interrupt number set for SPI master 1. Trying to use the master without this change results in the kernel boot process waiting forever for an interrupt that will never occur while attempting to probe any slave devices configured in the device tree as being under SPI master 1.The change works for the Cyclone V, and according to the Arria 5 handbook should be good there too.
Signed-off-by Mark James <[email protected]>Acked-by Steffen Trumtrar <[email protected]>--- arch/arm/boot/dts/socfpga.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/socfpga.dtsi +0
-0arch/arm/boot/dts/socfpga.dtsi line 666
Quoted 8 lines
arch/arm/boot/dts/socfpga.dtsi +1
-1@@ -660,7 +660,7 @@ #address-cells = <1>; #size-cells = <0>; reg = <0xfff01000 0x1000>; - interrupts = <0 156 4>; + interrupts = <0 155 4>; num-cs = <4>; clocks = <&spi_m_clk>; status = "disabled";Thanks for sending the patch to the mainline list. One little nitpick about the patchformat though:
Quoted 8 lines
Please add linebreaks after 70-75 characters for readability. And remove the "Hello,\n\n" otherwise this would land in the final git commit, where it doesn't belong.
For reference have a look atDocumentation/SubmittingPatchesin the kernel tree.Maybe Dinh can fix this up, otherwise he will tell you what to do.
Yes, I can pick this up and fix up the commit.
Dinh
Quoted 4 lines · Mark James
Hi Dinh,
Thank you for that - I thought I would be all good with what I sent having changed the settings in Thunderbird as per
Documentation/email-clients.txt, evidently not! Will do some more reading before submitting any more patches.
"git send-email" is your friend ;-)
It does the right thing. (As long as the original git commit is correct of course)
Regards,
Steffen
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |