Skip to contentSkip to conversation

package/dvdrw-tools: fix incorrect default choiche

PATCH New Angelo Compagnucci 3 participants 3 messages Mar 17, 2015 – Mar 18, 2015

lore
Share & tools
lore

Angelo Compagnucci

author
#0 lore raw

PATCH 1/1 package/dvdrw-tools: fix incorrect default choiche

This pathc fixes default choiche BR2_PACKAGE_DVDRW_TOOLS_CDRKIT_BACKEND.

Signed-off-by Angelo Compagnucci <[email protected]>
---
 package/dvdrw-tools/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/dvdrw-tools/Config.in +1 -1
index 6787b66..fb4d4c2 100644
@@ -35,7 +35,7 @@ config BR2_PACKAGE_DVDRW_TOOLS
 if BR2_PACKAGE_DVDRW_TOOLS
 choice
 	prompt "Media Backend"
-	default BR2_PACKAGE_DVDRW_CDRKIT_BACKEND
+	default BR2_PACKAGE_DVDRW_TOOLS_CDRKIT_BACKEND
 	help
 	  Choose which media backend program to use.
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/dvdrw-tools: fix incorrect default choiche

package/dvdrw-tools/Config.in config BR2_PACKAGE_DVDRW_TOOLS · line 38

Quoted 7 lines · Angelo Compagnucci

This pathc fixes default choiche BR2_PACKAGE_DVDRW_TOOLS_CDRKIT_BACKEND.

if BR2_PACKAGE_DVDRW_TOOLS
choice

package/dvdrw-tools/Config.in +1 -1
 	prompt "Media Backend"
-	default BR2_PACKAGE_DVDRW_CDRKIT_BACKEND
+	default BR2_PACKAGE_DVDRW_TOOLS_CDRKIT_BACKEND

Arg! I can't I let that slip through. Thanks for catching it.

Steve

#2 lore raw

PATCH 1/1 package/dvdrw-tools: fix incorrect default choiche

In reply to Angelo Compagnucci

Angelo, All,

On 2015-03-17 23:28 +0100, Angelo Compagnucci spake thusly:

Quoted 12 lines

This pathc fixes default choiche BR2_PACKAGE_DVDRW_TOOLS_CDRKIT_BACKEND.

Signed-off-by Angelo Compagnucci <[email protected]>
---
 package/dvdrw-tools/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/dvdrw-tools/Config.in +0 -0
index 6787b66..fb4d4c2 100644

package/dvdrw-tools/Config.in config BR2_PACKAGE_DVDRW_TOOLS · line 38

Quoted 5 lines
package/dvdrw-tools/Config.in +1 -1
@@ -35,7 +35,7 @@ config BR2_PACKAGE_DVDRW_TOOLS
 if BR2_PACKAGE_DVDRW_TOOLS
 choice
 	prompt "Media Backend"
-	default BR2_PACKAGE_DVDRW_CDRKIT_BACKEND
+	default BR2_PACKAGE_DVDRW_TOOLS_CDRKIT_BACKEND

In fact that's not needed since cdrkit is the first entry.

Besides, and I missed it durign the review too, we can't force cdrkit as the default sicne it has a dependency which is not reported here; it should have been (options elided for readability):

choice
bool "backend"
default CDRKIT if HEADERS_AT_LEAST_3_0

But really, there's no reason to have a default in the first place, so I suggest we just get rid of it:

- if kernel headers >= 3.0, cdrkit will be used by default as it is

    the first entry in the choice;

- otherwise, cdrkit will be unavailable, and xorriso will be used.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/dvdrw-tools/Config.in +0 -0
 	help
 	  Choose which media backend program to use.
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'