ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
PATCH 1/1 ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
From: Nadav Haklai <[email protected]>
The resources of the cpuclk node are overlapping the one from coredivclk node. It was not noticed until now because the driver did a simple of_iomap and not a request_mem_region. This patch fixes it.
--- arch/arm/boot/dts/armada-xp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/armada-xp.dtsi +1 -1
@@ -149,7 +149,7 @@ cpuclk: clock-complex at 18700 { #clock-cells = <1>; compatible = "marvell,armada-xp-cpu-clock"; - reg = <0x18700 0xA0>, <0x1c054 0x10>; + reg = <0x18700 0x24>, <0x1c054 0x10>; clocks = <&coreclk 1>; };
Signature · 1 line
2.1.0
PATCH 1/1 ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
Hi,
Quoted 5 lines · Gregory CLEMENT
From: Nadav Haklai <[email protected]>
The resources of the cpuclk node are overlapping the one from coredivclk node. It was not noticed until now because the driver did a simple
of_iomapand not arequest_mem_region. This patch fixes it.
unless someone is against it, I will apply it on mvebu/dt tomorrow.
Thanks,
Gregory
Quoted 23 lines
[gregory.clement at free-electrons.com: add commit log and port to 4.0-rc]Signed-off-by Gregory CLEMENT <[email protected]>Signed-off-by Nadav Haklai <[email protected]>Signed-off-by Nadav Haklai <[email protected]>--- arch/arm/boot/dts/armada-xp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/armada-xp.dtsi +1
-1@@ -149,7 +149,7 @@ cpuclk: clock-complex at 18700 { #clock-cells = <1>; compatible = "marvell,armada-xp-cpu-clock"; - reg = <0x18700 0xA0>, <0x1c054 0x10>; + reg = <0x18700 0x24>, <0x1c054 0x10>; clocks = <&coreclk 1>; };
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
In reply to Gregory CLEMENTDear Gregory CLEMENT,
Quoted 10 lines · Gregory CLEMENT
From: Nadav Haklai <[email protected]>
The resources of the cpuclk node are overlapping the one from coredivclk node. It was not noticed until now because the driver did a simple
of_iomapand not arequest_mem_region. This patch fixes it.[gregory.clement at free-electrons.com: add commit log and port to 4.0-rc]Signed-off-by Gregory CLEMENT <[email protected]>Signed-off-by Nadav Haklai <[email protected]>Signed-off-by Nadav Haklai <[email protected]>
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
Quoted 9 lines · Thomas Petazzoni
Dear Gregory CLEMENT,
Quoted 6 lines · Gregory CLEMENT
From: Nadav Haklai <[email protected]>
The resources of the cpuclk node are overlapping the one from coredivclk node. It was not noticed until now because the driver did a simple
of_iomapand not arequest_mem_region. This patch fixes it.
Quoted 7 lines
Quoted 4 lines
[gregory.clement at free-electrons.com: add commit log and port to 4.0-rc]Signed-off-by Gregory CLEMENT <[email protected]>Signed-off-by Nadav Haklai <[email protected]>Signed-off-by Nadav Haklai <[email protected]>Reviewed-by Thomas Petazzoni <[email protected]>
applied on mvebu/dt with Thomas tag
Thanks,
Gregory
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com