Skip to contentSkip to conversation

drivers/net/e1000.c: Cleanup whitespace

PATCH New York Sun 2 participants 6 messages Mar 19, 2015 – Apr 23, 2015 Network drivers

lore
Share & tools
lore

York Sun

author
#0 lore raw

PATCH 1/1 drivers/net/e1000.c: Cleanup whitespace

From: Minghuan Lian <[email protected]>

The patch removes unnecessary whitespace to fix checkpatch's
warning: unnecessary whitespace before a quoted newline

Signed-off-by Minghuan Lian <[email protected]>
CC Joe Hershberger <[email protected]>
---
 drivers/net/e1000.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/net/e1000.c +4 -4
index cd44222..e747d97 100644
@@ -2174,7 +2174,7 @@ e1000_copper_link_preconfig(struct e1000_hw *hw)
 		DEBUGOUT("Error, did not detect valid phy.\n");
 		return ret_val;
 	}
-	DEBUGOUT("Phy ID = %x \n", hw->phy_id);
+	DEBUGOUT("Phy ID = %x\n", hw->phy_id);
 
 	/* Set PHY to class A mode (if necessary) */
 	ret_val = e1000_set_phy_mode(hw);

@@ -3485,11 +3485,11 @@ e1000_config_fc_after_link_up(struct e1000_hw *hw)
 		 * some "sticky" (latched) bits.
 		 */
 		if (e1000_read_phy_reg(hw, PHY_STATUS, &mii_status_reg) < 0) {
-			DEBUGOUT("PHY Read Error \n");
+			DEBUGOUT("PHY Read Error\n");
 			return -E1000_ERR_PHY;
 		}
 		if (e1000_read_phy_reg(hw, PHY_STATUS, &mii_status_reg) < 0) {
-			DEBUGOUT("PHY Read Error \n");
+			DEBUGOUT("PHY Read Error\n");
 			return -E1000_ERR_PHY;
 		}
 

@@ -5152,7 +5152,7 @@ e1000_poll(struct eth_device *nic)
 
 	if (!(le32_to_cpu(rd->status)) & E1000_RXD_STAT_DD)
 		return 0;
-	/*DEBUGOUT("recv: packet len=%d \n", rd->length); */
+	/* DEBUGOUT("recv: packet len=%d\n", rd->length); */
 	/* Packet received, make sure the data are re-loaded from RAM. */
 	len = le32_to_cpu(rd->length);
 	invalidate_dcache_range((unsigned long)packet,
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH 1/1 drivers/net/e1000.c: Cleanup whitespace

Quoted 9 lines · Joe Hershberger
Quoted 2 lines · On Thu, Mar 19, 2015 at 11:43 AM, York Sun <[email protected]…

From: Minghuan Lian <[email protected]

<mailto:[email protected]>>

Quoted 4 lines

The patch removes unnecessary whitespace to fix checkpatch's
warning: unnecessary whitespace before a quoted newline

Quoted 9 lines
Quoted 1 line
Signed-off-by Minghuan Lian <[email protected]

<mailto:[email protected]>>

Quoted 1 line
CC Joe Hershberger <joe.hershberger at ni.com <mailto:[email protected]>>
Acked-by Joe Hershberger <joe.hershberger at ni.com <mailto:[email protected]>>

Want me to pull this one through my tree?

No. Your ack is good enough. I will pull it in along with other patches.

York

author
#3 lore raw

PATCH 1/1 drivers/net/e1000.c: Cleanup whitespace

Quoted 16 lines · York Sun
Quoted 13 lines · Joe Hershberger
Quoted 2 lines · On Thu, Mar 19, 2015 at 11:43 AM, York Sun <[email protected]…

From: Minghuan Lian <[email protected]

<mailto:[email protected]>>

Quoted 5 lines

The patch removes unnecessary whitespace to fix checkpatch's
warning: unnecessary whitespace before a quoted newline

Signed-off-by Minghuan Lian <[email protected]

<mailto:[email protected]>>

Quoted 1 line
CC Joe Hershberger <joe.hershberger at ni.com <mailto:[email protected]>>
Quoted 8 lines
Quoted 5 lines
Acked-by Joe Hershberger <joe.hershberger at ni.com <mailto:[email protected]>>

Want me to pull this one through my tree?

No. Your ack is good enough. I will pull it in along with other patches.

A second thought, if you can bring it in for 2015.04, feel free to do so. Otherwise I will bring it in along with my other patches, targeting 2015.07.

York

#4 lore raw

PATCH 1/1 drivers/net/e1000.c: Cleanup whitespace

Quoted 9 lines · York Sun
Quoted 7 lines · York Sun
Quoted 4 lines · Joe Hershberger
Quoted 2 lines · On Thu, Mar 19, 2015 at 11:43 AM, York Sun <[email protected]…

From: Minghuan Lian <[email protected]

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

<mailto:[email protected]>>

Quoted 5 lines

The patch removes unnecessary whitespace to fix checkpatch's
warning: unnecessary whitespace before a quoted newline

Signed-off-by Minghuan Lian <[email protected]

<mailto:[email protected]>>

Quoted 1 line
CC Joe Hershberger <joe.hershberger at ni.com <mailto:

[email protected]>>

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Acked-by Joe Hershberger <joe.hershberger at ni.com <mailto:

[email protected]>>

Quoted 10 lines
Quoted 7 lines
Quoted 4 lines

Want me to pull this one through my tree?

No. Your ack is good enough. I will pull it in along with other patches.

A second thought, if you can bring it in for 2015.04, feel free to do so. Otherwise I will bring it in along with my other patches, targeting

2015.07.

It wouldn't be for 2015.04. Go ahead and take it along with your other patches.

-Joe

author Applied
#5 lore raw

PATCH 1/1 drivers/net/e1000.c: Cleanup whitespace

In reply to Joe Hershberger
Quoted 6 lines · Joe Hershberger
Quoted 2 lines · On Thu, Mar 19, 2015 at 11:43 AM, York Sun <[email protected]…

From: Minghuan Lian <[email protected]

<mailto:[email protected]>>

Quoted 1 line
Quoted 9 lines
Quoted 4 lines

The patch removes unnecessary whitespace to fix checkpatch's
warning: unnecessary whitespace before a quoted newline

Signed-off-by Minghuan Lian <[email protected]

<mailto:[email protected]>>

Quoted 1 line
CC Joe Hershberger <joe.hershberger at ni.com <mailto:[email protected]>>
Acked-by Joe Hershberger <joe.hershberger at ni.com <mailto:[email protected]>>

Applied to fsl-qoriq master, awaiting upstream.

York