Skip to contentSkip to conversation

cmd_mem: Store last address/size/etc as ulong

PATCH New York Sun 2 participants 4 messages Mar 19, 2015 – Apr 23, 2015

lore
Share & tools
lore

York Sun

author
#0 lore raw

PATCH 1/1 cmd_mem: Store last address/size/etc as ulong

From: Scott Wood <[email protected]>

Otherwise the high 32 bits get truncated on 64-bit U-boot.

Signed-off-by Scott Wood <[email protected]>
CC Simon Glass <[email protected]>
---
 common/cmd_mem.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
common/cmd_mem.c +3 -3
index bcb3ee3..62a0404 100644
@@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
 /* Display values from last command.
  * Memory modify remembered values are different from display memory.
  */
-static uint	dp_last_addr, dp_last_size;
-static uint	dp_last_length = 0x40;
-static uint	mm_last_addr, mm_last_size;
+static ulong	dp_last_addr, dp_last_size;
+static ulong	dp_last_length = 0x40;
+static ulong	mm_last_addr, mm_last_size;
 
 static	ulong	base_address = 0;
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 cmd_mem: Store last address/size/etc as ulong

Quoted 16 lines · York Sun

From: Scott Wood <[email protected]>

Otherwise the high 32 bits get truncated on 64-bit U-boot.

Signed-off-by Scott Wood <[email protected]>
CC Simon Glass <[email protected]>
---
 common/cmd_mem.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
common/cmd_mem.c +0 -0
index bcb3ee3..62a0404 100644
@@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
 /* Display values from last command.

common/cmd_mem.c static int mod_mem(cmd_tbl_t *, int, int, int, char * const []); · line 42

Quoted 10 lines
common/cmd_mem.c +3 -3
  * Memory modify remembered values are different from display memory.
  */
-static uint    dp_last_addr, dp_last_size;
-static uint    dp_last_length = 0x40;
-static uint    mm_last_addr, mm_last_size;
+static ulong   dp_last_addr, dp_last_size;
+static ulong   dp_last_length = 0x40;
+static ulong   mm_last_addr, mm_last_size;
 
 static ulong   base_address = 0;
Reviewed-by Simon Glass <[email protected]>
Quoted 4 lines
common/cmd_mem.c +0 -1
--

1.7.9.5

author
#2 lore raw

PATCH 1/1 cmd_mem: Store last address/size/etc as ulong

Quoted 26 lines · Simon Glass
Quoted 25 lines · York Sun

From: Scott Wood <[email protected]>

Otherwise the high 32 bits get truncated on 64-bit U-boot.

Signed-off-by Scott Wood <[email protected]>
CC Simon Glass <[email protected]>
---
 common/cmd_mem.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
common/cmd_mem.c +3 -3
index bcb3ee3..62a0404 100644
@@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
 /* Display values from last command.
  * Memory modify remembered values are different from display memory.
  */
-static uint    dp_last_addr, dp_last_size;
-static uint    dp_last_length = 0x40;
-static uint    mm_last_addr, mm_last_size;
+static ulong   dp_last_addr, dp_last_size;
+static ulong   dp_last_length = 0x40;
+static ulong   mm_last_addr, mm_last_size;
Quoted 4 lines

common/cmd_mem.c static int mod_mem(cmd_tbl_t *, int, int, int, char * const []); · line 42

Quoted 1 line
common/cmd_mem.c +0 -0
 static ulong   base_address = 0;
Reviewed-by Simon Glass <[email protected]>

Feel free to bring it in. Otherwise I will bring it in along with my other patches, targeting 2015.07.

York

author Applied
#3 lore raw

PATCH 1/1 cmd_mem: Store last address/size/etc as ulong

In reply to Simon Glass
Quoted 26 lines · Simon Glass
Quoted 25 lines · York Sun

From: Scott Wood <[email protected]>

Otherwise the high 32 bits get truncated on 64-bit U-boot.

Signed-off-by Scott Wood <[email protected]>
CC Simon Glass <[email protected]>
---
 common/cmd_mem.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
common/cmd_mem.c +3 -3
index bcb3ee3..62a0404 100644
@@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
 /* Display values from last command.
  * Memory modify remembered values are different from display memory.
  */
-static uint    dp_last_addr, dp_last_size;
-static uint    dp_last_length = 0x40;
-static uint    mm_last_addr, mm_last_size;
+static ulong   dp_last_addr, dp_last_size;
+static ulong   dp_last_length = 0x40;
+static ulong   mm_last_addr, mm_last_size;
Quoted 3 lines

common/cmd_mem.c static int mod_mem(cmd_tbl_t *, int, int, int, char * const []); · line 42

Quoted 1 line
common/cmd_mem.c +0 -0
 static ulong   base_address = 0;
Reviewed-by Simon Glass <[email protected]>

Applied to fsl-qoriq master, awaiting upstream.

York