Skip to contentSkip to conversation

kselftest/timers: Set default threadtest values to simplify execution scripts

PATCH Applied John Stultz 2 participants 4 messages Mar 18, 2015 – Mar 19, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kselftest/timers: Set default threadtest values to simplify execution scripts

In order to keep the kselftest Makefiles simpler, set the threadtest default values to the ones used in standard run_tests

Cc Shuah Khan <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Richard Cochran <[email protected]>
---
 tools/testing/selftests/timers/threadtest.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
tools/testing/selftests/timers/threadtest.c +6 -2
index facd889..e632e11 100644
@@ -126,11 +126,13 @@ void *independent_thread(void *arg)
 	return NULL;
 }
 
+#define DEFAULT_THREAD_COUNT 8
+#define DEFAULT_RUNTIME 30
 
 int main(int argc, char **argv)
 {
-	int thread_count = 1, i;
-	time_t start, now, runtime = 60;
+	int thread_count, i;
+	time_t start, now, runtime;
 	char buf[255];
 	pthread_t pth[MAX_THREADS];
 	int opt;
@@ -138,6 +140,8 @@ int main(int argc, char **argv)
 	int ret = 0;
 	void *(*thread)(void *) = shared_thread;
 
+	thread_count = DEFAULT_THREAD_COUNT;
+	runtime = DEFAULT_RUNTIME;
 
 	/* Process arguments */
 	while ((opt = getopt(argc, argv, "t:n:i")) != -1) {
Signature · 1 line
1.9.1
Applied
#1 lore raw
Quoted 12 lines · John Stultz

In order to keep the kselftest Makefiles simpler, set the threadtest default values to the ones used in standard run_tests

Cc Shuah Khan <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Richard Cochran <[email protected]>
---
 tools/testing/selftests/timers/threadtest.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Applied to next for 4.1

Some numbers for you with timer tests included:

make kselftest target takes:

real    11m50.499s
user    3m25.979s
sys     5m45.433s

It is creeping up, previous timing was

real 9.41
user 3.55
system 0:24.86

Not concerned yet. Might be getting closer to needing to defining quick vs long test categories.

thanks,
-- Shuah

Signature · 5 lines
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978
#2 lore raw
Quoted 24 lines · Shuah Khan
Quoted 12 lines · John Stultz

In order to keep the kselftest Makefiles simpler, set the threadtest default values to the ones used in standard run_tests

Cc Shuah Khan <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Richard Cochran <[email protected]>
---
 tools/testing/selftests/timers/threadtest.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Applied to next for 4.1

Some numbers for you with timer tests included:

make kselftest target takes:

real    11m50.499s
user    3m25.979s
sys     5m45.433s
Quoted 8 lines

It is creeping up, previous timing was

real 9.41
user 3.55
system 0:24.86

Not concerned yet. Might be getting closer to needing to defining quick vs long test categories.

Yea, the timekeeping tests are particularly rough about how long the run. In some cases we're having to watch for behavior that could be somewhat rare, so we need to watch for a fair amount of time. In some cases we're doing our own calibrations which require a larger amount of time to ensure accuracy. And in other cases, we want to have timers that fire far enough out that any scheduler variance/noise is easy to filter out.

With the destructive tests, which re-run the validation tests repeatedly under different conditions, it ends up being about an hour! So I feel this pain.

But there's also probably some spots where 3 seconds seemed like a good value, but could be shorter. So I'll have to take another look to see if we could reasonably compress some of the intervals we use down. There may also be some spots where we could parallelize the tests across the various clockids.

thanks
-john

#3 lore raw
Quoted 46 lines · John Stultz
Quoted 24 lines · Shuah Khan
Quoted 12 lines · John Stultz

In order to keep the kselftest Makefiles simpler, set the threadtest default values to the ones used in standard run_tests

Cc Shuah Khan <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Richard Cochran <[email protected]>
---
 tools/testing/selftests/timers/threadtest.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Applied to next for 4.1

Some numbers for you with timer tests included:

make kselftest target takes:

real    11m50.499s
user    3m25.979s
sys     5m45.433s
Quoted 8 lines

It is creeping up, previous timing was

real 9.41
user 3.55
system 0:24.86

Not concerned yet. Might be getting closer to needing to defining quick vs long test categories.

Yea, the timekeeping tests are particularly rough about how long the run. In some cases we're having to watch for behavior that could be somewhat rare, so we need to watch for a fair amount of time. In some cases we're doing our own calibrations which require a larger amount of time to ensure accuracy. And in other cases, we want to have timers that fire far enough out that any scheduler variance/noise is easy to filter out.

With the destructive tests, which re-run the validation tests repeatedly under different conditions, it ends up being about an hour! So I feel this pain.

Quoted 6 lines

But there's also probably some spots where 3 seconds seemed like a good value, but could be shorter. So I'll have to take another look to see if we could reasonably compress some of the intervals we use down. There may also be some spots where we could parallelize the tests across the various clockids.

If you can take a look to see which tests can be included in a quick test run vs. longer test run in addition to destructive vs. normal. I will work on adding categories soon. The logic can be isolated in selftest/Makefile and timers/Makefile.

thanks,
-- Shuah

Signature · 5 lines
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978