ARM: at91: at91sam9n12ek: save the environment to a fat file in MMC card

PATCH New Josh Wu 3 participants 3 messages Mar 24, 2015 – Mar 31, 2015 Arm/Microchip (AT91) SoC support

Share & tools

Josh Wu

author

2015-03-24 09:07 UTC #0 lore raw

PATCH v2 1/1 ARM: at91: at91sam9n12ek: save the environment to a fat file in MMC card

Insteading in mmc's raw sectors, this patch will save the environment in a fat file (uboot.env) in mmc card's first FAT patition by default.

If you want to save in mmc's raw sectors, you only need to define CONFIG_ENV_IS_IN_MMC.

Signed-off-by Josh Wu <[email protected]>

---

Changes in v2:
- not remove the code to save env in mmc's raw sectors.
- we can define CONFIG_ENV_IS_IN_MMC to enable raw sectors saving.

 include/configs/at91sam9n12ek.h | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

include/configs/at91sam9n12ek.h +13 -2

index f02fce9..058e0e4 100644
@@ -201,11 +201,22 @@
 #else /* CONFIG_SYS_USE_MMC */
 
 /* bootstrap + u-boot + env + linux in mmc */
-#define CONFIG_ENV_IS_IN_MMC
-/* For FAT system, most cases it should be in the reserved sector */
+
+#ifdef CONFIG_ENV_IS_IN_MMC
+/* Use raw reserved sectors to save environment */
 #define CONFIG_ENV_OFFSET		0x2000
 #define CONFIG_ENV_SIZE			0x1000
 #define CONFIG_SYS_MMC_ENV_DEV		0
+#else
+/* Use file in FAT file to save environment */
+#define CONFIG_ENV_IS_IN_FAT
+#define CONFIG_FAT_WRITE
+#define FAT_ENV_INTERFACE		"mmc"
+#define FAT_ENV_FILE			"uboot.env"
+#define FAT_ENV_DEVICE_AND_PART		"0"
+#define CONFIG_ENV_SIZE			0x4000
+#endif
+
 #define CONFIG_BOOTCOMMAND						\
 	"setenv bootargs ${console} ${mtdparts} ${bootargs_mmc};"	\
 	"fatload mmc 0:1 0x21000000 dtb;"				\

Signature · 1 line

1.9.1

Bo Shen

2015-03-25 03:54 UTC #1 lore raw

PATCH v2 1/1 ARM: at91: at91sam9n12ek: save the environment to a fat file in MMC card

Hi Josh,

Quoted 7 lines · Josh Wu

Insteading in mmc's raw sectors, this patch will save the environment in a fat file (uboot.env) in mmc card's first FAT patition by default.
If you want to save in mmc's raw sectors, you only need to define CONFIG_ENV_IS_IN_MMC.
Signed-off-by Josh Wu <[email protected]>

Thanks for your patch. I think this one is better than v1.

Acked-by Bo Shen <[email protected]>

Quoted 29 lines

---

Changes in v2:
- not remove the code to save env in mmc's raw sectors.
- we can define CONFIG_ENV_IS_IN_MMC to enable raw sectors saving.

  include/configs/at91sam9n12ek.h | 15 +++++++++++++--
  1 file changed, 13 insertions(+), 2 deletions(-)

include/configs/at91sam9n12ek.h +6 -2

index f02fce9..058e0e4 100644
@@ -201,11 +201,22 @@
  #else /* CONFIG_SYS_USE_MMC */
 
  /* bootstrap + u-boot + env + linux in mmc */
-#define CONFIG_ENV_IS_IN_MMC
-/* For FAT system, most cases it should be in the reserved sector */
+
+#ifdef CONFIG_ENV_IS_IN_MMC
+/* Use raw reserved sectors to save environment */
  #define CONFIG_ENV_OFFSET		0x2000
  #define CONFIG_ENV_SIZE			0x1000
  #define CONFIG_SYS_MMC_ENV_DEV		0
+#else
+/* Use file in FAT file to save environment */
+#define CONFIG_ENV_IS_IN_FAT

include/configs/at91sam9n12ek.h line 222

Quoted 10 lines

include/configs/at91sam9n12ek.h +7 -0

+#define CONFIG_FAT_WRITE
+#define FAT_ENV_INTERFACE		"mmc"
+#define FAT_ENV_FILE			"uboot.env"
+#define FAT_ENV_DEVICE_AND_PART		"0"
+#define CONFIG_ENV_SIZE			0x4000
+#endif
+
  #define CONFIG_BOOTCOMMAND						\
  	"setenv bootargs ${console} ${mtdparts} ${bootargs_mmc};"	\
  	"fatload mmc 0:1 0x21000000 dtb;"				\

Best Regards,
Bo Shen

Andreas Bießmann

2015-03-31 23:06 UTC #2 lore raw

PATCH v2 1/1 ARM: at91: at91sam9n12ek: save the environment to a fat file in MMC card

In reply to Josh Wu

Dear Josh Wu,

Quoted 8 lines · Josh Wu

Insteading in mmc's raw sectors, this patch will save the environment in a fat file (uboot.env) in mmc card's first FAT patition by default.
If you want to save in mmc's raw sectors, you only need to define CONFIG_ENV_IS_IN_MMC.
Signed-off-by Josh Wu <[email protected]>
Acked-by Bo Shen <[email protected]>

Quoted 8 lines

---
Changes in v2:
- not remove the code to save env in mmc's raw sectors.
- we can define CONFIG_ENV_IS_IN_MMC to enable raw sectors saving.
include/configs/at91sam9n12ek.h | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)

applied to u-boot-atmel/master, thanks!

Best regards,
Andreas Bie?mann