smack: Fix gcc warning from unused smack_syslog_lock mutex in smackfs.c
Subsystems (2)
PATCH 1/1 smack: Fix gcc warning from unused smack_syslog_lock mutex in smackfs.c
In commit 00f84f3f2e9d088f06722f4351d67f5f577abe22 ("Smack: Make the syslog control configurable") this mutex was added, but the rest of the final commit never actually made use of it, resulting in:
In file included from include/linux/mutex.h:29:0,
from include/linux/notifier.h:13,
from include/linux/memory_hotplug.h:6,
from include/linux/mmzone.h:821,
from include/linux/gfp.h:5,
from include/linux/slab.h:14,
from include/linux/security.h:27,
from security/smack/smackfs.c:21:
security/smack/smackfs.c:63:21: warning: ‘smack_syslog_lock’ defined but not used [-Wunused-variable]
static DEFINE_MUTEX(smack_syslog_lock);
^A git grep shows no other instances/references to smack_syslog_lock. Delete it, assuming that the mutex addition was just a leftover from an earlier work in progress version of the change.
--- security/smack/smackfs.c | 1 - 1 file changed, 1 deletion(-)
security/smack/smackfs.c +0 -1
@@ -61,7 +61,6 @@ enum smk_inos {*/ static DEFINE_MUTEX (smack_cipso_lock);static DEFINE_MUTEX (smack_ambient_lock); -static DEFINE_MUTEX (smack_syslog_lock);static DEFINE_MUTEX (smk_netlbladdr_lock);/*
Signature · 1 line
2.2.1
Quoted 13 lines · Paul Gortmaker
In commit
00f84f3f2e9d088f06722f4351d67f5f577abe22("Smack: Make the syslog control configurable") this mutex was added, but the rest of the final commit never actually made use of it, resulting in:In file included from
include/linux/mutex.h:29:0,
frominclude/linux/notifier.h:13,
frominclude/linux/memory_hotplug.h:6,
frominclude/linux/mmzone.h:821,
frominclude/linux/gfp.h:5,
frominclude/linux/slab.h:14,
frominclude/linux/security.h:27,
fromsecurity/smack/smackfs.c:21:
security/smack/smackfs.c:63:21: warning: ‘smack_syslog_lock’ defined but not used [-Wunused-variable]
Quoted 8 lines
static DEFINE_MUTEX(smack_syslog_lock); ^A git grep shows no other instances/references to
smack_syslog_lock. Delete it, assuming that the mutex addition was just a leftover from an earlier work in progress version of the change.Signed-off-by Paul Gortmaker <[email protected]>
I will take this patch into my smack-for-4.1 branch. Thank you.
Quoted 16 lines
--- security/smack/smackfs.c | 1 - 1 file changed, 1 deletion(-)security/smack/smackfs.c +0
-1@@ -61,7 +61,6 @@ enum smk_inos {*/ static DEFINE_MUTEX (smack_cipso_lock);static DEFINE_MUTEX (smack_ambient_lock); -static DEFINE_MUTEX (smack_syslog_lock);static DEFINE_MUTEX (smk_netlbladdr_lock);/*
Quoted 13 lines · Paul Gortmaker
In commit
00f84f3f2e9d088f06722f4351d67f5f577abe22("Smack: Make the syslog control configurable") this mutex was added, but the rest of the final commit never actually made use of it, resulting in:In file included from
include/linux/mutex.h:29:0,
frominclude/linux/notifier.h:13,
frominclude/linux/memory_hotplug.h:6,
frominclude/linux/mmzone.h:821,
frominclude/linux/gfp.h:5,
frominclude/linux/slab.h:14,
frominclude/linux/security.h:27,
fromsecurity/smack/smackfs.c:21:
security/smack/smackfs.c:63:21: warning: ‘smack_syslog_lock’ defined but not used [-Wunused-variable]
Quoted 8 lines
static DEFINE_MUTEX(smack_syslog_lock); ^A git grep shows no other instances/references to
smack_syslog_lock. Delete it, assuming that the mutex addition was just a leftover from an earlier work in progress version of the change.Signed-off-by Paul Gortmaker <[email protected]>
Applied to git://git.gitorious.org/smack-next/kernel.git#smack-for-4.1
Quoted 16 lines
--- security/smack/smackfs.c | 1 - 1 file changed, 1 deletion(-)security/smack/smackfs.c +0
-1@@ -61,7 +61,6 @@ enum smk_inos {*/ static DEFINE_MUTEX (smack_cipso_lock);static DEFINE_MUTEX (smack_ambient_lock); -static DEFINE_MUTEX (smack_syslog_lock);static DEFINE_MUTEX (smk_netlbladdr_lock);/*