Skip to contentSkip to conversation

Question on ARC's thread_info

DISCUSSION Richard Weinberger 2 participants 2 messages Mar 28, 2015 – Mar 31, 2015 Generic include/asm header files

lore
Share & tools
lore
#0 lore raw

Vineet,

I'm working on a patch series which touches sturct thread_info. ARC's thread_info has the following comment:
* - if the contents of this structure are changed, the assembly constants
* must also be changed

Is this still true? Unless I'm reading the code wrong that case should be handled automatically by the asm-offsets mechanism.
So no manual fixup of magic constants should be needed.

Thanks,
//richard

#1 lore raw
Quoted 10 lines · Richard Weinberger

Vineet,

I'm working on a patch series which touches sturct thread_info. ARC's thread_info has the following comment:
* - if the contents of this structure are changed, the assembly constants
* must also be changed

Is this still true? Unless I'm reading the code wrong that case should be handled automatically by the asm-offsets mechanism.
So no manual fixup of magic constants should be needed.

Yep, I think that is the case too - perhaps the comment is dated when we still had magic constants in code :-)
If not I need to fix it anyways so feel free to change it.

-Vineet