add mcp4728 I2C DAC driver
v2 cover add mcp4728 I2C DAC driver
Dear Krzysztof
I release a V2 version. I hope I have understood all your requests. See below.
Quoted 6 lines
2. Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
I was using branch master git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git but
I saw it was too old. I switched to branch testing.
Quoted 3 lines
6. mcp or MCP? What is this? Proper title is missing... also no description.
I don't know whether using small o capital letters. Usually manufacturers use capital letter to identify the component but kernel drivers use lowercase in code.
Quoted 4 lines
Shouldn't this binding be just merged with existing mcp4725? Are you sure it's not similar device, IOW, are you sure you do not have vref supply?
Unfortunately they are not that similar. MCP4728 has two vref choices:
- Use Vdd (power supply) as Vref
- User Internal 2.048 V Vref source.
Andrea Collamati (2):
dt-bindings: iio: dac: add mcp4728.yaml
iio: add mcp4728 I2C DAC driver
.../bindings/iio/dac/microchip,mcp4728.yaml | 42 +++++++++ drivers/iio/dac/mcp4728.c | 93 +++++++++---------- 2 files changed, 86 insertions(+), 49 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
Signature · 1 line
2.34.1
Quoted 5 lines · Andrea Collamati
Dear Krzysztof
I release a V2 version. I hope I have understood all your requests. See below.
Quoted 7 lines
Quoted 6 lines
2. Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.I was using branch master
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.gitbut
Should be fine. I still doubt that you used it, though. If you got Conor's email, then for sure you should have got my email.
Quoted 7 lines
I saw it was too old. I switched to branch testing.
Quoted 3 lines
6. mcp or MCP? What is this? Proper title is missing... also no description.
I don't know whether using small o capital letters. Usually manufacturers use capital letter to identify the component but kernel drivers use lowercase in code.
Use what is in datasheet.
Quoted 9 lines
Quoted 4 lines
Shouldn't this binding be just merged with existing mcp4725? Are you sure it's not similar device, IOW, are you sure you do not have vref supply?
Unfortunately they are not that similar. MCP4728 has two vref choices:
- Use Vdd (power supply) as Vref
- User Internal 2.048 V Vref source.
Exactly the same as existing mcp4726, so what is the problem?
Best regards,
Krzysztof
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines
Quoted 3 lines
Shouldn't this binding be just merged with existing mcp4725? Are you sure it's not similar device, IOW, are you sure you do not have vref supply?
Unfortunately they are not that similar. MCP4728 has two vref choices:
- Use Vdd (power supply) as Vref
- User Internal 2.048 V Vref source.
Exactly the same as existing mcp4726, so what is the problem?
MCP4726 has 2 separate pins, VDD and VREF that can be both used as external Vref depending on configuration.
MCP4728 has only one external vref pin, VDD pin. The other vref source is internal and fixed to 2.048V.
Furthermore MCP4728 has four independent channels. For each channels it's possible to choose whether
using VDD (External VRef) or 2.048V (Internal Vref).
Best regards
Andrea
Quoted 11 lines · Andrea Collamati
Quoted 9 lines · Krzysztof Kozlowski
Quoted 8 lines
Quoted 3 lines
Shouldn't this binding be just merged with existing mcp4725? Are you sure it's not similar device, IOW, are you sure you do not have vref supply?
Unfortunately they are not that similar. MCP4728 has two vref choices:
- Use Vdd (power supply) as Vref
- User Internal 2.048 V Vref source.
Exactly the same as existing mcp4726, so what is the problem?
Quoted 7 lines
MCP4726 has 2 separate pins, VDD and VREF that can be both used as external Vref depending on configuration.
MCP4728 has only one external vref pin, VDD pin. The other vref source is internal and fixed to 2.048V.
Furthermore MCP4728 has four independent channels. For each channels it's possible to choose whether
using VDD (External VRef) or 2.048V (Internal Vref).
Indeed, so new binding makes sense.
Best regards,
Krzysztof