Skip to contentSkip to conversation

systemd: stop [email protected] before lvm2-lvmetad.service

PATCH New Michael Lass 2 participants 2 messages Mar 29, 2015 – Mar 31, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 systemd: stop [email protected] before lvm2-lvmetad.service

When lvm2-pvscan at .service and lvm2-lvmetad.service are scheduled to be stopped lvm2-pvscan at .service should be stopped first since pvscan uses lvmetad.

This is especially important if lvm2-lvmetad.socket is also scheduled to be stopped as in this case connection requests are suppressed causing pvscan to fail.

---
 scripts/lvm2_pvscan_systemd_red_hat at .service.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lvm2_pvscan_systemd_red_hat at .service.in +1 -1
index 7d3b291..03651d5 100644
@@ -4,7 +4,7 @@ Documentation=man:pvscan(8)
 DefaultDependencies=no
 BindsTo=dev-block-%i.device
 Requires=lvm2-lvmetad.socket
-After=lvm2-lvmetad.socket
+After=lvm2-lvmetad.socket lvm2-lvmetad.service
 Before=shutdown.target
 Conflicts=shutdown.target
 
Signature · 1 line
2.3.4
#1 lore raw

PATCH 1/1 systemd: stop [email protected] before lvm2-lvmetad.service

Quoted 16 lines · Michael Lass

When lvm2-pvscan at .service and lvm2-lvmetad.service are scheduled to be stopped lvm2-pvscan at .service should be stopped first since pvscan uses lvmetad.

This is especially important if lvm2-lvmetad.socket is also scheduled to be stopped as in this case connection requests are suppressed causing pvscan to fail.

---
 scripts/lvm2_pvscan_systemd_red_hat at .service.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lvm2_pvscan_systemd_red_hat at .service.in +0 -0
index 7d3b291..03651d5 100644

scripts/lvm2_pvscan_systemd_red_hat at .service.in Documentation=man:pvscan(8) · line 10

Quoted 8 lines
scripts/lvm2_pvscan_systemd_red_hat at .service.in +1 -1
@@ -4,7 +4,7 @@ Documentation=man:pvscan(8)
 DefaultDependencies=no
 BindsTo=dev-block-%i.device
 Requires=lvm2-lvmetad.socket
-After=lvm2-lvmetad.socket
+After=lvm2-lvmetad.socket lvm2-lvmetad.service
 Before=shutdown.target
 Conflicts=shutdown.target
 

Applied. Thanks!

https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=666738d57a6e6b4005030995a9641933c1a54e9d

Signature · 1 line
Peter