Remove extra check for ld-linux.so.3 in strcmp
Hi Mark,
there is one typo error in this:-
http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/commit/?h=cross_prelink_staging&id=fd99a47124b1f1141f2afe4e87da7cb209cc2927
+ src/get.c: Remove extra checkf ro ld-linux.so.3 in strcmp *** check for *****
Thanks
--------------------------------------
Hi Mark,
Sorry for missing ID in Signed-off-by: Maninder Singh
Signed-off-by: Maninder Singh
I suggested that change just to remove redundat code. This looks Ok to me
http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/commit/?h=cross_prelink_staging&id=fd99a47124b1f1141f2afe4e87da7cb209cc2927
Thanks a lot
Maninder Singh
Quoted 1 line
Hmm, I never saw the original email (or thread).
(I have no record of ever receiving the original email. How odd...)
Quoted 4 lines
What is the context for this, simply that there are multiple ld-linux.do.3 in the same check and remove one or the other is more efficient?
(I suspect it will be optimized out, but I can make the change quickly enough.)
I have merged the change, slightly different format.
See:
This is in the staging area.
Maninder if this is ok, I'm more then happy to add your signed-off-by line to the commit before moving it into the cross_prelink branch.
Thanks!
--Mark
Quoted 60 lines
--Mark
Quoted 56 lines · Khem Raj
Quoted 21 lines · On Mar 30, 2015, at 8:14 PM, Maninder Singh >>> > wrote:
Hi,
From
05ab779af24baef957972aa1d2a9e9d29212cc4cMon Sep 17 00:00:00 2001
From: Maninder Singh >
Date: Thu, 19 Mar 2015 03:02:59 +0530
Subject: [PATCH 1/1] Remove extra check for ld-linux.so.3 in strcmpif (! strcmp (soname, "ld-linux.so.2")
|| ! strcmp (soname, "ld-linux.so.3") ------------------------> || ! strcmp (soname, "ld.so.1") || ! strcmp (soname, "ld-linux-ia64.so.2") || ! strcmp (soname, "ld-linux-x86-64.so.2") || ! strcmp (soname, "ld64.so.1") || ! strcmp (soname, "ld-linux.so.3") ---------------------------> redundant code || ! strcmp (soname, "ld-linux-armhf.so.3"))Quoted 2 lines
Signed-off-by Maninder Singhuse First Last
Quoted 29 lines
---
src/get.c| 1 -1 files changed, 0 insertions(+), 1 deletions(-)src/get.c +0
-1@@ -35,7 +35,6 @@ is_ldso_soname (const char *soname) || ! strcmp (soname, "ld-linux-ia64.so.2") || ! strcmp (soname, "ld-linux-x86-64.so.2") || ! strcmp (soname, "ld64.so.1") - || ! strcmp (soname, "ld-linux.so.3") || ! strcmp (soname, "ld-linux-armhf.so.3"))return 1 ;return 0 ;Signature · 13 lines
1.7.1 Thanks and Regards, Maninder Singh <201503310844012_QKNMBDIF.gif> -- _______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto
Quoted 5 lines · Maninder Singh
Hi Mark,
there is one typo error in this:-
http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/commit/?h=cross_prelink_staging&id=fd99a47124b1f1141f2afe4e87da7cb209cc2927
+src/get.c: Remove extra checkf ro ld-linux.so.3 in strcmp *** check for *****
Thanks for noticing. I'll get that fixed.
--Mark
Quoted 97 lines
Thanks
--------------------------------------Hi Mark,
Sorry for missing ID in Signed-off-by: Maninder Singh
Signed-off-by: Maninder SinghI suggested that change just to remove redundat code. This looks Ok to me
http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/commit/?h=cross_prelink_staging&id=fd99a47124b1f1141f2afe4e87da7cb209cc2927Thanks a lot
Maninder Singh
Quoted 1 line
Hmm, I never saw the original email (or thread).
(I have no record of ever receiving the original email. How odd...)
Quoted 4 lines
What is the context for this, simply that there are multiple ld-linux.do.3 in the same check and remove one or the other is more efficient?
(I suspect it will be optimized out, but I can make the change quickly enough.)
I have merged the change, slightly different format.
See:
This is in the staging area.
Maninder if this is ok, I'm more then happy to add your signed-off-by line to the commit before moving it into the
cross_prelinkbranch.Thanks!
--MarkQuoted 59 lines
--Mark
Quoted 56 lines · Khem Raj
Quoted 21 lines · On Mar 30, 2015, at 8:14 PM, Maninder Singh >>> > wrote:
Hi,
From
05ab779af24baef957972aa1d2a9e9d29212cc4cMon Sep 17 00:00:00 2001
From: Maninder Singh >
Date: Thu, 19 Mar 2015 03:02:59 +0530
Subject: [PATCH 1/1] Remove extra check for ld-linux.so.3 in strcmpif (! strcmp (soname, "ld-linux.so.2")
|| ! strcmp (soname, "ld-linux.so.3") ------------------------> || ! strcmp (soname, "ld.so.1") || ! strcmp (soname, "ld-linux-ia64.so.2") || ! strcmp (soname, "ld-linux-x86-64.so.2") || ! strcmp (soname, "ld64.so.1") || ! strcmp (soname, "ld-linux.so.3") ---------------------------> redundant code || ! strcmp (soname, "ld-linux-armhf.so.3"))Quoted 2 lines
Signed-off-by Maninder Singhuse First Last
Quoted 29 lines
---
src/get.c| 1 -1 files changed, 0 insertions(+), 1 deletions(-)src/get.c +0
-1@@ -35,7 +35,6 @@ is_ldso_soname (const char *soname) || ! strcmp (soname, "ld-linux-ia64.so.2") || ! strcmp (soname, "ld-linux-x86-64.so.2") || ! strcmp (soname, "ld64.so.1") - || ! strcmp (soname, "ld-linux.so.3") || ! strcmp (soname, "ld-linux-armhf.so.3"))return 1 ;return 0 ;Signature · 13 lines
1.7.1 Thanks and Regards, Maninder Singh <201503310844012_QKNMBDIF.gif> -- _______________________________________________ yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/yocto