Skip to contentSkip to conversation

Add package sl

PATCH New Jens Rosenboom 4 participants 5 messages Apr 1, 2015 – Apr 3, 2015

lore
Share & tools
lore

Jens Rosenboom

author
#0 lore raw

PATCH 1/1 Add package sl

SL (Steam Locomotive) runs across your terminal when you type "sl" as you meant to type "ls". It's just a joke command, and not useful at all.

Might want to depend on BR2_PACKAGE_NCURSES_WCHAR even in order to get terminfo for xterm-256color, but I'm not sure whether that should be just optional.

Signed-off-by Jens Rosenboom <[email protected]>
---
 package/Config.in    |  1 +
 package/sl/Config.in |  9 +++++++++
 package/sl/sl.mk     | 20 ++++++++++++++++++++
 3 files changed, 30 insertions(+)
 create mode 100644 package/sl/Config.in
 create mode 100644 package/sl/sl.mk
package/Config.in +1 -0
index d6a5ad3..08475fe 100644
@@ -183,6 +183,7 @@ menu "Games"
 	source "package/opentyrian-data/Config.in"
 	source "package/prboom/Config.in"
 	source "package/rubix/Config.in"
+	source "package/sl/Config.in"
 endmenu
 
 menu "Graphic libraries and applications (graphic/text)"
package/sl/Config.in new file +9 -0
new file mode 100644
index 0000000..e387ea5
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_SL
+	bool "sl"
+        # Note(JR): Still need to check proper depends
+	depends on BR2_PACKAGE_NCURSES
+	help
+	  SL (Steam Locomotive) runs across your terminal when you type "sl" 
+	  as you meant to type "ls". It's just a joke command, and not useful at all.
+
+	  https://github.com/mtoyoda/sl
package/sl/sl.mk new file +20 -0
new file mode 100644
index 0000000..9ad98cb
@@ -0,0 +1,20 @@
+################################################################################
+#
+# sl
+#
+################################################################################
+
+SL_VERSION = 5.02
+SL_SITE = $(call github,mtoyoda,sl,$(SL_VERSION))
+SL_LICENSE = Unclear
+SL_LICENSE_FILES = LICENSE
+
+define SL_BUILD_CMDS
+	$(MAKE) -C $(@D) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)"
+endef
+
+define SL_INSTALL_TARGET_CMDS
+	$(INSTALL) -D $(@D)/sl $(TARGET_DIR)/usr/bin/sl
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 Add package sl

Dear Jens Rosenboom,

2015-04-01 11:08 GMT+02:00 Jens Rosenboom <[email protected]>:

Quoted 60 lines

SL (Steam Locomotive) runs across your terminal when you type "sl" as you meant to type "ls". It's just a joke command, and not useful at all.

Might want to depend on BR2_PACKAGE_NCURSES_WCHAR even in order to get terminfo for xterm-256color, but I'm not sure whether that should be just optional.

Signed-off-by Jens Rosenboom <[email protected]>
---
 package/Config.in    |  1 +
 package/sl/Config.in |  9 +++++++++
 package/sl/sl.mk     | 20 ++++++++++++++++++++
 3 files changed, 30 insertions(+)
 create mode 100644 package/sl/Config.in
 create mode 100644 package/sl/sl.mk
package/Config.in +1 -0
index d6a5ad3..08475fe 100644
@@ -183,6 +183,7 @@ menu "Games"
        source "package/opentyrian-data/Config.in"
        source "package/prboom/Config.in"
        source "package/rubix/Config.in"
+       source "package/sl/Config.in"
 endmenu
 
 menu "Graphic libraries and applications (graphic/text)"
package/sl/Config.in new file +9 -0
new file mode 100644
index 0000000..e387ea5
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_SL
+       bool "sl"
+        # Note(JR): Still need to check proper depends
+       depends on BR2_PACKAGE_NCURSES
+       help
+         SL (Steam Locomotive) runs across your terminal when you type "sl"
+         as you meant to type "ls". It's just a joke command, and not useful at all.
+
+         https://github.com/mtoyoda/sl
package/sl/sl.mk new file +11 -0
new file mode 100644
index 0000000..9ad98cb
@@ -0,0 +1,20 @@
+################################################################################
+#
+# sl
+#
+################################################################################
+
+SL_VERSION = 5.02
+SL_SITE = $(call github,mtoyoda,sl,$(SL_VERSION))
+SL_LICENSE = Unclear
+SL_LICENSE_FILES = LICENSE
+

package/sl/sl.mk

Quoted 10 lines
package/sl/sl.mk new file +9 -1
+define SL_BUILD_CMDS
+       $(MAKE) -C $(@D) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)"
+endef
+
+define SL_INSTALL_TARGET_CMDS
+       $(INSTALL) -D $(@D)/sl $(TARGET_DIR)/usr/bin/sl
+endef
+
+$(eval $(generic-package))
--

I want it now! Tomorrow will be too late!

Quoted 6 lines

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#2 lore raw

PATCH 1/1 Add package sl

Hi Angelo,

Quoted 11 lines · Angelo Compagnucci

Dear Jens Rosenboom,

2015-04-01 11:08 GMT+02:00 Jens Rosenboom <[email protected]>:

Quoted 8 lines

SL (Steam Locomotive) runs across your terminal when you type "sl" as you meant to type "ls". It's just a joke command, and not useful at all.

Might want to depend on BR2_PACKAGE_NCURSES_WCHAR even in order to get terminfo for xterm-256color, but I'm not sure whether that should be just optional.

Signed-off-by Jens Rosenboom <[email protected]>

[snip]

Quoted 3 lines
Quoted 1 line

--

I want it now! Tomorrow will be too late!

Well, then review the patch and either give some comments and/or add your
Reviewed-by, Tested-by or Acked-by tags.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 Add package sl

Dear Arnout Vandecappelle,

2015-04-01 23:12 GMT+02:00 Arnout Vandecappelle <[email protected]>:

Quoted 13 lines

Hi Angelo,

Quoted 10 lines · Angelo Compagnucci

Dear Jens Rosenboom,

2015-04-01 11:08 GMT+02:00 Jens Rosenboom <[email protected]>:

Quoted 7 lines

SL (Steam Locomotive) runs across your terminal when you type "sl" as you meant to type "ls". It's just a joke command, and not useful at all.

Might want to depend on BR2_PACKAGE_NCURSES_WCHAR even in order to get terminfo for xterm-256color, but I'm not sure whether that should be just optional.

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Jens Rosenboom <[email protected]>

[snip]

Quoted 3 lines
Quoted 1 line

--

I want it now! Tomorrow will be too late!

Well, then review the patch and either give some comments and/or add your
Reviewed-by, Tested-by or Acked-by tags.

Honestly I thought it was an April fools! Why add an unuseful command to buildroot just the first of April after all! Lol!

Sincerely, Angelo

Quoted 11 lines

Regards,
Arnout

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
Applied
#4 lore raw

PATCH 1/1 Add package sl

In reply to Jens Rosenboom

Dear Jens Rosenboom,

Quoted 7 lines · Jens Rosenboom

SL (Steam Locomotive) runs across your terminal when you type "sl" as you meant to type "ls". It's just a joke command, and not useful at all.

Might want to depend on BR2_PACKAGE_NCURSES_WCHAR even in order to get terminfo for xterm-256color, but I'm not sure whether that should be just optional.

Quoted 8 lines
Signed-off-by Jens Rosenboom <[email protected]>
---
 package/Config.in    |  1 +
 package/sl/Config.in |  9 +++++++++
 package/sl/sl.mk     | 20 ++++++++++++++++++++
 3 files changed, 30 insertions(+)
 create mode 100644 package/sl/Config.in
 create mode 100644 package/sl/sl.mk

Thanks, applied, after doing a number of changes:

[Thomas:
- Change "depends on BR2_PACKAGE_NCURSES" to "select BR2_PACKAGE_NCURSES".
- Rewrap Config.in help text.
- Remove comment in help text about the need to check dependencies, there's nothing to be done really.
- Change the license from "Unclear" to "Custom".
- Use $(TARGET_CONFIGURE_OPTS instead of passing CC and CFLAGS explicitly.
- Pass '-m 0755' when doing the $(INSTALL)
- Add ncurses to SL_DEPENDENCIES.]

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com