Staging: comedi: addi_apci_1564: Delete whitespace

PATCH In review Charlie Wong Super 3 participants 6 messages Mar 31, 2015 – Apr 2, 2015 Staging

lore

Share & tools

lore

Charlie Wong Super

author

2015-03-31 06:08 UTC #0 lore raw

PATCH v3 1/1 Staging: comedi: addi_apci_1564: Delete whitespace

Fix the checkpatch.pl WARNING: line over 80 characters

Signed-off-by Charlie Wong Super <[email protected]>

---
Changes in v2:
edit the commit message, make it clear!
Changes in v3:
about the commit and patch style problem!

 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

drivers/staging/comedi/drivers/addi_apci_1564.c +6 -6

index c481c48..dd335e8 100644
@@ -106,12 +106,12 @@
 #define APCI1564_COUNTER(x)			((x) * 0x20)
 
 struct apci1564_private {
-	unsigned long eeprom;		/* base address of EEPROM register */
-	unsigned long timer;		/* base address of 12-bit timer */
-	unsigned long counters;		/* base address of 32-bit counters */
-	unsigned int mode1;		/* riding-edge/high level channels */
-	unsigned int mode2;		/* falling-edge/low level channels */
-	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
+	unsigned long eeprom;		/*base address of EEPROM register*/
+	unsigned long timer;		/*base address of 12-bit timer*/
+	unsigned long counters;		/*base address of 32-bit counters*/
+	unsigned int mode1;		/*riding-edge/high level channels*/
+	unsigned int mode2;		/*falling-edge/low level channels*/
+	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/
 	struct task_struct *tsk_current;
 };

Signature · 1 line

1.9.1

Julia Lawall

2015-03-31 06:12 UTC #1 lore raw

Looks better :)

julia

Quoted 45 lines · Charlie Wong Super

Fix the checkpatch.pl WARNING: line over 80 characters

Signed-off-by Charlie Wong Super <[email protected]>

---
Changes in v2:
edit the commit message, make it clear!
Changes in v3:
about the commit and patch style problem!

 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

drivers/staging/comedi/drivers/addi_apci_1564.c +6 -6

index c481c48..dd335e8 100644
@@ -106,12 +106,12 @@
 #define APCI1564_COUNTER(x)			((x) * 0x20)
 
 struct apci1564_private {
-	unsigned long eeprom;		/* base address of EEPROM register */
-	unsigned long timer;		/* base address of 12-bit timer */
-	unsigned long counters;		/* base address of 32-bit counters */
-	unsigned int mode1;		/* riding-edge/high level channels */
-	unsigned int mode2;		/* falling-edge/low level channels */
-	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
+	unsigned long eeprom;		/*base address of EEPROM register*/
+	unsigned long timer;		/*base address of 12-bit timer*/
+	unsigned long counters;		/*base address of 32-bit counters*/
+	unsigned int mode1;		/*riding-edge/high level channels*/
+	unsigned int mode2;		/*falling-edge/low level channels*/
+	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/
 	struct task_struct *tsk_current;
 };

Signature · 8 lines

1.9.1

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150331060813.GA23522%40ThinkPad.
For more options, visit https://groups.google.com/d/optout.

Charlie WONG Super

author

2015-03-31 06:18 UTC #2 lore raw

Quoted 11 lines · Julia Lawall

Looks better :)
julia
Quoted 3 lines · Charlie Wong Super
Be happy, Thanks for your help!
I think I need to do much more, to be familar with this style! ^_^ charlie

Greg KH

maintainer

2015-04-01 15:37 UTC #3 lore raw

In reply to Charlie Wong Super

Quoted 22 lines · Charlie Wong Super

Fix the checkpatch.pl WARNING: line over 80 characters
Signed-off-by Charlie Wong Super <[email protected]>
---
Changes in v2:
edit the commit message, make it clear!
Changes in v3:
about the commit and patch style problem!
 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -2
index c481c48..dd335e8 100644
@@ -106,12 +106,12 @@
 #define APCI1564_COUNTER(x)			((x) * 0x20)
 
 struct apci1564_private {
-	unsigned long eeprom;		/* base address of EEPROM register */
-	unsigned long timer;		/* base address of 12-bit timer */

drivers/staging/comedi/drivers/addi_apci_1564.c line 114

Quoted 10 lines

drivers/staging/comedi/drivers/addi_apci_1564.c +6 -4

-	unsigned long counters;		/* base address of 32-bit counters */
-	unsigned int mode1;		/* riding-edge/high level channels */
-	unsigned int mode2;		/* falling-edge/low level channels */
-	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
+	unsigned long eeprom;		/*base address of EEPROM register*/
+	unsigned long timer;		/*base address of 12-bit timer*/
+	unsigned long counters;		/*base address of 32-bit counters*/
+	unsigned int mode1;		/*riding-edge/high level channels*/
+	unsigned int mode2;		/*falling-edge/low level channels*/
+	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/

That makes the code look worse, sorry, we can't take this. It's correct to have ' ' in comments after and before the '*' character.

thanks,

greg k-h

Charlie WONG Super

author

2015-04-02 06:32 UTC #4 lore raw

Quoted 36 lines · Greg KH

Quoted 22 lines · Charlie Wong Super
Fix the checkpatch.pl WARNING: line over 80 characters
Signed-off-by Charlie Wong Super <[email protected]>
---
Changes in v2:
edit the commit message, make it clear!
Changes in v3:
about the commit and patch style problem!
  drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -2
index c481c48..dd335e8 100644
@@ -106,12 +106,12 @@
  #define APCI1564_COUNTER(x)			((x) * 0x20)
 
  struct apci1564_private {
-	unsigned long eeprom;		/* base address of EEPROM register */
-	unsigned long timer;		/* base address of 12-bit timer */
drivers/staging/comedi/drivers/addi_apci_1564.c line 114
Quoted 10 lines
drivers/staging/comedi/drivers/addi_apci_1564.c +6 -4
-	unsigned long counters;		/* base address of 32-bit counters */
-	unsigned int mode1;		/* riding-edge/high level channels */
-	unsigned int mode2;		/* falling-edge/low level channels */
-	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
+	unsigned long eeprom;		/*base address of EEPROM register*/
+	unsigned long timer;		/*base address of 12-bit timer*/
+	unsigned long counters;		/*base address of 32-bit counters*/
+	unsigned int mode1;		/*riding-edge/high level channels*/
+	unsigned int mode2;		/*falling-edge/low level channels*/
+	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/
That makes the code look worse, sorry, we can't take this. It's correct to have ' ' in comments after and before the '*' character.

Quoted 3 lines

thanks,
greg k-h

ok, got it, I will do much more work!
Thanks for your review!

Charlie WONG Super

author

2015-04-02 10:10 UTC #5 lore raw

PATCH v4 1/1 Staging: comedi: addi_apci_1564: Delete a tap

In reply to Greg KH

From: Charlie Wong Super <[email protected]>

Fix the checkpatch.pl WARNING: line over 80 characters

Signed-off-by Charlie Wong Super <[email protected]>

---
Changes in v2:
-edit the commit message, make it clear
Changes in v3:
-about the commit and patch style problem
Changes in v4:
-delete a tap, keep the ' ' character before and after the * character

 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

drivers/staging/comedi/drivers/addi_apci_1564.c +6 -6

index c481c48..c1d0021 100644
@@ -106,12 +106,12 @@
 #define APCI1564_COUNTER(x)			((x) * 0x20)
 
 struct apci1564_private {
-	unsigned long eeprom;		/* base address of EEPROM register */
-	unsigned long timer;		/* base address of 12-bit timer */
-	unsigned long counters;		/* base address of 32-bit counters */
-	unsigned int mode1;		/* riding-edge/high level channels */
-	unsigned int mode2;		/* falling-edge/low level channels */
-	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
+	unsigned long eeprom;	/* base address of EEPROM register */
+	unsigned long timer;	/* base address of 12-bit timer */
+	unsigned long counters;	/* base address of 32-bit counters */
+	unsigned int mode1;	/* riding-edge/high level channels */
+	unsigned int mode2;	/* falling-edge/low level channels */
+	unsigned int ctrl;	/* interrupt mode OR (edge) . AND (level) */
 	struct task_struct *tsk_current;
 };

Signature · 1 line

1.9.1