Skip to contentSkip to conversation

i2c: mvtwsi: disable i2c slave also on Armada 8k

PATCH New Baruch Siach 2 participants 2 messages Oct 1, 2020 – Nov 28, 2020 I2C

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: mvtwsi: disable i2c slave also on Armada 8k

The hidden I2C slave is also present on the Armada 8k AP806. Testing shows that this I2C slave causes the same issues as Armada 38x. Disabling that I2C slave fixes all these issues.

I2C blocks on the Armada 8k CP110 are not affected.

Extend the I2C slave disable to Armada 8k as well.

---
 drivers/i2c/mvtwsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/i2c/mvtwsi.c +2 -1
index fdb8fd42e5c0..14c594d648ba 100644
@@ -823,7 +823,8 @@ static int mvtwsi_i2c_bind(struct udevice *bus)
 	struct mvtwsi_registers *twsi = dev_read_addr_ptr(bus);
 
 	/* Disable the hidden slave in i2c0 of these platforms */
-	if ((IS_ENABLED(CONFIG_ARMADA_38X) || IS_ENABLED(CONFIG_ARCH_KIRKWOOD))
+	if ((IS_ENABLED(CONFIG_ARMADA_38X) || IS_ENABLED(CONFIG_ARCH_KIRKWOOD)
+				|| IS_ENABLED(CONFIG_ARMADA_8K))
 			&& bus->req_seq == 0)
 		twsi_disable_i2c_slave(twsi);
 
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 i2c: mvtwsi: disable i2c slave also on Armada 8k

Hello Baruch,

Am 01.10.20 um 13:49 schrieb Baruch Siach:

Quoted 6 lines

The hidden I2C slave is also present on the Armada 8k AP806. Testing shows that this I2C slave causes the same issues as Armada 38x. Disabling that I2C slave fixes all these issues.

I2C blocks on the Armada 8k CP110 are not affected.

Quoted 7 lines

Extend the I2C slave disable to Armada 8k as well.

---
 drivers/i2c/mvtwsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied to u-boot-i2c.git

thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de