Skip to contentSkip to conversation

iMX: Fix compilation error when enabling SECURE_BOOT

PATCH New Gaurav Rana 3 participants 3 messages Apr 6, 2015 – Apr 22, 2015

lore
Share & tools
lore

Gaurav Rana

author
#0 lore raw

PATCH v2 1/1 iMX: Fix compilation error when enabling SECURE_BOOT

Move the compilation of file fsl_validate.c in MACRO CONFIG_CMD_ESBC_VALIDATE. This file should be compiled only when the above MACRO is defined

This caused a break in compilation of iMX platforms when compiling for SECURE_BOOT

Signed-off-by Gaurav Rana <[email protected]>

---
Changes in V2:
Corrected the commit message.

 board/freescale/common/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
board/freescale/common/Makefile +1 -2
index 7181cac..87d0578 100644
@@ -74,8 +74,7 @@ obj-$(CONFIG_P5040DS)	+= p_corenet/
 obj-$(CONFIG_LS102XA_NS_ACCESS)	+= ns_access.o
 
 ifdef CONFIG_SECURE_BOOT
-obj-y += fsl_validate.o
-obj-$(CONFIG_CMD_ESBC_VALIDATE) += cmd_esbc_validate.o
+obj-$(CONFIG_CMD_ESBC_VALIDATE) += fsl_validate.o cmd_esbc_validate.o
 endif
 
 endif
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH v2 1/1 iMX: Fix compilation error when enabling SECURE_BOOT

Hi Gaurav,

Quoted 18 lines · Gaurav Rana

Move the compilation of file fsl_validate.c in MACRO CONFIG_CMD_ESBC_VALIDATE. This file should be compiled only when the above MACRO is defined

This caused a break in compilation of iMX platforms when compiling for SECURE_BOOT

Signed-off-by Gaurav Rana <[email protected]>

---
Changes in V2:
Corrected the commit message.

  board/freescale/common/Makefile | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
board/freescale/common/Makefile +0 -0
index 7181cac..87d0578 100644

board/freescale/common/Makefile obj-$(CONFIG_P5040DS) += p_corenet/ · line 80

Quoted 9 lines
board/freescale/common/Makefile +1 -2
@@ -74,8 +74,7 @@ obj-$(CONFIG_P5040DS)	+= p_corenet/
  obj-$(CONFIG_LS102XA_NS_ACCESS)	+= ns_access.o
 
  ifdef CONFIG_SECURE_BOOT
-obj-y += fsl_validate.o
-obj-$(CONFIG_CMD_ESBC_VALIDATE) += cmd_esbc_validate.o
+obj-$(CONFIG_CMD_ESBC_VALIDATE) += fsl_validate.o cmd_esbc_validate.o
  endif
 
  endif

This fixes the issue. Tested on iMX6q and iMX6sx.

Regards,
Ulises Cardenas

#2 lore raw

PATCH v2 1/1 iMX: Fix compilation error when enabling SECURE_BOOT

In reply to Gaurav Rana
Quoted 7 lines · Gaurav Rana

Move the compilation of file fsl_validate.c in MACRO CONFIG_CMD_ESBC_VALIDATE. This file should be compiled only when the above MACRO is defined

This caused a break in compilation of iMX platforms when compiling for SECURE_BOOT

Signed-off-by Gaurav Rana <[email protected]>

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================