Skip to contentSkip to conversation

mx53loco: Disable printing cpuinfo

PATCH New Fabio Estevam 4 participants 5 messages Apr 6, 2015 – Apr 8, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx53loco: Disable printing cpuinfo

Since commit 32df39c741788e ("mx5: fix get_reset_cause") we have the following boot messages on a mx53qsb:

U-Boot 2015.04-rc5-00029-gd68df02 (Apr 06 2015 - 11:15:39)

CPU:   Freescale i.MX53 rev2.1 at 800 MHz                                       
Reset cause: POR                                                                
Board: MX53 LOCO                                                                
I2C:   ready                                                                    
DRAM:  1 GiB                                                                    
MMC:   FSL_SDHC: 0, FSL_SDHC: 1                                                 
In:    serial                                                                   
Out:   serial                                                                   
Err:   serial                                                                   
CPU:   Freescale i.MX53 rev2.1 at 1000 MHz                                      
Reset cause: unknown reset                                                      
Net:   FEC [PRIME] 

The CPU and Reset cause lines appear twice.

Initially mx53 boots at 800MHz, then at a later point the PMIC is configured via I2C to raise the CPU voltage so that it can run at 1GHz.

To avoid such misleading double printings, disable printing cpu info for now.

---
 board/freescale/mx53loco/mx53loco.c | 1 -
 include/configs/mx53loco.h          | 2 --
 2 files changed, 3 deletions(-)
board/freescale/mx53loco/mx53loco.c +0 -1
index 9ece6ec..1298788 100644
@@ -389,7 +389,6 @@ int board_late_init(void)
 {
 	if (!power_init())
 		clock_1GHz();
-	print_cpuinfo();
 
 	return 0;
 }
include/configs/mx53loco.h +0 -2
index 8f92234..3551e02 100644
@@ -24,8 +24,6 @@
 
 #define CONFIG_SYS_GENERIC_BOARD
 
-#define CONFIG_DISPLAY_CPUINFO
-
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(10 * 1024 * 1024)
 
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 mx53loco: Disable printing cpuinfo

Quoted 27 lines

-----Original Message-----
From: Fabio Estevam [mailto:fabio.estevam at freescale.com]
Sent: Monday, April 06, 2015 10:23 PM
To: sbabic at denx.de
Cc: Liu Hui-R64343; u-boot at lists.denx.de; Estevam Fabio-R49496
Subject: [PATCH] mx53loco: Disable printing cpuinfo

Since commit 32df39c741788e ("mx5: fix get_reset_cause") we have the following boot messages on a mx53qsb:

U-Boot 2015.04-rc5-00029-gd68df02 (Apr 06 2015 - 11:15:39)

CPU:   Freescale i.MX53 rev2.1 at 800 MHz
Reset cause: POR
Board: MX53 LOCO
I2C:   ready
DRAM:  1 GiB
MMC:   FSL_SDHC: 0, FSL_SDHC: 1
In:    serial
Out:   serial
Err:   serial
CPU:   Freescale i.MX53 rev2.1 at 1000 MHz
Reset cause: unknown reset
Net:   FEC [PRIME]

The CPU and Reset cause lines appear twice.

Quoted 7 lines

Initially mx53 boots at 800MHz, then at a later point the PMIC is configured via I2C to raise the CPU voltage so that it can run at 1GHz.

To avoid such misleading double printings, disable printing cpu info for now.

Quoted 32 lines
---
 board/freescale/mx53loco/mx53loco.c | 1 -
 include/configs/mx53loco.h          | 2 --
 2 files changed, 3 deletions(-)
board/freescale/mx53loco/mx53loco.c +0 -1
index 9ece6ec..1298788 100644
@@ -389,7 +389,6 @@ int board_late_init(void)  {
 	if (!power_init())
 		clock_1GHz();
-	print_cpuinfo();
 
 	return 0;
 }
include/configs/mx53loco.h +0 -3
index 8f92234..3551e02 100644
@@ -24,8 +24,6 @@
 
 #define CONFIG_SYS_GENERIC_BOARD
 
-#define CONFIG_DISPLAY_CPUINFO
-
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(10 * 1024 * 1024)
 
--

1.9.1

#2 lore raw

PATCH 1/1 mx53loco: Disable printing cpuinfo

Tom/Stefano,

Quoted 30 lines · Hui.Liu at freescale.com
Quoted 30 lines

-----Original Message-----
From: Fabio Estevam [mailto:fabio.estevam at freescale.com]
Sent: Monday, April 06, 2015 10:23 PM
To: sbabic at denx.de
Cc: Liu Hui-R64343; u-boot at lists.denx.de; Estevam Fabio-R49496
Subject: [PATCH] mx53loco: Disable printing cpuinfo

Since commit 32df39c741788e ("mx5: fix get_reset_cause") we have the following boot messages on a mx53qsb:

U-Boot 2015.04-rc5-00029-gd68df02 (Apr 06 2015 - 11:15:39)

CPU:   Freescale i.MX53 rev2.1 at 800 MHz
Reset cause: POR
Board: MX53 LOCO
I2C:   ready
DRAM:  1 GiB
MMC:   FSL_SDHC: 0, FSL_SDHC: 1
In:    serial
Out:   serial
Err:   serial
CPU:   Freescale i.MX53 rev2.1 at 1000 MHz
Reset cause: unknown reset
Net:   FEC [PRIME]

The CPU and Reset cause lines appear twice.

Initially mx53 boots at 800MHz, then at a later point the PMIC is configured via I2C to raise the CPU voltage so that it can run at 1GHz.

Quoted 6 lines
Quoted 4 lines

To avoid such misleading double printings, disable printing cpu info for now.

Can we have this one applied for 2015.04? It fixes some bogus boot logs.

Thanks,

Fabio Estevam

#3 lore raw

PATCH 1/1 mx53loco: Disable printing cpuinfo

Hi Fabio,

Quoted 10 lines · Fabio Estevam

Tom/Stefano,

On Tue, Apr 7, 2015 at 12:46 AM, Hui.Liu at freescale.com

Quoted 3 lines
Quoted 1 line

Can we have this one applied for 2015.04? It fixes some bogus boot logs.

I pick it up now.

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#4 lore raw

PATCH 1/1 mx53loco: Disable printing cpuinfo

In reply to Fabio Estevam
Quoted 20 lines · Fabio Estevam

Since commit 32df39c741788e ("mx5: fix get_reset_cause") we have the following boot messages on a mx53qsb:

U-Boot 2015.04-rc5-00029-gd68df02 (Apr 06 2015 - 11:15:39)

CPU:   Freescale i.MX53 rev2.1 at 800 MHz                                       
Reset cause: POR                                                                
Board: MX53 LOCO                                                                
I2C:   ready                                                                    
DRAM:  1 GiB                                                                    
MMC:   FSL_SDHC: 0, FSL_SDHC: 1                                                 
In:    serial                                                                   
Out:   serial                                                                   
Err:   serial                                                                   
CPU:   Freescale i.MX53 rev2.1 at 1000 MHz                                      
Reset cause: unknown reset                                                      
Net:   FEC [PRIME] 

The CPU and Reset cause lines appear twice.

Quoted 7 lines

Initially mx53 boots at 800MHz, then at a later point the PMIC is configured via I2C to raise the CPU voltage so that it can run at 1GHz.

To avoid such misleading double printings, disable printing cpu info for now.

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================