Skip to contentSkip to conversation

gitk won't show notes?

DISCUSSION Phillip Susi 5 participants 9 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I can't seem to get gitk to show notes, even when I give it --notes. Does it just not handle notes?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJVHZm5AAoJENRVrw2cjl5RT0wIAJVfE2cDQODUCoOsIwhVDiMf CNeTKy1VxCgwVy8KDoYxY2hBlDIRELkcVIkN5ueNVu57LZ+1z/iBUhgr3mmzH9br z2viRjkKRlNSqP/b+HwK0+GxBIbN/FpIEyKTPe558SMcUjCkeINfxfcgYYbmY4Rv aY60j4LMQCEgltkmyDJ/kRX1I7Pr4YCfwNfoIQj3LxvCY5WL7VGn7QmM56Qh9m8P DVvTdMHBnhLOTCSa79/uAAZKJxVNE7z8YnHw1aimNXs/uwm7DYl4coxXVGDxyUfm DnEDcqtLfFst58UtLDRn7f3YawT7heeeXJ7tKUAizX3YQuTTRp9WrN12yE7Crxo= =Z23X
-----END PGP SIGNATURE-----

#1 lore raw

Phillip Susi venit, vidit, dixit 02.04.2015 21:34:

Quoted 4 lines

I can't seem to get gitk to show notes, even when I give it --notes. Does it just not handle notes?

Have you tried with "--show-notes"?

It works over here even without --show-notes, by the way, but I'm not on Windows. Are you?

Michael

#2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 10 lines · Michael J Gruber

Phillip Susi venit, vidit, dixit 02.04.2015 21:34:

Quoted 4 lines

I can't seem to get gitk to show notes, even when I give it --notes. Does it just not handle notes?

Have you tried with "--show-notes"?

It works over here even without --show-notes, by the way, but I'm not on Windows. Are you?

Yes... and this just got weird... I shutdown and restarted gitk and now they show up just fine. It seems that adding the note while gitk is already open, and hitting refresh fails to detect the note.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJVI+R5AAoJENRVrw2cjl5RtnoH/RzJRU/FWrRKc+9P2V5OmR2p bAto0W92AwQVj4jDL3ndmkgm/RivYwNGYXuRVpLXPjKc0bgKNx8a/w4slnoPiWfv HFdIRXGWiJmTLhkzTYHlFLx6uZiDcsz5MV0IW1FhVvqa+QcViTS95yZXtzMj9aj5 g6w1h8C3NU+XBQNf9mDS7a6Xwd3+TZfXQJT1CQasTlgvHefzCk0aLU8K0G09N1ld 3XRGY6cCKplEn5CUDuiMLRAiq7XVWpufV0zmT9ZV7h2ZCcY8b9yav/rQPVd5L1cF PIagJwyZ6YTR/EAGiVU6w0HZemiXHeXTMNMfv4GCRxGwINtfVzmxhnuD5IvKVZk= =b8Ql
-----END PGP SIGNATURE-----

#3 lore raw

Phillip Susi venit, vidit, dixit 07.04.2015 16:06:

Quoted 7 lines · Michael J Gruber
Quoted 5 lines

Phillip Susi venit, vidit, dixit 02.04.2015 21:34:

Quoted 4 lines

I can't seem to get gitk to show notes, even when I give it --notes. Does it just not handle notes?

Quoted 8 lines
Quoted 4 lines

Have you tried with "--show-notes"?

It works over here even without --show-notes, by the way, but I'm not on Windows. Are you?

Yes... and this just got weird... I shutdown and restarted gitk and now they show up just fine. It seems that adding the note while gitk is already open, and hitting refresh fails to detect the note.

Rebooting is the Windows version of refresh ;)

Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the latter is the thorougher refreshment.

Michael

#4 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 2 lines · Michael J Gruber

Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the latter is the thorougher refreshment.

Neither one makes newly added notes show up. The only way seems to be to close and restart gitk. Looks like a bug.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJVJA8KAAoJENRVrw2cjl5RrIgH/2FTWanl7IUyusBMmwR5buLP R0yVGf0xF6xzG3SmayDh9EzmhoSJDBFjbqlb8mG1pbgMQfRNKaCjnlk97WRQ5qDr X9CHImC4HODZVT/jAgCX5HsCEN62nIZBUfliQOH3PFbbAp6LG/Y/milZk3Ek+srL guFFzFsCyv88uAjDJMMM4Ub9Sg3rtKckZ2JeprNv8VDFuqvZWxRPA3G+7TYSTBdE wj73xIjyg0KVP1yAR/833TF7srDaRUnB3Z/AfDXAhekYum5TZnEZNQUh1DpiAnus dC6T8LWu14PebzmiZy+7QV3cakhlt9ZjrHW9eRBVzY7RAm8JRY1GSgbCQJ0pIQo= =EWg/
-----END PGP SIGNATURE-----

#5 lore raw

Phillip Susi venit, vidit, dixit 07.04.2015 19:08:

Quoted 8 lines · Michael J Gruber
Quoted 2 lines

Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the latter is the thorougher refreshment.

Neither one makes newly added notes show up. The only way seems to be to close and restart gitk. Looks like a bug.

Apparently, gitk rereads the refs but not commits it has read already - and the commit reading includes the notes lookup.

Unfortunately, my wish-fu is lacking. But I'll cc the master.

Paulus: None of updatecommits, reloadcommits and rereadrefs seem to reread the notes of a commit that has been displayed already if the notes have changed (but the other refs have not).

Michael

#6 lore raw
Quoted 10 lines · Michael J Gruber

Phillip Susi venit, vidit, dixit 07.04.2015 19:08:

Quoted 8 lines · Michael J Gruber
Quoted 2 lines

Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the latter is the thorougher refreshment.

Neither one makes newly added notes show up. The only way seems to be to close and restart gitk. Looks like a bug.

Quoted 8 lines

Apparently, gitk rereads the refs but not commits it has read already - and the commit reading includes the notes lookup.

Unfortunately, my wish-fu is lacking. But I'll cc the master.

Paulus: None of updatecommits, reloadcommits and rereadrefs seem to reread the notes of a commit that has been displayed already if the notes have changed (but the other refs have not).

As far as shift-F5/reloadcommits is concerned, it looks like I should be unsetting commitinfo in reloadcommits.

However, I agree gitk should refresh the notes in updatecommits as well, but that will take more work. Is git notes list the best way to find out all the current notes?

Paul.

#7 lore raw
Quoted 20 lines · Paul Mackerras
Quoted 10 lines · Michael J Gruber

Phillip Susi venit, vidit, dixit 07.04.2015 19:08:

Quoted 8 lines · Michael J Gruber
Quoted 2 lines

Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the latter is the thorougher refreshment.

Neither one makes newly added notes show up. The only way seems to be to close and restart gitk. Looks like a bug.

Quoted 8 lines

Apparently, gitk rereads the refs but not commits it has read already - and the commit reading includes the notes lookup.

Unfortunately, my wish-fu is lacking. But I'll cc the master.

Paulus: None of updatecommits, reloadcommits and rereadrefs seem to reread the notes of a commit that has been displayed already if the notes have changed (but the other refs have not).

Quoted 6 lines

As far as shift-F5/reloadcommits is concerned, it looks like I should be unsetting commitinfo in reloadcommits.

However, I agree gitk should refresh the notes in updatecommits as well, but that will take more work. Is git notes list the best way to find out all the current notes?

It looks like it is from the documentation.
Anyway let's add some people in Cc in case they could help.

#8 lore raw
Quoted 4 lines · Christian Couder
Quoted 3 lines · Paul Mackerras

However, I agree gitk should refresh the notes in updatecommits as well, but that will take more work. Is git notes list the best way to find out all the current notes?

Yes. (if not, that's a bug and should be fixed).

...Johan

Quoted 3 lines

It looks like it is from the documentation.
Anyway let's add some people in Cc in case they could help.

Signature · 2 lines
Johan Herland, <[email protected]>
www.herland.net