Skip to contentSkip to conversation

Makefile: fix HOSTFC definition

PATCH New Masahiro Yamada 2 participants 2 messages Apr 8, 2015 Kbuild

lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 Makefile: fix HOSTFC definition

"echo" always succeeds, "which g77 || type -p g77 || echo gfortran" is never run.

Signed-off-by Masahiro Yamada <[email protected]>

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 9db52a8..8f4f87c 100644
@@ -251,7 +251,7 @@ HOSTRANLIB := ranlib
 endif
 HOSTAR := $(shell which $(HOSTAR) || type -p $(HOSTAR) || echo ar)
 HOSTAS := $(shell which $(HOSTAS) || type -p $(HOSTAS) || echo as)
-HOSTFC := $(shell which $(HOSTLD) || type -p $(HOSTLD) || echo || which g77 || type -p g77 || echo gfortran)
+HOSTFC := $(shell which $(HOSTFC) || type -p $(HOSTFC) || which g77 || type -p g77 || echo gfortran)
 HOSTCPP := $(shell which $(HOSTCPP) || type -p $(HOSTCPP) || echo cpp)
 HOSTLD := $(shell which $(HOSTLD) || type -p $(HOSTLD) || echo ld)
 HOSTLN := $(shell which $(HOSTLN) || type -p $(HOSTLN) || echo ln)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 Makefile: fix HOSTFC definition

Quoted 2 lines · Masahiro Yamada

"echo" always succeeds, "which g77 || type -p g77 || echo gfortran" is never run.

+ mention the correction HOSTLD -> HOSTFC

Quoted 12 lines
Signed-off-by Masahiro Yamada <[email protected]>

---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +0 -0
index 9db52a8..8f4f87c 100644

Makefile HOSTRANLIB := ranlib · line 254

Quoted 4 lines
Makefile +0 -1
@@ -251,7 +251,7 @@ HOSTRANLIB := ranlib
 endif
 HOSTAR := $(shell which $(HOSTAR) || type -p $(HOSTAR) || echo ar)
 HOSTAS := $(shell which $(HOSTAS) || type -p $(HOSTAS) || echo as)
-HOSTFC := $(shell which $(HOSTLD) || type -p $(HOSTLD) || echo || which g77 || type -p g77 || echo gfortran)

                                 ^^

Since it was incorrect anyway (it was defined as /usr/bin/ld on the
autobuilders) and there was never an issue with it, I guess it was not used anyway. So I propose to completely remove it.

Failing that:

Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 5 lines
Makefile +1 -0
+HOSTFC := $(shell which $(HOSTFC) || type -p $(HOSTFC) || which g77 || type -p g77 || echo gfortran)
 HOSTCPP := $(shell which $(HOSTCPP) || type -p $(HOSTCPP) || echo cpp)
 HOSTLD := $(shell which $(HOSTLD) || type -p $(HOSTLD) || echo ld)
 HOSTLN := $(shell which $(HOSTLN) || type -p $(HOSTLN) || echo ln)
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F