Fix typos in comment blocks
PATCH 1/1 Fix typos in comment blocks
---
Makefile | 2 +- board/avnet/zedboard/readme.txt | 4 ++-- boot/uboot/uboot.mk | 2 +- linux/Config.in | 2 +- package/Makefile.in | 2 +- package/pkg-generic.mk | 2 +- support/download/check-hash | 2 +- support/scripts/gen-manual-lists.py | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-)
Makefile +1 -1
@@ -144,7 +144,7 @@ else $(shell echo BR2_EXTERNAL ?= $(BR2_EXTERNAL) > $(BR2_EXTERNAL_FILE)) endif -# To make sure the the environment variable overrides the .config option, +# To make sure that the environment variable overrides the .config option, # set this before including .config. ifneq ($(BR2_DL_DIR),) DL_DIR := $(BR2_DL_DIR)
board/avnet/zedboard/readme.txt +2 -2
@@ -6,7 +6,7 @@ Zedboard information including schematics, reference designs, and manuals are available from http://www.zedboard.org . The U-Boot firmware for the Xilinx Zynq All Programmable SoC depends -on some propietary code. This dependency consists of a pair of +on some proprietary code. This dependency consists of a pair of files are available from the Xilinx SDK installation. You will need these files from Xilinx SDK installation to generate
@@ -53,7 +53,7 @@ the clean, or uboot-dirclean targets are made. Resulting system ---------------- -A FAT32 partition should be created at the beggining of the SD Card +A FAT32 partition should be created at the beginning of the SD Card and the following files should be installed: /boot.bin /devicetree.dtb
boot/uboot/uboot.mk +1 -1
@@ -177,7 +177,7 @@ ifeq ($(BR2_TARGET_UBOOT),y) # we NEED a board name unless we're at make source ifeq ($(filter source,$(MAKECMDGOALS)),) ifeq ($(UBOOT_BOARD_NAME),) -$(error NO U-Boot board name set. Check your BR2_TARGET_UBOOT_BOARDNAME setting) +$(error No U-Boot board name set. Check your BR2_TARGET_UBOOT_BOARDNAME setting) endif ifeq ($(BR2_TARGET_UBOOT_CUSTOM_VERSION),y)
linux/Config.in +1 -1
@@ -289,7 +289,7 @@ if BR2_LINUX_KERNEL_DTS_SUPPORT # 1) We don't want any support at all. Then the ..DTS_SUPPORT # variable won't be set # 2) We want device tree support, so we need the user to enter -# the device tree name or the the path to the custom device +# the device tree name or the path to the custom device # he uses, but the kernel abstracts this from us and only # build an image that looks like a regular kernel image. In # this case, we only need to derive the kernel image name from
package/Makefile.in +1 -1
@@ -6,7 +6,7 @@ HOSTMAKE = $(MAKE) endif HOSTMAKE := $(shell which $(HOSTMAKE) || type -p $(HOSTMAKE) || echo make) -# If BR2_LEVEL is 0, scale the maximum concurrency with the number of +# If BR2_JLEVEL is 0, scale the maximum concurrency with the number of # CPUs. An additional job is used in order to keep processors busy # while waiting on I/O. # If the number of processors is not available, assume one.
package/pkg-generic.mk +1 -1
@@ -411,7 +411,7 @@ endif $(2)_REDISTRIBUTE ?= YES -# When a target package is a toolchain dependency set this variable to +# When a target package has a toolchain dependency set this variable to # 'NO' so the 'toolchain' dependency is not added to prevent a circular # dependency $(2)_ADD_TOOLCHAIN_DEPENDENCY ?= YES
support/download/check-hash +1 -1
@@ -3,7 +3,7 @@ set -e # Helper to check a file matches its known hash # Call it with: -# $1: the path of the file containing all the the expected hashes +# $1: the path of the file containing all the expected hashes # $2: the full path to the temporary file that was downloaded, and # that is to be checked # $3: the final basename of the file, to which it will be ultimately
support/scripts/gen-manual-lists.py +1 -1
@@ -87,7 +87,7 @@ def get_symbol_parents(item, root=None, enable_choice=False): """ Return the list of the item's parents. The last item of the list is the closest parent, the first the furthest. - :param item: Item from which the the parent list is generated + :param item: Item from which the parent list is generated :param root: Root item stopping the search (not included in the parent list) :param enable_choice: Flag enabling choices to appear in the parent list
Signature · 1 line
1.9.1
PATCH 1/1 Fix typos in comment blocks
Quoted 1 line · Masahiro Yamada
Signed-off-by Masahiro Yamada <[email protected]>
Few mistakes here... Even though it looks stupid, it's better to make a
separate patch for each (unrelated) fix, so they can be reviewed and committed individually.
If you do split, you can add my
for the pieces which don't get a comment.
[snip]
linux/Config.in if BR2_LINUX_KERNEL_DTS_SUPPORT · line 293
Quoted 11 lines
linux/Config.in +1
-1@@ -289,7 +289,7 @@ if BR2_LINUX_KERNEL_DTS_SUPPORT # 1) We don't want any support at all. Then the ..DTS_SUPPORT # variable won't be set # 2) We want device tree support, so we need the user to enter -# the device tree name or the the path to the custom device +# the device tree name or the path to the custom device # he uses, but the kernel abstracts this from us and only
The entire paragraph should be rewrapped because the he now fits on the
preceding line.
Quoted 2 lines
linux/Config.in +0
-0# build an image that looks like a regular kernel image. In # this case, we only need to derive the kernel image name from
[snip]
package/pkg-generic.mk endif · line 414
Quoted 10 lines
package/pkg-generic.mk +1
-1@@ -411,7 +411,7 @@ endif $(2)_REDISTRIBUTE ?= YES -# When a target package is a toolchain dependency set this variable to +# When a target package has a toolchain dependency set this variable to
Nope, the original was correct: this variable should be set when the package is
a (indirect) dependency of 'toolchain'. E.g., uclibc is a target package that is a dependency of the toolchain.
package/pkg-generic.mk endif · line 417
Quoted 3 lines
package/pkg-generic.mk +0
-0# 'NO' so the 'toolchain' dependency is not added to prevent a circular # dependency $(2)_ADD_TOOLCHAIN_DEPENDENCY ?= YES
[snip]
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Thomas Petazzoni
AppliedPATCH 1/1 Fix typos in comment blocks
In reply to Masahiro YamadaDear Masahiro Yamada,
Quoted 12 lines · Masahiro Yamada
Signed-off-by Masahiro Yamada <[email protected]>---
Makefile | 2 +- board/avnet/zedboard/readme.txt | 4 ++-- boot/uboot/uboot.mk | 2 +- linux/Config.in | 2 +- package/Makefile.in | 2 +- package/pkg-generic.mk | 2 +- support/download/check-hash | 2 +- support/scripts/gen-manual-lists.py | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-)
Thanks, applied, after taking into account the review comments from Arnout and making the corresponding changes.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com