ARM: tegra: move NVIVIA common files to arch/arm/mach-tegra
Subsystems (3)
RFC PATCH 1/1 ARM: tegra: move NVIVIA common files to arch/arm/mach-tegra
All the Tegra boards borrow the files from board/nvidia/common/ directory, i.e., board/nvidia/common/* are not vendor-common files, but SoC-common files.
Move NVIDIA common files to arch/arm/mach-tegra/ to clean up Makefiles.
---
arch/arm/mach-tegra/board.c already exists.
So, I renamed board/nvidia/common/board.c to arch/arm/mach-tegra/board2.c, which I think, not a good idea.
Comments please!
arch/arm/mach-tegra/Makefile | 2 ++
board/nvidia/common/board.c => arch/arm/mach-tegra/board2.c | 0
{board/nvidia/common => arch/arm/mach-tegra}/emc.c | 0
{board/nvidia/common => arch/arm/mach-tegra}/emc.h | 0
board/avionic-design/medcom-wide/Makefile | 2 --
board/avionic-design/plutux/Makefile | 2 --
board/avionic-design/tec-ng/Makefile | 2 --
board/avionic-design/tec/Makefile | 2 --
board/compal/paz00/Makefile | 2 --
board/compulab/trimslice/Makefile | 2 --
board/nvidia/common/Makefile | 4 ----
board/nvidia/common/common.mk | 3 ---
board/toradex/apalis_t30/Makefile | 2 --
board/toradex/colibri_t20/Makefile | 2 --
board/toradex/colibri_t30/Makefile | 2 --
15 files changed, 2 insertions(+), 25 deletions(-)
rename board/nvidia/common/board.c => arch/arm/mach-tegra/board2.c (100%)
rename {board/nvidia/common => arch/arm/mach-tegra}/emc.c (100%)
rename {board/nvidia/common => arch/arm/mach-tegra}/emc.h (100%)
delete mode 100644 board/nvidia/common/Makefile
delete mode 100644 board/nvidia/common/common.mkarch/arm/mach-tegra/Makefile +2 -0
@@ -24,6 +24,8 @@ obj-y += powergate.o obj-y += xusb-padctl.o obj-$(CONFIG_DISPLAY_CPUINFO) += sys_info.o obj-$(CONFIG_TEGRA124) += vpr.o +obj-y += board2.o +obj-$(CONFIG_TEGRA_CLOCK_SCALING) += emc.o obj-$(CONFIG_TEGRA20) += tegra20/ obj-$(CONFIG_TEGRA30) += tegra30/
arch/arm/mach-tegra/board2.c renamed from board/nvidia/common/board.c +0 -0
arch/arm/mach-tegra/emc.c renamed from board/nvidia/common/emc.c +0 -0
arch/arm/mach-tegra/emc.h renamed from board/nvidia/common/emc.h +0 -0
board/avionic-design/medcom-wide/Makefile +0 -2
@@ -8,5 +8,3 @@ # obj-y := ../common/tamonten.o - -include $(srctree)/board/nvidia/common/common.mk
board/avionic-design/plutux/Makefile +0 -2
@@ -8,5 +8,3 @@ # obj-y := ../common/tamonten.o - -include $(srctree)/board/nvidia/common/common.mk
board/avionic-design/tec-ng/Makefile +0 -2
@@ -6,5 +6,3 @@ # obj-y := ../common/tamonten-ng.o - -include $(srctree)/board/nvidia/common/common.mk
board/avionic-design/tec/Makefile +0 -2
@@ -8,5 +8,3 @@ # obj-y := ../common/tamonten.o - -include $(srctree)/board/nvidia/common/common.mk
board/compal/paz00/Makefile +0 -2
@@ -15,5 +15,3 @@ # obj-y := paz00.o - -include $(srctree)/board/nvidia/common/common.mk
board/compulab/trimslice/Makefile +0 -2
@@ -6,5 +6,3 @@ # obj-y := trimslice.o - -include $(srctree)/board/nvidia/common/common.mk
board/nvidia/common/Makefile deleted +0 -4
@@ -1,4 +0,0 @@ -# Copyright (c) 2011 The Chromium OS Authors. -# SPDX-License-Identifier: GPL-2.0+ - -include $(src)/common.mk
board/nvidia/common/common.mk deleted +0 -3
@@ -1,3 +0,0 @@ -# common options for all tegra boards -obj-y += ../../nvidia/common/board.o -obj-$(CONFIG_TEGRA_CLOCK_SCALING) += ../../nvidia/common/emc.o
board/toradex/apalis_t30/Makefile +0 -2
@@ -1,6 +1,4 @@ # Copyright (c) 2014 Marcel Ziswiler # SPDX-License-Identifier: GPL-2.0+ -include $(srctree)/board/nvidia/common/common.mk - obj-y += apalis_t30.o
board/toradex/colibri_t20/Makefile +0 -2
@@ -4,6 +4,4 @@ # SPDX-License-Identifier: GPL-2.0+ # -include $(srctree)/board/nvidia/common/common.mk - obj-y += colibri_t20.o
board/toradex/colibri_t30/Makefile +0 -2
@@ -1,6 +1,4 @@ # Copyright (c) 2013-2014 Stefan Agner # SPDX-License-Identifier: GPL-2.0+ -include $(srctree)/board/nvidia/common/common.mk - obj-y += colibri_t30.o
Signature · 1 line
1.9.1
RFC PATCH 1/1 ARM: tegra: move NVIVIA common files to arch/arm/mach-tegra
Quoted 5 lines · Masahiro Yamada
arch/arm/mach-tegra/board.calready exists.
So, I renamedboard/nvidia/common/board.ctoarch/arm/mach-tegra/board2.c, which I think, not a good idea.Comments please!
I would vote to merge it all into one as a second step. The rest looks fine to me.
RFC PATCH 1/1 ARM: tegra: move NVIVIA common files to arch/arm/mach-tegra
In reply to Masahiro Yamada2015-04-10 13:53 GMT+09:00 Masahiro Yamada <[email protected]>:
Quoted 11 lines
All the Tegra boards borrow the files from board/nvidia/common/ directory, i.e., board/nvidia/common/* are not vendor-common files, but SoC-common files.
Move NVIDIA common files to
arch/arm/mach-tegra/to clean up Makefiles.Signed-off-by Masahiro Yamada <[email protected]>Cc Stephen Warren <[email protected]>Cc Tom Warren <[email protected]>Cc Simon Glass <[email protected]>
I will fix the subject in v2.
s/NVIVIA/NVIDIA/
Signature · 2 lines
Best Regards Masahiro Yamada
RFC PATCH 1/1 ARM: tegra: move NVIVIA common files to arch/arm/mach-tegra
In reply to Masahiro YamadaQuoted 11 lines · Masahiro Yamada
All the Tegra boards borrow the files from board/nvidia/common/ directory, i.e., board/nvidia/common/* are not vendor-common files, but SoC-common files.
Move NVIDIA common files to
arch/arm/mach-tegra/to clean up Makefiles.Signed-off-by Masahiro Yamada <[email protected]>Cc Stephen Warren <[email protected]>Cc Tom Warren <[email protected]>Cc Simon Glass <[email protected]>
Quoted 5 lines
---
arch/arm/mach-tegra/board.calready exists.
So, I renamedboard/nvidia/common/board.ctoarch/arm/mach-tegra/board2.c, which I think, not a good idea.
Well, perhaps not optimal, but it isn't going to cause any kind of significant problem I think, and could easily be fixed up later. Perhaps merge the two files together if you want? I never understood the reasoning behind the split anyway.