ARM: fix arch/arm/Makefile for Tegra

PATCH Superseded Masahiro Yamada 2 participants 2 messages Apr 11, 2015 Arm (32-bit)

Share & tools

Masahiro Yamada

author

2015-04-11 14:29 UTC #0 lore raw

PATCH 1/1 ARM: fix arch/arm/Makefile for Tegra

Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to arch/arm/Makefile), all the Tegra boards are broken because the SPL is built for ARMv7.

Insert Tegra-specific code to arch/arm/Makefile to set compiler flags for an earlier ARM architecture.

Note:
The patch for commit 79d75d752717 *was* correct when it was posted. Notice it was written for multi .config configuration where Kconfig set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for Tegra U-Boot Main/SPL, respectively. But, it look long until that patch was merged into the mainline, and finally, it was overtaken by commit e02ee2548afe (kconfig: switch to single .config configuration).

Signed-off-by Masahiro Yamada <[email protected]>

Reported-by Stephen Warren <[email protected]>

Reported-by Jan Kiszka <[email protected]>

---

I just did build test for all the Tegra boards.

Stephen,
Could you do run-test?

Tom,
Please hold back the v2015.04 release until we confim this problem is fixed.

 arch/arm/Makefile | 5 +++++
 1 file changed, 5 insertions(+)

arch/arm/Makefile +5 -0

index 6463c19..bd4749c 100644
@@ -2,6 +2,11 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TEGRA),yy)
+CONFIG_CPU_V7=
+CONFIG_CPU_ARM720T=y
+endif
+
 # This selects which instruction set is used.
 arch-$(CONFIG_CPU_ARM720T)	=-march=armv4
 arch-$(CONFIG_CPU_ARM920T)	=-march=armv4

Signature · 1 line

1.9.1

Jan Kiszka

2015-04-11 15:39 UTC #1 lore raw

PATCH 1/1 ARM: fix arch/arm/Makefile for Tegra

Quoted 40 lines · Masahiro Yamada

Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to arch/arm/Makefile), all the Tegra boards are broken because the SPL is built for ARMv7.
Insert Tegra-specific code to arch/arm/Makefile to set compiler flags for an earlier ARM architecture.
Note:
The patch for commit 79d75d752717 *was* correct when it was posted. Notice it was written for multi .config configuration where Kconfig set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for Tegra U-Boot Main/SPL, respectively. But, it look long until that patch was merged into the mainline, and finally, it was overtaken by commit e02ee2548afe (kconfig: switch to single .config configuration).
Signed-off-by Masahiro Yamada <[email protected]>
Reported-by Stephen Warren <[email protected]>
Reported-by Jan Kiszka <[email protected]>
---
I just did build test for all the Tegra boards.
Stephen,
Could you do run-test?
Tom,
Please hold back the v2015.04 release until we confim this problem is fixed.
 arch/arm/Makefile | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Makefile +0 -0
index 6463c19..bd4749c 100644
@@ -2,6 +2,11 @@
 # SPDX-License-Identifier:	GPL-2.0+

arch/arm/Makefile line 12

Quoted 10 lines

arch/arm/Makefile +5 -0

 #
 
+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TEGRA),yy)
+CONFIG_CPU_V7=
+CONFIG_CPU_ARM720T=y
+endif
+
 # This selects which instruction set is used.
 arch-$(CONFIG_CPU_ARM720T)	=-march=armv4
 arch-$(CONFIG_CPU_ARM920T)	=-march=armv4

Tested-by Jan Kiszka <[email protected]>

Thanks for the quick solution!
Jan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150411/36c82a7f/attachment.sig>