Skip to contentSkip to conversation

ARM: fix arch/arm/Makefile for Tegra

PATCH New Masahiro Yamada 3 participants 3 messages Apr 11, 2015 – Apr 12, 2015 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: fix arch/arm/Makefile for Tegra

Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to arch/arm/Makefile), all the Tegra boards are broken because the SPL is built for ARMv7.

Insert Tegra-specific code to arch/arm/Makefile to set compiler flags for an earlier ARM architecture.

Note:
The v1 patch for commit 79d75d752717 *was* correct when it was submitted. Notice it was originally written for multi .config configuration where Kconfig set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for Tegra U-Boot Main/SPL, respectively. But, until it was merged into the mainline, commit e02ee2548afe (kconfig: switch to single .config configuration) had been already applied there.

---

Changes in v2:
- Brush up the commit-description because V1 had a typo (s/look/took/)
- Add Jan's Tested-by credit

 arch/arm/Makefile | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/Makefile +5 -0
index 6463c19..bd4749c 100644
@@ -2,6 +2,11 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_TEGRA),yy)
+CONFIG_CPU_V7=
+CONFIG_CPU_ARM720T=y
+endif
+
 # This selects which instruction set is used.
 arch-$(CONFIG_CPU_ARM720T)	=-march=armv4
 arch-$(CONFIG_CPU_ARM920T)	=-march=armv4
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 ARM: fix arch/arm/Makefile for Tegra

Quoted 15 lines · Masahiro Yamada

Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to arch/arm/Makefile), all the Tegra boards are broken because the SPL is built for ARMv7.

Insert Tegra-specific code to arch/arm/Makefile to set compiler flags for an earlier ARM architecture.

Note:
The v1 patch for commit 79d75d752717 *was* correct when it was submitted. Notice it was originally written for multi .config configuration where Kconfig set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for Tegra U-Boot Main/SPL, respectively. But, until it was merged into the mainline, commit e02ee2548afe (kconfig: switch to single .config configuration) had been already applied there.

Quoted 4 lines

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150411/2f56d389/attachment.sig>
#2 lore raw

PATCH v2 1/1 ARM: fix arch/arm/Makefile for Tegra

In reply to Masahiro Yamada
Quoted 7 lines · Masahiro Yamada

Since commit 79d75d752717 (ARM: move -march=* and -mtune= options to arch/arm/Makefile), all the Tegra boards are broken because the SPL is built for ARMv7.

Insert Tegra-specific code to arch/arm/Makefile to set compiler flags for an earlier ARM architecture.

Quoted 7 lines

Note:
The v1 patch for commit 79d75d752717 *was* correct when it was submitted. Notice it was originally written for multi .config configuration where Kconfig set CONFIG_CPU_V7/CONFIG_CPU_ARM720T for Tegra U-Boot Main/SPL, respectively. But, until it was merged into the mainline, commit e02ee2548afe (kconfig: switch to single .config configuration) had been already applied there.