Skip to contentSkip to conversation

package/gdb: gdb 7.9 fix uClibc build whitout MMU

PATCH New Romain Naour 2 participants 3 messages Apr 10, 2015 – Apr 12, 2015

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/1 package/gdb: gdb 7.9 fix uClibc build whitout MMU

Signed-off-by Romain Naour <[email protected]>
Cc Gustavo Zacarias <[email protected]>
---
 .../0001-gdbserver-fix-uClibc-whithout-MMU.patch   | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +38 -0
new file mode 100644
index 0000000..23486a3
@@ -0,0 +1,38 @@
+From d3988abfa6bb97dbcad3a0ff0961e920ce84b00c Mon Sep 17 00:00:00 2001
+From: Romain Naour <[email protected]>
+Date: Fri, 10 Apr 2015 22:58:07 +0200
+Subject: [PATCH] gdbserver: fix uClibc whithout MMU.
+
+Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
+must be retrieved from current_thread.
+
+The change has not been made in the function linux_read_offsets().
+
+Fixes:
+http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
+
+Signed-off-by: Romain Naour <[email protected]>
+
+Conflicts:
+	gdb/gdbserver/linux-low.c
+---
+ gdb/gdbserver/linux-low.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
+index 4d19c87..23f012d 100644
+--- a/gdb/gdbserver/linux-low.c
++++ b/gdb/gdbserver/linux-low.c
+@@ -4933,7 +4933,8 @@ static int
+ linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
+ {
+   unsigned long text, text_end, data;
+-  int pid = lwpid_of (get_thread_lwp (current_thread));
++
++  int pid = lwpid_of (current_thread);
+ 
+   errno = 0;
+ 
+-- 
+1.9.3
+
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 package/gdb: gdb 7.9 fix uClibc build whitout MMU

Dear Romain Naour,

Quoted 20 lines · Romain Naour
Signed-off-by Romain Naour <[email protected]>
Cc Gustavo Zacarias <[email protected]>
---
 .../0001-gdbserver-fix-uClibc-whithout-MMU.patch   | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +7 -0
new file mode 100644
index 0000000..23486a3
@@ -0,0 +1,38 @@
+From d3988abfa6bb97dbcad3a0ff0961e920ce84b00c Mon Sep 17 00:00:00 2001
+From: Romain Naour <[email protected]>
+Date: Fri, 10 Apr 2015 22:58:07 +0200
+Subject: [PATCH] gdbserver: fix uClibc whithout MMU.
+
+Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
+must be retrieved from current_thread.

package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch line 17

Quoted 10 lines
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +10 -0
+
+The change has not been made in the function linux_read_offsets().
+
+Fixes:
+http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
+
+Signed-off-by: Romain Naour <[email protected]>
+
+Conflicts:
+	gdb/gdbserver/linux-low.c

This Conflicts info is probably not needed.

Quoted 4 lines
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +4 -0
+---
+ gdb/gdbserver/linux-low.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+

package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch line 31

Quoted 10 lines
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +10 -0
+diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
+index 4d19c87..23f012d 100644
+--- a/gdb/gdbserver/linux-low.c
++++ b/gdb/gdbserver/linux-low.c
+@@ -4933,7 +4933,8 @@ static int
+ linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
+ {
+   unsigned long text, text_end, data;
+-  int pid = lwpid_of (get_thread_lwp (current_thread));
++

No need to add this empty line here.

package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch line 32

Quoted 1 line
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +1 -0
++  int pid = lwpid_of (current_thread);

Can you respin a new version?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 package/gdb: gdb 7.9 fix uClibc build whitout MMU

Hi Thomas,

Le 11/04/2015 20:24, Thomas Petazzoni a ?crit :

Quoted 27 lines

Dear Romain Naour,

Quoted 24 lines · Romain Naour
Signed-off-by Romain Naour <[email protected]>
Cc Gustavo Zacarias <[email protected]>
---
 .../0001-gdbserver-fix-uClibc-whithout-MMU.patch   | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +11 -0
new file mode 100644
index 0000000..23486a3
@@ -0,0 +1,38 @@
+From d3988abfa6bb97dbcad3a0ff0961e920ce84b00c Mon Sep 17 00:00:00 2001
+From: Romain Naour <[email protected]>
+Date: Fri, 10 Apr 2015 22:58:07 +0200
+Subject: [PATCH] gdbserver: fix uClibc whithout MMU.
+
+Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
+must be retrieved from current_thread.
+
+The change has not been made in the function linux_read_offsets().
+
+Fixes:
Quoted 8 lines

package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch line 17

Quoted 6 lines
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +6 -0
+http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
+
+Signed-off-by: Romain Naour <[email protected]>
+
+Conflicts:
+	gdb/gdbserver/linux-low.c

This Conflicts info is probably not needed.

Ok

Quoted 17 lines
Quoted 5 lines
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +4 -0
+---
+ gdb/gdbserver/linux-low.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+

package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch line 31

Quoted 10 lines
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +10 -0
+diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
+index 4d19c87..23f012d 100644
+--- a/gdb/gdbserver/linux-low.c
++++ b/gdb/gdbserver/linux-low.c
+@@ -4933,7 +4933,8 @@ static int
+ linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
+ {
+   unsigned long text, text_end, data;
+-  int pid = lwpid_of (get_thread_lwp (current_thread));
++

No need to add this empty line here.

It's a leftover after resolving the merge conflict...

Quoted 4 lines

package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch line 32

Quoted 2 lines
package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch new file +1 -0
++  int pid = lwpid_of (current_thread);

Can you respin a new version?

See http://patchwork.ozlabs.org/patch/460493/

Thanks,
Romain

Quoted 5 lines

Thanks a lot!

Thomas