dm: use "select DM"

PATCH New Masahiro Yamada 6 participants 48 messages Mar 31, 2015 – Apr 22, 2015

Subsystems (11)

Arm (32-bit) x86 Arm sub-architectures PowerPC +7 more subsystems

lore

Share & tools

lore

Masahiro Yamada

author

2015-03-31 03:47 UTC #0 lore raw

cover dm: use "select DM"

01/12 fixes SOCFPGA boards. (Because of a wrong dependency, SOCFPGA boards cannot enable CONFIG_DM_SPI_FLASH.

The other patches move CONFIG options from defcofig to Kconfig and use "select".

02 thru 12 do not change the output binaries at all. I compared MD5SUM of all the boards and confirmed this.

Masahiro Yamada (12):
dm: spi_flash: fix wrong dependency
dm: select CONFIG_DM* options
ARM: UniPhier: use "select" instead of default value in defconfig
ARM: zynq: use "select" instead of default value in defconfig
ARM: rmobile: use "select" instead of default value in defconfig
ARM: snapper9260: use "select" instead of default value in defconfig
ARM: mx6: use "select" instead of default value in defconfig
ARM: socfpga: use "select" instead of default value in defconfig
ARM: bav335x: use "select" instead of default value in defconfig
ARM: stv0991: use "select" instead of default value in defconfig
ARM: cm_fx6: use "select" instead of default value in defconfig
powerpc: ids8313: use "select" instead of default value in defconfig

 arch/Kconfig                             |  9 +++++
 arch/arm/Kconfig                         | 58 ++++++++++++++++++++++++++++++++
 arch/arm/cpu/armv7/exynos/Kconfig        | 15 ---------
 arch/arm/cpu/armv7/omap3/Kconfig         | 27 ++++++++++-----
 arch/arm/cpu/armv7/rmobile/Kconfig       | 12 +++++++
 arch/arm/mach-at91/Kconfig               |  3 ++
 arch/arm/mach-bcm283x/Kconfig            |  9 -----
 arch/arm/mach-tegra/Kconfig              | 18 ----------
 arch/powerpc/cpu/mpc83xx/Kconfig         |  1 +
 arch/powerpc/cpu/ppc4xx/Kconfig          |  2 ++
 arch/sandbox/Kconfig                     | 18 ----------
 arch/x86/Kconfig                         |  9 -----
 board/amcc/canyonlands/Kconfig           |  6 ----
 board/compulab/cm_t335/Kconfig           |  9 -----
 board/gumstix/pepper/Kconfig             |  9 -----
 board/isee/igep0033/Kconfig              |  9 -----
 board/phytec/pcm051/Kconfig              |  9 -----
 board/samsung/goni/Kconfig               |  9 -----
 board/samsung/smdkc100/Kconfig           |  9 -----
 board/silica/pengwyn/Kconfig             |  9 -----
 board/ti/am335x/Kconfig                  |  9 -----
 configs/alt_defconfig                    |  2 --
 configs/am335x_boneblack_vboot_defconfig |  1 -
 configs/am3517_crane_defconfig           |  3 --
 configs/am3517_evm_defconfig             |  3 --
 configs/birdland_bav335a_defconfig       |  3 --
 configs/birdland_bav335b_defconfig       |  3 --
 configs/cm_fx6_defconfig                 |  3 --
 configs/cm_t3517_defconfig               |  3 --
 configs/cm_t35_defconfig                 |  3 --
 configs/devkit8000_defconfig             |  3 --
 configs/dig297_defconfig                 |  3 --
 configs/eco5pk_defconfig                 |  3 --
 configs/gose_defconfig                   |  2 --
 configs/ids8313_defconfig                |  1 -
 configs/koelsch_defconfig                |  2 --
 configs/lager_defconfig                  |  2 --
 configs/mcx_defconfig                    |  3 --
 configs/mt_ventoux_defconfig             |  3 --
 configs/mx6dlsabreauto_defconfig         |  2 --
 configs/mx6dlsabresd_defconfig           |  2 --
 configs/mx6qsabreauto_defconfig          |  2 --
 configs/mx6qsabresd_defconfig            |  2 --
 configs/mx6sabresd_spl_defconfig         |  2 --
 configs/mx6sxsabresd_defconfig           |  2 --
 configs/mx6sxsabresd_spl_defconfig       |  2 --
 configs/nokia_rx51_defconfig             |  3 --
 configs/omap3_beagle_defconfig           |  3 --
 configs/omap3_evm_defconfig              |  3 --
 configs/omap3_evm_quick_mmc_defconfig    |  3 --
 configs/omap3_evm_quick_nand_defconfig   |  3 --
 configs/omap3_ha_defconfig               |  3 --
 configs/omap3_logic_defconfig            |  3 --
 configs/omap3_mvblx_defconfig            |  3 --
 configs/omap3_pandora_defconfig          |  3 --
 configs/omap3_sdp3430_defconfig          |  3 --
 configs/ph1_ld4_defconfig                |  3 --
 configs/ph1_pro4_defconfig               |  3 --
 configs/ph1_sld8_defconfig               |  3 --
 configs/porter_defconfig                 |  2 --
 configs/sandbox_defconfig                |  1 -
 configs/silk_defconfig                   |  2 --
 configs/snapper9260_defconfig            |  3 --
 configs/snapper9g20_defconfig            |  3 --
 configs/socfpga_arria5_defconfig         |  3 --
 configs/socfpga_cyclone5_defconfig       |  3 --
 configs/socfpga_socrates_defconfig       |  3 --
 configs/stv0991_defconfig                |  2 --
 configs/tao3530_defconfig                |  3 --
 configs/tricorder_defconfig              |  3 --
 configs/tricorder_flash_defconfig        |  3 --
 configs/twister_defconfig                |  3 --
 configs/zynq_microzed_defconfig          |  1 -
 configs/zynq_zc70x_defconfig             |  1 -
 configs/zynq_zc770_xm010_defconfig       |  1 -
 configs/zynq_zc770_xm012_defconfig       |  1 -
 configs/zynq_zc770_xm013_defconfig       |  1 -
 configs/zynq_zed_defconfig               |  1 -
 configs/zynq_zybo_defconfig              |  1 -
 drivers/mtd/spi/Kconfig                  |  2 +-
 80 files changed, 104 insertions(+), 297 deletions(-)

Signature · 1 line

1.9.1

Masahiro Yamada

author

2015-03-31 03:47 UTC #1 lore raw

PATCH 1/12 dm: spi_flash: fix wrong dependency

CONFIG_SPI does not exist in Kconfig in the first place, so the dependency "depends on DM && SPI" is never met, i.e., DM_SPI_FLASH can never be enabled (unless you ignore the dependency in an illegal way. See below.)

Actually, some defconfigs such as socfpga_*_defconfig define CONFIG_DM_SPI_FLASH=y, but it never appears in the .config file because of this wrong dependency.

On the other hand, all the Tegra boards enable DM_SPI_FLASH because

config DM_SPI_FLASH
default y

silently ignores the dependency.
Unfortunately, this style of CONFIG definition is abused everywhere in U-Boot, so we easily miss such a wrong dependency.

Signed-off-by Masahiro Yamada <[email protected]>

---

 drivers/mtd/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mtd/spi/Kconfig +1 -1

index 2dc46b4..fd2d7ac 100644
@@ -1,6 +1,6 @@
 config DM_SPI_FLASH
 	bool "Enable Driver Model for SPI flash"
-	depends on DM && SPI
+	depends on DM && DM_SPI
 	help
 	  Enable driver model for SPI flash. This SPI flash interface
 	  (spi_flash_probe(), spi_flash_write(), etc.) is then

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #2 lore raw

PATCH 1/12 dm: spi_flash: fix wrong dependency

Quoted 37 lines · Masahiro Yamada

CONFIG_SPI does not exist in Kconfig in the first place, so the dependency "depends on DM && SPI" is never met, i.e., DM_SPI_FLASH can never be enabled (unless you ignore the dependency in an illegal way. See below.)
Actually, some defconfigs such as socfpga_*_defconfig define CONFIG_DM_SPI_FLASH=y, but it never appears in the .config file because of this wrong dependency.
On the other hand, all the Tegra boards enable DM_SPI_FLASH because
config DM_SPI_FLASH
default y
silently ignores the dependency.
Unfortunately, this style of CONFIG definition is abused everywhere in U-Boot, so we easily miss such a wrong dependency.
Signed-off-by Masahiro Yamada <[email protected]>
---
 drivers/mtd/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/Kconfig +1 -2
index 2dc46b4..fd2d7ac 100644
@@ -1,6 +1,6 @@
 config DM_SPI_FLASH
        bool "Enable Driver Model for SPI flash"
-       depends on DM && SPI
+       depends on DM && DM_SPI
        help
          Enable driver model for SPI flash. This SPI flash interface
          (spi_flash_probe(), spi_flash_write(), etc.) is then
--

Quoted 2 lines

1.9.1

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:01 UTC #3 lore raw

PATCH 1/12 dm: spi_flash: fix wrong dependency

Quoted 36 lines · Simon Glass

Quoted 33 lines · Masahiro Yamada
CONFIG_SPI does not exist in Kconfig in the first place, so the dependency "depends on DM && SPI" is never met, i.e., DM_SPI_FLASH can never be enabled (unless you ignore the dependency in an illegal way. See below.)
Actually, some defconfigs such as socfpga_*_defconfig define CONFIG_DM_SPI_FLASH=y, but it never appears in the .config file because of this wrong dependency.
On the other hand, all the Tegra boards enable DM_SPI_FLASH because
config DM_SPI_FLASH
default y
silently ignores the dependency.
Unfortunately, this style of CONFIG definition is abused everywhere in U-Boot, so we easily miss such a wrong dependency.
Signed-off-by Masahiro Yamada <[email protected]>
---
 drivers/mtd/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/Kconfig +1 -1
index 2dc46b4..fd2d7ac 100644
@@ -1,6 +1,6 @@
 config DM_SPI_FLASH
        bool "Enable Driver Model for SPI flash"
-       depends on DM && SPI
+       depends on DM && DM_SPI

Quoted 8 lines

Quoted 6 lines

drivers/mtd/spi/Kconfig +0 -1

        help
          Enable driver model for SPI flash. This SPI flash interface
          (spi_flash_probe(), spi_flash_write(), etc.) is then
--

1.9.1

Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Stefan Roese

2015-04-22 09:19 UTC #4 lore raw

PATCH 1/12 dm: spi_flash: fix wrong dependency

Hi Tom,

Quoted 46 lines · Simon Glass

Quoted 36 lines · Simon Glass
Quoted 33 lines · Masahiro Yamada
CONFIG_SPI does not exist in Kconfig in the first place, so the dependency "depends on DM && SPI" is never met, i.e., DM_SPI_FLASH can never be enabled (unless you ignore the dependency in an illegal way. See below.)
Actually, some defconfigs such as socfpga_*_defconfig define CONFIG_DM_SPI_FLASH=y, but it never appears in the .config file because of this wrong dependency.
On the other hand, all the Tegra boards enable DM_SPI_FLASH because
config DM_SPI_FLASH
default y
silently ignores the dependency.
Unfortunately, this style of CONFIG definition is abused everywhere in U-Boot, so we easily miss such a wrong dependency.
Signed-off-by Masahiro Yamada <[email protected]>
---
  drivers/mtd/spi/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/Kconfig +1 -1
index 2dc46b4..fd2d7ac 100644
@@ -1,6 +1,6 @@
  config DM_SPI_FLASH
         bool "Enable Driver Model for SPI flash"
-       depends on DM && SPI
+       depends on DM && DM_SPI
Quoted 8 lines
Quoted 6 lines
drivers/mtd/spi/Kconfig +0 -1
         help
           Enable driver model for SPI flash. This SPI flash interface
           (spi_flash_probe(), spi_flash_write(), etc.) is then
--
1.9.1
Acked-by Simon Glass <[email protected]>

Quoted 1 line

Applied to u-boot-dm/next, thanks!

Do you plan to release a v2015.04.1 stable release at some time? Then please add this patch to this version. As it fixes SPI NOR flash on SoCFPGA.

Thanks,
Stefan

Marek Vasut

2015-04-22 10:07 UTC #5 lore raw

PATCH 1/12 dm: spi_flash: fix wrong dependency

Quoted 55 lines · Stefan Roese

Hi Tom,
Quoted 52 lines · Simon Glass
Quoted 50 lines · Simon Glass
On 30 March 2015 at 21:47, Masahiro Yamada
Quoted 38 lines · <[email protected]> wrote:
CONFIG_SPI does not exist in Kconfig in the first place, so the dependency "depends on DM && SPI" is never met, i.e., DM_SPI_FLASH can never be enabled (unless you ignore the dependency in an illegal way. See below.)
Actually, some defconfigs such as socfpga_*_defconfig define CONFIG_DM_SPI_FLASH=y, but it never appears in the .config file because of this wrong dependency.
On the other hand, all the Tegra boards enable DM_SPI_FLASH because
config DM_SPI_FLASH
default y
silently ignores the dependency.
Unfortunately, this style of CONFIG definition is abused everywhere in U-Boot, so we easily miss such a wrong dependency.
Signed-off-by Masahiro Yamada <[email protected]>
---
  drivers/mtd/spi/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/Kconfig +1 -1
index 2dc46b4..fd2d7ac 100644
@@ -1,6 +1,6 @@
 
  config DM_SPI_FLASH
 
         bool "Enable Driver Model for SPI flash"
 
-       depends on DM && SPI
+       depends on DM && DM_SPI
Quoted 7 lines
help
Enable driver model for SPI flash. This SPI flash interface (spi_flash_probe(), spi_flash_write(), etc.) is then
--
1.9.1
Acked-by Simon Glass <[email protected]>

Quoted 5 lines

Quoted 1 line
Applied to u-boot-dm/next, thanks!
Do you plan to release a v2015.04.1 stable release at some time? Then please add this patch to this version. As it fixes SPI NOR flash on SoCFPGA.

Maybe we should consider u-boot-stable ...

Best regards,
Marek Vasut

Simon Glass

2015-04-22 14:39 UTC #6 lore raw

PATCH 1/12 dm: spi_flash: fix wrong dependency

Hi,

Quoted 56 lines · Marek Vasut

Quoted 55 lines · Stefan Roese
Hi Tom,
Quoted 52 lines · Simon Glass
Quoted 50 lines · Simon Glass
On 30 March 2015 at 21:47, Masahiro Yamada
Quoted 38 lines · <[email protected]> wrote:
CONFIG_SPI does not exist in Kconfig in the first place, so the dependency "depends on DM && SPI" is never met, i.e., DM_SPI_FLASH can never be enabled (unless you ignore the dependency in an illegal way. See below.)
Actually, some defconfigs such as socfpga_*_defconfig define CONFIG_DM_SPI_FLASH=y, but it never appears in the .config file because of this wrong dependency.
On the other hand, all the Tegra boards enable DM_SPI_FLASH because
config DM_SPI_FLASH
default y
silently ignores the dependency.
Unfortunately, this style of CONFIG definition is abused everywhere in U-Boot, so we easily miss such a wrong dependency.
Signed-off-by Masahiro Yamada <[email protected]>
---
  drivers/mtd/spi/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/Kconfig +1 -1
index 2dc46b4..fd2d7ac 100644
@@ -1,6 +1,6 @@
 
  config DM_SPI_FLASH
 
         bool "Enable Driver Model for SPI flash"
 
-       depends on DM && SPI
+       depends on DM && DM_SPI
Quoted 7 lines
help
Enable driver model for SPI flash. This SPI flash interface (spi_flash_probe(), spi_flash_write(), etc.) is then
--
1.9.1
Acked-by Simon Glass <[email protected]>

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
Applied to u-boot-dm/next, thanks!
Do you plan to release a v2015.04.1 stable release at some time? Then please add this patch to this version. As it fixes SPI NOR flash on SoCFPGA.
Maybe we should consider u-boot-stable ...

In this case, just mentioning that it was needed for the release would have helped. It's not always obvious whether patches are important fixes, particularly if they depend on other things.

Regards,
Simon

Stefan Roese

2015-04-22 14:42 UTC #7 lore raw

PATCH 1/12 dm: spi_flash: fix wrong dependency

Hi Simon,

Quoted 11 lines · Simon Glass

Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Applied to u-boot-dm/next, thanks!
Do you plan to release a v2015.04.1 stable release at some time? Then please add this patch to this version. As it fixes SPI NOR flash on SoCFPGA.
Maybe we should consider u-boot-stable ...
In this case, just mentioning that it was needed for the release would have helped. It's not always obvious whether patches are important fixes, particularly if they depend on other things.

I really noticed it just now. Sorry for not testing earlier.

Thanks,
Stefan

Simon Glass

2015-04-22 15:07 UTC #8 lore raw

PATCH 1/12 dm: spi_flash: fix wrong dependency

Hi Stefan,

Quoted 15 lines · Stefan Roese

Hi Simon,
Quoted 11 lines · Simon Glass
Quoted 9 lines
Quoted 6 lines
Quoted 1 line
Applied to u-boot-dm/next, thanks!
Do you plan to release a v2015.04.1 stable release at some time? Then please add this patch to this version. As it fixes SPI NOR flash on SoCFPGA.
Maybe we should consider u-boot-stable ...

Quoted 6 lines

Quoted 3 lines
In this case, just mentioning that it was needed for the release would have helped. It's not always obvious whether patches are important fixes, particularly if they depend on other things.
I really noticed it just now. Sorry for not testing earlier.

Sorry, that's wasn't a complaint, just some sort of explanation :-)

Regards,
Simon

Masahiro Yamada

author

2015-03-31 03:47 UTC #9 lore raw

PATCH 2/12 dm: select CONFIG_DM* options

In reply to Masahiro Yamada

As mentioned in the previous commit, adding default values in each Kconfig causes problems because it does not co-exist with the "depends on" syntax. (Please note this is not a bug of Kconfig.) We should not do so unless we have a special reason. Actually, for CONFIG_DM*, we have no good reason to do so.

Generally, CONFIG_DM is not a user-configurable option. Once we convert a driver into Driver Model, the board only works with Driver Model, i.e. CONFIG_DM must be always enabled for that board. So, using "select DM" is more suitable rather than allowing users to modify it. Another good thing is, Kconfig warns unmet dependencies for "select" syntax, so we easily notice bugs.

Actually, CONFIG_DM and other related options have been added without consistency: some into arch/*/Kconfig, some into board/*/Kconfig, and some into configs/*_defconfig.

This commit prefers "select" and cleans up the following issues.

[1] Never use "CONFIG_DM=n" in defconfig files

It is really rare to add "CONFIG_FOO=n" to disable CONFIG options. It is more common to use "# CONFIG_FOO is not set". But here, we do not even have to do it.
Less than half of OMAP3 boards have been converted to Driver Model. Adding the default values to arch/arm/cpu/armv7/omap3/Kconfig is weird. Instead, add "select DM" only to appropriate boards, which eventually eliminates "CONFIG_DM=n", etc.

[2] Delete redundant CONFIGs

Sandbox sets CONFIG_DM in arch/sandbox/Kconfig and defines it again in configs/sandbox_defconfig.
Likewise, OMAP3 sets CONFIG_DM arch/arm/cpu/armv7/omap3/Kconfig and defines it also in omap3_beagle_defconfig and devkit8000_defconfig.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/Kconfig                             |  9 ++++++++
 arch/arm/Kconfig                         | 35 ++++++++++++++++++++++++++++++++
 arch/arm/cpu/armv7/exynos/Kconfig        | 15 --------------
 arch/arm/cpu/armv7/omap3/Kconfig         | 27 ++++++++++++++++--------
 arch/arm/mach-bcm283x/Kconfig            |  9 --------
 arch/arm/mach-tegra/Kconfig              | 18 ----------------
 arch/powerpc/cpu/ppc4xx/Kconfig          |  2 ++
 arch/sandbox/Kconfig                     | 18 ----------------
 arch/x86/Kconfig                         |  9 --------
 board/amcc/canyonlands/Kconfig           |  6 ------
 board/compulab/cm_t335/Kconfig           |  9 --------
 board/gumstix/pepper/Kconfig             |  9 --------
 board/isee/igep0033/Kconfig              |  9 --------
 board/phytec/pcm051/Kconfig              |  9 --------
 board/samsung/goni/Kconfig               |  9 --------
 board/samsung/smdkc100/Kconfig           |  9 --------
 board/silica/pengwyn/Kconfig             |  9 --------
 board/ti/am335x/Kconfig                  |  9 --------
 configs/am335x_boneblack_vboot_defconfig |  1 -
 configs/am3517_crane_defconfig           |  3 ---
 configs/am3517_evm_defconfig             |  3 ---
 configs/cm_t3517_defconfig               |  3 ---
 configs/cm_t35_defconfig                 |  3 ---
 configs/devkit8000_defconfig             |  3 ---
 configs/dig297_defconfig                 |  3 ---
 configs/eco5pk_defconfig                 |  3 ---
 configs/mcx_defconfig                    |  3 ---
 configs/mt_ventoux_defconfig             |  3 ---
 configs/nokia_rx51_defconfig             |  3 ---
 configs/omap3_beagle_defconfig           |  3 ---
 configs/omap3_evm_defconfig              |  3 ---
 configs/omap3_evm_quick_mmc_defconfig    |  3 ---
 configs/omap3_evm_quick_nand_defconfig   |  3 ---
 configs/omap3_ha_defconfig               |  3 ---
 configs/omap3_logic_defconfig            |  3 ---
 configs/omap3_mvblx_defconfig            |  3 ---
 configs/omap3_pandora_defconfig          |  3 ---
 configs/omap3_sdp3430_defconfig          |  3 ---
 configs/sandbox_defconfig                |  1 -
 configs/tao3530_defconfig                |  3 ---
 configs/tricorder_defconfig              |  3 ---
 configs/tricorder_flash_defconfig        |  3 ---
 configs/twister_defconfig                |  3 ---
 43 files changed, 64 insertions(+), 227 deletions(-)

arch/Kconfig +9 -0

index ca617e7..6d897a2 100644
@@ -69,6 +69,12 @@ config SANDBOX
 	select HAVE_GENERIC_BOARD
 	select SYS_GENERIC_BOARD
 	select SUPPORT_OF_CONTROL
+	select DM
+	select DM_SPI_FLASH
+	select DM_SERIAL
+	select DM_I2C
+	select DM_SPI
+	select DM_GPIO
 
 config SH
 	bool "SuperH architecture"

@@ -83,6 +89,9 @@ config X86
 	select HAVE_GENERIC_BOARD
 	select SYS_GENERIC_BOARD
 	select SUPPORT_OF_CONTROL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 endchoice

arch/arm/Kconfig +35 -0

index 9292e98..3a86df0 100644
@@ -288,6 +288,9 @@ config TARGET_MX35PDK
 
 config ARCH_BCM283X
 	bool "Broadcom BCM283X family"
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_INTEGRATORAP_CM946ES
 	bool "Support integratorap_cm946es"

@@ -325,21 +328,33 @@ config TARGET_CM_T335
 	bool "Support cm_t335"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_PEPPER
 	bool "Support pepper"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_AM335X_IGEP0033
 	bool "Support am335x_igep0033"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_PCM051
 	bool "Support pcm051"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_DRACO
 	bool "Support draco"

@@ -365,11 +380,17 @@ config TARGET_PENGWYN
 	bool "Support pengwyn"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_AM335X_EVM
 	bool "Support am335x_evm"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_AM43XX_EVM
 	bool "Support am43xx_evm"

@@ -414,10 +435,18 @@ config TARGET_BCMNSP
 config ARCH_EXYNOS
 	bool "Samsung EXYNOS"
 	select CPU_V7
+	select DM
+	select DM_SPI_FLASH
+	select DM_SERIAL
+	select DM_SPI
+	select DM_GPIO
 
 config ARCH_S5PC1XX
 	bool "Samsung S5PC1XX"
 	select CPU_V7
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config ARCH_HIGHBANK
 	bool "Calxeda Highbank"

@@ -619,6 +648,12 @@ config TEGRA
 	select SPL
 	select OF_CONTROL
 	select CPU_V7
+	select DM
+	select DM_SPI_FLASH
+	select DM_SERIAL
+	select DM_I2C
+	select DM_SPI
+	select DM_GPIO
 
 config TARGET_VEXPRESS64_AEMV8A
 	bool "Support vexpress_aemv8a"

arch/arm/cpu/armv7/exynos/Kconfig +0 ~~-15~~

index bd7540a..053235a 100644
@@ -65,21 +65,6 @@ endchoice
 config SYS_SOC
 	default "exynos"
 
-config DM
-	default y
-
-config DM_SERIAL
-	default y
-
-config DM_SPI
-	default y
-
-config DM_SPI_FLASH
-	default y
-
-config DM_GPIO
-	default y
-
 source "board/samsung/smdkv310/Kconfig"
 source "board/samsung/trats/Kconfig"
 source "board/samsung/universal_c210/Kconfig"

arch/arm/cpu/armv7/omap3/Kconfig +18 -9

index 1f96498..cc82c50 100644
@@ -17,6 +17,9 @@ config TARGET_OMAP3_SDP3430
 config TARGET_OMAP3_BEAGLE
 	bool "TI OMAP3 BeagleBoard"
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_CM_T35
 	bool "CompuLab CM-T3530 and CM-T3730 boards"

@@ -28,6 +31,9 @@ config TARGET_CM_T3517
 config TARGET_DEVKIT8000
 	bool "TimLL OMAP3 Devkit8000"
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_OMAP3_EVM
 	bool "TI OMAP3 EVM"

@@ -44,13 +50,22 @@ config TARGET_OMAP3_EVM_QUICK_NAND
 config TARGET_OMAP3_IGEP00X0
 	bool "IGEP"
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_OMAP3_OVERO
 	bool "OMAP35xx Gumstix Overo"
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_OMAP3_ZOOM1
 	bool "TI Zoom1"
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_AM3517_CRANE
 	bool "am3517_crane"

@@ -94,18 +109,12 @@ config TARGET_TWISTER
 config TARGET_OMAP3_CAIRO
 	bool "QUIPOS CAIRO"
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 endchoice
 
-config DM
-	default y
-
-config DM_GPIO
-	default y if DM
-
-config DM_SERIAL
-	default y if DM
-
 config SYS_SOC
 	default "omap3"

arch/arm/mach-bcm283x/Kconfig +0 -9

index b43f2d9..d40f505 100644
@@ -14,15 +14,6 @@ config TARGET_RPI_2
 
 endchoice
 
-config DM
-	default y
-
-config DM_SERIAL
-	default y
-
-config DM_GPIO
-	default y
-
 config SYS_BOARD
 	default "rpi" if TARGET_RPI
 	default "rpi_2" if TARGET_RPI_2

arch/arm/mach-tegra/Kconfig +0 ~~-18~~

index fce1c1d..8bab594 100644
@@ -23,27 +23,9 @@ config SYS_MALLOC_F_LEN
 config USE_PRIVATE_LIBGCC
 	default y
 
-config DM
-	default y
-
 config SPL_DM
 	default y
 
-config DM_SERIAL
-	default y
-
-config DM_SPI
-	default y
-
-config DM_SPI_FLASH
-	default y
-
-config DM_I2C
-	default y
-
-config DM_GPIO
-	default y
-
 source "arch/arm/mach-tegra/tegra20/Kconfig"
 source "arch/arm/mach-tegra/tegra30/Kconfig"
 source "arch/arm/mach-tegra/tegra114/Kconfig"

arch/powerpc/cpu/ppc4xx/Kconfig +2 -0

index 9e52d3f..89cb3e9 100644
@@ -43,6 +43,8 @@ config TARGET_BUBINGA
 
 config TARGET_CANYONLANDS
 	bool "Support canyonlands"
+	select DM
+	select DM_SERIAL
 
 config TARGET_EBONY
 	bool "Support ebony"

arch/sandbox/Kconfig +0 ~~-18~~

index 2098b9c..ffe553e 100644
@@ -10,27 +10,9 @@ config SYS_BOARD
 config SYS_CONFIG_NAME
 	default "sandbox"
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 config DM_CROS_EC
 	default y
 
-config DM_SPI
-	default y
-
-config DM_SPI_FLASH
-	default y
-
-config DM_I2C
-	default y
-
 config DM_TEST
 	default y

arch/x86/Kconfig +0 -9

index da27115..26c91dc 100644
@@ -67,15 +67,6 @@ config TARGET_GALILEO
 
 endchoice
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 config SYS_MALLOC_F_LEN
 	default 0x800

board/amcc/canyonlands/Kconfig +0 -6

index 46efa7a..ef66ad4 100644
@@ -33,10 +33,4 @@ config DISPLAY_BOARDINFO
 	bool
 	default y
 
-config DM
-	default y
-
-config DM_SERIAL
-	default y
-
 endif

board/compulab/cm_t335/Kconfig +0 -9

index 3a8f304..683efde 100644
@@ -12,13 +12,4 @@ config SYS_SOC
 config SYS_CONFIG_NAME
 	default "cm_t335"
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 endif

board/gumstix/pepper/Kconfig +0 -9

index 750db85..6f94612 100644
@@ -12,13 +12,4 @@ config SYS_SOC
 config SYS_CONFIG_NAME
 	default "pepper"
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 endif

board/isee/igep0033/Kconfig +0 -9

index 9a8421e..e989e4b 100644
@@ -12,13 +12,4 @@ config SYS_SOC
 config SYS_CONFIG_NAME
 	default "am335x_igep0033"
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 endif

board/phytec/pcm051/Kconfig +0 -9

index bb98715..2cc0d88 100644
@@ -12,13 +12,4 @@ config SYS_SOC
 config SYS_CONFIG_NAME
 	default "pcm051"
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 endif

board/samsung/goni/Kconfig +0 -9

index 006e864..cbbf5a9 100644
@@ -12,13 +12,4 @@ config SYS_SOC
 config SYS_CONFIG_NAME
 	default "s5p_goni"
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 endif

board/samsung/smdkc100/Kconfig +0 -9

index ea87166..d2157b4 100644
@@ -12,13 +12,4 @@ config SYS_SOC
 config SYS_CONFIG_NAME
 	default "smdkc100"
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 endif

board/silica/pengwyn/Kconfig +0 -9

index 2e9a2b3..f2e1098 100644
@@ -12,13 +12,4 @@ config SYS_SOC
 config SYS_CONFIG_NAME
 	default "pengwyn"
 
-config DM
-	default y
-
-config DM_GPIO
-	default y
-
-config DM_SERIAL
-	default y
-
 endif

board/ti/am335x/Kconfig +0 -9

index 7cb006f..49b73ab 100644
@@ -38,13 +38,4 @@ config NOR_BOOT
 	  as the ROM only partially sets up pinmux.  We also default to using
 	  NOR for environment.
 
-config DM
-	default y
-
-config DM_GPIO
-	default y if DM
-
-config DM_SERIAL
-	default y if DM
-
 endif

configs/am335x_boneblack_vboot_defconfig +0 -1

index 0e39c7d..e4ffe5f 100644
@@ -9,4 +9,3 @@ CONFIG_DEFAULT_DEVICE_TREE="am335x-boneblack"
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y

configs/am3517_crane_defconfig +0 -3

index 72cc2d7..cd16724 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_AM3517_CRANE=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/am3517_evm_defconfig +0 -3

index 6d6b0d2..daf1ae4 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_AM3517_EVM=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/cm_t3517_defconfig +0 -3

index 5c40b90..2d05ffb 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=n
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_CM_T3517=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/cm_t35_defconfig +0 -3

index 4a99263..63a85b4 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_CM_T35=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/devkit8000_defconfig +0 -3

index 9756461..84a1a25 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_DEVKIT8000=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
-CONFIG_DM_GPIO=y

configs/dig297_defconfig +0 -3

index 0d18290..95bc353 100644
@@ -1,6 +1,3 @@
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_DIG297=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/eco5pk_defconfig +0 -3

index fbe6335..8587c51 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_ECO5PK=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/mcx_defconfig +0 -3

index 2f61858..4abf34d 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_MCX=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/mt_ventoux_defconfig +0 -3

index 5b1da8c..fd4f649 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_MT_VENTOUX=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/nokia_rx51_defconfig +0 -3

index 20a51e1..e03f586 100644
@@ -1,6 +1,3 @@
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_NOKIA_RX51=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/omap3_beagle_defconfig +0 -3

index 5106821..2a3cc66 100644
@@ -3,6 +3,3 @@ CONFIG_SYS_EXTRA_OPTIONS="NAND"
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_OMAP3_BEAGLE=y
-CONFIG_DM=y
-CONFIG_DM_GPIO=y
-CONFIG_DM_SERIAL=y

configs/omap3_evm_defconfig +0 -3

index fb4a800..91c290b 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_OMAP3_EVM=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/omap3_evm_quick_mmc_defconfig +0 -3

index d4594cb..12005bf 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_OMAP3_EVM_QUICK_MMC=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/omap3_evm_quick_nand_defconfig +0 -3

index 1a78a6e..5cc9512 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_OMAP3_EVM_QUICK_NAND=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/omap3_ha_defconfig +0 -3

index 344eca5..250890b 100644
@@ -3,6 +3,3 @@ CONFIG_SYS_EXTRA_OPTIONS="SYS_BOARD_OMAP3_HA"
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_TAO3530=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/omap3_logic_defconfig +0 -3

index 790ccba..5f2c063 100644
@@ -1,6 +1,3 @@
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_OMAP3_LOGIC=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/omap3_mvblx_defconfig +0 -3

index b75f513..fb6edc2 100644
@@ -1,6 +1,3 @@
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_OMAP3_MVBLX=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/omap3_pandora_defconfig +0 -3

index dd0f17c..bf28537 100644
@@ -1,6 +1,3 @@
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_OMAP3_PANDORA=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/omap3_sdp3430_defconfig +0 -3

index b3a8745..1172c2a 100644
@@ -1,6 +1,3 @@
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_OMAP3_SDP3430=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/sandbox_defconfig +0 -1

index a216039..66c7d8a 100644
@@ -3,7 +3,6 @@ CONFIG_OF_HOSTFILE=y
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y
 CONFIG_DEFAULT_DEVICE_TREE="sandbox"
 CONFIG_CROS_EC=y
 CONFIG_DM_CROS_EC=y

configs/tao3530_defconfig +0 -3

index 077dc89..86ba4cd 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_TAO3530=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/tricorder_defconfig +0 -3

index 745ebc8..e307c65 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_TRICORDER=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/tricorder_flash_defconfig +0 -3

index cc93566..de6c16e 100644
@@ -3,6 +3,3 @@ CONFIG_SYS_EXTRA_OPTIONS="FLASHCARD"
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_TRICORDER=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

configs/twister_defconfig +0 -3

index 5e7250a..344369d 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_ARM=y
 CONFIG_OMAP34XX=y
 CONFIG_TARGET_TWISTER=y
-CONFIG_DM=n
-CONFIG_DM_SERIAL=n
-CONFIG_DM_GPIO=n

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #10 lore raw

PATCH 2/12 dm: select CONFIG_DM* options

Quoted 75 lines · Masahiro Yamada

As mentioned in the previous commit, adding default values in each Kconfig causes problems because it does not co-exist with the "depends on" syntax. (Please note this is not a bug of Kconfig.) We should not do so unless we have a special reason. Actually, for CONFIG_DM*, we have no good reason to do so.
Generally, CONFIG_DM is not a user-configurable option. Once we convert a driver into Driver Model, the board only works with Driver Model, i.e. CONFIG_DM must be always enabled for that board. So, using "select DM" is more suitable rather than allowing users to modify it. Another good thing is, Kconfig warns unmet dependencies for "select" syntax, so we easily notice bugs.
Actually, CONFIG_DM and other related options have been added without consistency: some into arch/*/Kconfig, some into board/*/Kconfig, and some into configs/*_defconfig.
This commit prefers "select" and cleans up the following issues.
[1] Never use "CONFIG_DM=n" in defconfig files
It is really rare to add "CONFIG_FOO=n" to disable CONFIG options. It is more common to use "# CONFIG_FOO is not set". But here, we do not even have to do it.
Less than half of OMAP3 boards have been converted to Driver Model. Adding the default values to arch/arm/cpu/armv7/omap3/Kconfig is weird. Instead, add "select DM" only to appropriate boards, which eventually eliminates "CONFIG_DM=n", etc.
[2] Delete redundant CONFIGs
Sandbox sets CONFIG_DM in arch/sandbox/Kconfig and defines it again in configs/sandbox_defconfig.
Likewise, OMAP3 sets CONFIG_DM arch/arm/cpu/armv7/omap3/Kconfig and defines it also in omap3_beagle_defconfig and devkit8000_defconfig.
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/Kconfig                             |  9 ++++++++
 arch/arm/Kconfig                         | 35 ++++++++++++++++++++++++++++++++
 arch/arm/cpu/armv7/exynos/Kconfig        | 15 --------------
 arch/arm/cpu/armv7/omap3/Kconfig         | 27 ++++++++++++++++--------
 arch/arm/mach-bcm283x/Kconfig            |  9 --------
 arch/arm/mach-tegra/Kconfig              | 18 ----------------
 arch/powerpc/cpu/ppc4xx/Kconfig          |  2 ++
 arch/sandbox/Kconfig                     | 18 ----------------
 arch/x86/Kconfig                         |  9 --------
 board/amcc/canyonlands/Kconfig           |  6 ------
 board/compulab/cm_t335/Kconfig           |  9 --------
 board/gumstix/pepper/Kconfig             |  9 --------
 board/isee/igep0033/Kconfig              |  9 --------
 board/phytec/pcm051/Kconfig              |  9 --------
 board/samsung/goni/Kconfig               |  9 --------
 board/samsung/smdkc100/Kconfig           |  9 --------
 board/silica/pengwyn/Kconfig             |  9 --------
 board/ti/am335x/Kconfig                  |  9 --------
 configs/am335x_boneblack_vboot_defconfig |  1 -
 configs/am3517_crane_defconfig           |  3 ---
 configs/am3517_evm_defconfig             |  3 ---
 configs/cm_t3517_defconfig               |  3 ---
 configs/cm_t35_defconfig                 |  3 ---
 configs/devkit8000_defconfig             |  3 ---
 configs/dig297_defconfig                 |  3 ---
 configs/eco5pk_defconfig                 |  3 ---
 configs/mcx_defconfig                    |  3 ---
 configs/mt_ventoux_defconfig             |  3 ---
 configs/nokia_rx51_defconfig             |  3 ---
 configs/omap3_beagle_defconfig           |  3 ---
 configs/omap3_evm_defconfig              |  3 ---
 configs/omap3_evm_quick_mmc_defconfig    |  3 ---
 configs/omap3_evm_quick_nand_defconfig   |  3 ---
 configs/omap3_ha_defconfig               |  3 ---
 configs/omap3_logic_defconfig            |  3 ---
 configs/omap3_mvblx_defconfig            |  3 ---

Quoted 8 lines

 configs/omap3_pandora_defconfig          |  3 ---
 configs/omap3_sdp3430_defconfig          |  3 ---
 configs/sandbox_defconfig                |  1 -
 configs/tao3530_defconfig                |  3 ---
 configs/tricorder_defconfig              |  3 ---
 configs/tricorder_flash_defconfig        |  3 ---
 configs/twister_defconfig                |  3 ---
 43 files changed, 64 insertions(+), 227 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:01 UTC #11 lore raw

PATCH 2/12 dm: select CONFIG_DM* options

Quoted 86 lines · Simon Glass

Quoted 75 lines · Masahiro Yamada
As mentioned in the previous commit, adding default values in each Kconfig causes problems because it does not co-exist with the "depends on" syntax. (Please note this is not a bug of Kconfig.) We should not do so unless we have a special reason. Actually, for CONFIG_DM*, we have no good reason to do so.
Generally, CONFIG_DM is not a user-configurable option. Once we convert a driver into Driver Model, the board only works with Driver Model, i.e. CONFIG_DM must be always enabled for that board. So, using "select DM" is more suitable rather than allowing users to modify it. Another good thing is, Kconfig warns unmet dependencies for "select" syntax, so we easily notice bugs.
Actually, CONFIG_DM and other related options have been added without consistency: some into arch/*/Kconfig, some into board/*/Kconfig, and some into configs/*_defconfig.
This commit prefers "select" and cleans up the following issues.
[1] Never use "CONFIG_DM=n" in defconfig files
It is really rare to add "CONFIG_FOO=n" to disable CONFIG options. It is more common to use "# CONFIG_FOO is not set". But here, we do not even have to do it.
Less than half of OMAP3 boards have been converted to Driver Model. Adding the default values to arch/arm/cpu/armv7/omap3/Kconfig is weird. Instead, add "select DM" only to appropriate boards, which eventually eliminates "CONFIG_DM=n", etc.
[2] Delete redundant CONFIGs
Sandbox sets CONFIG_DM in arch/sandbox/Kconfig and defines it again in configs/sandbox_defconfig.
Likewise, OMAP3 sets CONFIG_DM arch/arm/cpu/armv7/omap3/Kconfig and defines it also in omap3_beagle_defconfig and devkit8000_defconfig.
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/Kconfig                             |  9 ++++++++
 arch/arm/Kconfig                         | 35 ++++++++++++++++++++++++++++++++
 arch/arm/cpu/armv7/exynos/Kconfig        | 15 --------------
 arch/arm/cpu/armv7/omap3/Kconfig         | 27 ++++++++++++++++--------
 arch/arm/mach-bcm283x/Kconfig            |  9 --------
 arch/arm/mach-tegra/Kconfig              | 18 ----------------
 arch/powerpc/cpu/ppc4xx/Kconfig          |  2 ++
 arch/sandbox/Kconfig                     | 18 ----------------
 arch/x86/Kconfig                         |  9 --------
 board/amcc/canyonlands/Kconfig           |  6 ------
 board/compulab/cm_t335/Kconfig           |  9 --------
 board/gumstix/pepper/Kconfig             |  9 --------
 board/isee/igep0033/Kconfig              |  9 --------
 board/phytec/pcm051/Kconfig              |  9 --------
 board/samsung/goni/Kconfig               |  9 --------
 board/samsung/smdkc100/Kconfig           |  9 --------
 board/silica/pengwyn/Kconfig             |  9 --------
 board/ti/am335x/Kconfig                  |  9 --------
 configs/am335x_boneblack_vboot_defconfig |  1 -
 configs/am3517_crane_defconfig           |  3 ---
 configs/am3517_evm_defconfig             |  3 ---
 configs/cm_t3517_defconfig               |  3 ---
 configs/cm_t35_defconfig                 |  3 ---
 configs/devkit8000_defconfig             |  3 ---
 configs/dig297_defconfig                 |  3 ---
 configs/eco5pk_defconfig                 |  3 ---
 configs/mcx_defconfig                    |  3 ---
 configs/mt_ventoux_defconfig             |  3 ---
 configs/nokia_rx51_defconfig             |  3 ---
 configs/omap3_beagle_defconfig           |  3 ---
 configs/omap3_evm_defconfig              |  3 ---
 configs/omap3_evm_quick_mmc_defconfig    |  3 ---
 configs/omap3_evm_quick_nand_defconfig   |  3 ---
 configs/omap3_ha_defconfig               |  3 ---
 configs/omap3_logic_defconfig            |  3 ---
 configs/omap3_mvblx_defconfig            |  3 ---
Quoted 8 lines
 configs/omap3_pandora_defconfig          |  3 ---
 configs/omap3_sdp3430_defconfig          |  3 ---
 configs/sandbox_defconfig                |  1 -
 configs/tao3530_defconfig                |  3 ---
 configs/tricorder_defconfig              |  3 ---
 configs/tricorder_flash_defconfig        |  3 ---
 configs/twister_defconfig                |  3 ---
 43 files changed, 64 insertions(+), 227 deletions(-)

Quoted 1 line

Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:47 UTC #12 lore raw

PATCH 3/12 ARM: UniPhier: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

All the UniPhier boards have switch to Driver Model. "select DM" is better than default value in each defconfig.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig           | 3 +++
 configs/ph1_ld4_defconfig  | 3 ---
 configs/ph1_pro4_defconfig | 3 ---
 configs/ph1_sld8_defconfig | 3 ---
 4 files changed, 3 insertions(+), 9 deletions(-)

arch/arm/Kconfig +3 -0

index 3a86df0..2d583c9 100644
@@ -748,6 +748,9 @@ config ARCH_UNIPHIER
 	select SUPPORT_SPL
 	select SPL
 	select OF_CONTROL
+	select DM
+	select DM_SERIAL
+	select DM_I2C
 
 endchoice

configs/ph1_ld4_defconfig +0 -3

index aa1805b..036e2d1 100644
@@ -1,9 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_UNIPHIER=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SPL_DM=y
-CONFIG_DM_I2C=y
 CONFIG_MACH_PH1_LD4=y
 CONFIG_PFC_MICRO_SUPPORT_CARD=y
 CONFIG_DEFAULT_DEVICE_TREE="uniphier-ph1-ld4-ref"

configs/ph1_pro4_defconfig +0 -3

index 194f7a5..9a010ee 100644
@@ -1,9 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_UNIPHIER=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SPL_DM=y
-CONFIG_DM_I2C=y
 CONFIG_MACH_PH1_PRO4=y
 CONFIG_PFC_MICRO_SUPPORT_CARD=y
 CONFIG_DEFAULT_DEVICE_TREE="uniphier-ph1-pro4-ref"

configs/ph1_sld8_defconfig +0 -3

index e7e7fff..29fe0e8 100644
@@ -1,9 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_UNIPHIER=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SPL_DM=y
-CONFIG_DM_I2C=y
 CONFIG_MACH_PH1_SLD8=y
 CONFIG_PFC_MICRO_SUPPORT_CARD=y
 CONFIG_DEFAULT_DEVICE_TREE="uniphier-ph1-sld8-ref"

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #13 lore raw

PATCH 3/12 ARM: UniPhier: use "select" instead of default value in defconfig

Quoted 11 lines · Masahiro Yamada

All the UniPhier boards have switch to Driver Model. "select DM" is better than default value in each defconfig.
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig           | 3 +++
 configs/ph1_ld4_defconfig  | 3 ---
 configs/ph1_pro4_defconfig | 3 ---
 configs/ph1_sld8_defconfig | 3 ---
 4 files changed, 3 insertions(+), 9 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:01 UTC #14 lore raw

PATCH 3/12 ARM: UniPhier: use "select" instead of default value in defconfig

Quoted 8 lines · Simon Glass

Quoted 6 lines · Masahiro Yamada
All the UniPhier boards have switch to Driver Model. "select DM" is better than default value in each defconfig.
Signed-off-by Masahiro Yamada <[email protected]>
---

Quoted 7 lines

Quoted 5 lines

 arch/arm/Kconfig           | 3 +++
 configs/ph1_ld4_defconfig  | 3 ---
 configs/ph1_pro4_defconfig | 3 ---
 configs/ph1_sld8_defconfig | 3 ---
 4 files changed, 3 insertions(+), 9 deletions(-)

Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:47 UTC #15 lore raw

PATCH 4/12 ARM: zynq: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

All the Zynq boards have switch to Driver Model. "select DM" is better than default value in each defconfig.

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 1 +
 configs/zynq_microzed_defconfig    | 1 -
 configs/zynq_zc70x_defconfig       | 1 -
 configs/zynq_zc770_xm010_defconfig | 1 -
 configs/zynq_zc770_xm012_defconfig | 1 -
 configs/zynq_zc770_xm013_defconfig | 1 -
 configs/zynq_zed_defconfig         | 1 -
 configs/zynq_zybo_defconfig        | 1 -
 8 files changed, 1 insertion(+), 7 deletions(-)

arch/arm/Kconfig +1 -0

index 2d583c9..ad8232c 100644
@@ -637,6 +637,7 @@ config ZYNQ
 	bool "Xilinx Zynq Platform"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
 
 config TARGET_XILINX_ZYNQMP
 	bool "Support Xilinx ZynqMP Platform"

configs/zynq_microzed_defconfig +0 -1

index 39a7f6b..f5c1dff 100644
@@ -6,5 +6,4 @@ CONFIG_OF_CONTROL=y
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y
 CONFIG_DEFAULT_DEVICE_TREE="zynq-microzed"

configs/zynq_zc70x_defconfig +0 -1

index a8ef97f..a599bb1 100644
@@ -7,4 +7,3 @@ CONFIG_DEFAULT_DEVICE_TREE="zynq-zc702"
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y

configs/zynq_zc770_xm010_defconfig +0 -1

index ecd245a..92bc76e 100644
@@ -8,4 +8,3 @@ CONFIG_DEFAULT_DEVICE_TREE="zynq-zc770-xm010"
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y

configs/zynq_zc770_xm012_defconfig +0 -1

index 341a4d8..93d32a4 100644
@@ -8,4 +8,3 @@ CONFIG_DEFAULT_DEVICE_TREE="zynq-zc770-xm012"
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y

configs/zynq_zc770_xm013_defconfig +0 -1

index ee08a9f..9810cb4 100644
@@ -8,4 +8,3 @@ CONFIG_DEFAULT_DEVICE_TREE="zynq-zc770-xm013"
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y

configs/zynq_zed_defconfig +0 -1

index 2500d84..3200253 100644
@@ -7,4 +7,3 @@ CONFIG_DEFAULT_DEVICE_TREE="zynq-zed"
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y

configs/zynq_zybo_defconfig +0 -1

index c9d0121..aaa6cec 100644
@@ -7,4 +7,3 @@ CONFIG_DEFAULT_DEVICE_TREE="zynq-zybo"
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_FIT_SIGNATURE=y
-CONFIG_DM=y

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #16 lore raw

PATCH 4/12 ARM: zynq: use "select" instead of default value in defconfig

Quoted 6 lines · Masahiro Yamada

All the Zynq boards have switch to Driver Model. "select DM" is better than default value in each defconfig.
Signed-off-by Masahiro Yamada <[email protected]>
---

Quoted 9 lines

 arch/arm/Kconfig                   | 1 +
 configs/zynq_microzed_defconfig    | 1 -
 configs/zynq_zc70x_defconfig       | 1 -
 configs/zynq_zc770_xm010_defconfig | 1 -
 configs/zynq_zc770_xm012_defconfig | 1 -
 configs/zynq_zc770_xm013_defconfig | 1 -
 configs/zynq_zed_defconfig         | 1 -
 configs/zynq_zybo_defconfig        | 1 -
 8 files changed, 1 insertion(+), 7 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #17 lore raw

PATCH 4/12 ARM: zynq: use "select" instead of default value in defconfig

Quoted 18 lines · Simon Glass

Quoted 6 lines · Masahiro Yamada
All the Zynq boards have switch to Driver Model. "select DM" is better than default value in each defconfig.
Signed-off-by Masahiro Yamada <[email protected]>
---
Quoted 9 lines
 arch/arm/Kconfig                   | 1 +
 configs/zynq_microzed_defconfig    | 1 -
 configs/zynq_zc70x_defconfig       | 1 -
 configs/zynq_zc770_xm010_defconfig | 1 -
 configs/zynq_zc770_xm012_defconfig | 1 -
 configs/zynq_zc770_xm013_defconfig | 1 -
 configs/zynq_zed_defconfig         | 1 -
 configs/zynq_zybo_defconfig        | 1 -
 8 files changed, 1 insertion(+), 7 deletions(-)

Quoted 1 line

Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:47 UTC #18 lore raw

PATCH 5/12 ARM: rmobile: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/cpu/armv7/rmobile/Kconfig | 12 ++++++++++++
 configs/alt_defconfig              |  2 --
 configs/gose_defconfig             |  2 --
 configs/koelsch_defconfig          |  2 --
 configs/lager_defconfig            |  2 --
 configs/porter_defconfig           |  2 --
 configs/silk_defconfig             |  2 --
 7 files changed, 12 insertions(+), 12 deletions(-)

arch/arm/cpu/armv7/rmobile/Kconfig +12 -0

index 2b333a3..57dccec 100644
@@ -8,24 +8,36 @@ config TARGET_ARMADILLO_800EVA
 
 config TARGET_GOSE
 	bool "Gose board"
+	select DM
+	select DM_SERIAL
 
 config TARGET_KOELSCH
 	bool "Koelsch board"
+	select DM
+	select DM_SERIAL
 
 config TARGET_LAGER
 	bool "Lager board"
+	select DM
+	select DM_SERIAL
 
 config TARGET_KZM9G
 	bool "KZM9D board"
 
 config TARGET_ALT
 	bool "Alt board"
+	select DM
+	select DM_SERIAL
 
 config TARGET_SILK
 	bool "Silk board"
+	select DM
+	select DM_SERIAL
 
 config TARGET_PORTER
 	bool "Porter board"
+	select DM
+	select DM_SERIAL
 
 endchoice

configs/alt_defconfig +0 -2

index ff87230..0a18409 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
 CONFIG_RMOBILE=y
 CONFIG_TARGET_ALT=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SH_SDHI=y

configs/gose_defconfig +0 -2

index 353f854..b6054f7 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
 CONFIG_RMOBILE=y
 CONFIG_TARGET_GOSE=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SH_SDHI=y

configs/koelsch_defconfig +0 -2

index b1e3529..7ab2bfd 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
 CONFIG_RMOBILE=y
 CONFIG_TARGET_KOELSCH=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SH_SDHI=y

configs/lager_defconfig +0 -2

index 950b037..08adfe3 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
 CONFIG_RMOBILE=y
 CONFIG_TARGET_LAGER=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SH_SDHI=y

configs/porter_defconfig +0 -2

index 8d594d9..a7b044e 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
 CONFIG_RMOBILE=y
 CONFIG_TARGET_PORTER=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SH_SDHI=y

configs/silk_defconfig +0 -2

index 23d4f58..3c6f16e 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
 CONFIG_RMOBILE=y
 CONFIG_TARGET_SILK=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
 CONFIG_SH_SDHI=y

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #19 lore raw

PATCH 5/12 ARM: rmobile: use "select" instead of default value in defconfig

Quoted 11 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/cpu/armv7/rmobile/Kconfig | 12 ++++++++++++
 configs/alt_defconfig              |  2 --
 configs/gose_defconfig             |  2 --
 configs/koelsch_defconfig          |  2 --
 configs/lager_defconfig            |  2 --
 configs/porter_defconfig           |  2 --
 configs/silk_defconfig             |  2 --
 7 files changed, 12 insertions(+), 12 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #20 lore raw

PATCH 5/12 ARM: rmobile: use "select" instead of default value in defconfig

Quoted 14 lines · Simon Glass

Quoted 11 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/cpu/armv7/rmobile/Kconfig | 12 ++++++++++++
 configs/alt_defconfig              |  2 --
 configs/gose_defconfig             |  2 --
 configs/koelsch_defconfig          |  2 --
 configs/lager_defconfig            |  2 --
 configs/porter_defconfig           |  2 --
 configs/silk_defconfig             |  2 --
 7 files changed, 12 insertions(+), 12 deletions(-)

Quoted 1 line

Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:47 UTC #21 lore raw

PATCH 6/12 ARM: snapper9260: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/mach-at91/Kconfig    | 3 +++
 configs/snapper9260_defconfig | 3 ---
 configs/snapper9g20_defconfig | 3 ---
 3 files changed, 3 insertions(+), 6 deletions(-)

arch/arm/mach-at91/Kconfig +3 -0

index 30945c1..193f4d1 100644
@@ -30,6 +30,9 @@ config TARGET_TNY_A9260
 config TARGET_SNAPPER9260
 	bool "Support snapper9260"
 	select CPU_ARM926EJS
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_AFEB9260
 	bool "Support afeb9260"

configs/snapper9260_defconfig +0 -3

index 576d9c5..5c8850a 100644
@@ -2,6 +2,3 @@ CONFIG_SYS_EXTRA_OPTIONS="AT91SAM9260"
 CONFIG_ARM=y
 CONFIG_ARCH_AT91=y
 CONFIG_TARGET_SNAPPER9260=y
-CONFIG_DM=y
-CONFIG_DM_GPIO=y
-CONFIG_DM_SERIAL=y

configs/snapper9g20_defconfig +0 -3

index 07a2643..9270b8d 100644
@@ -2,6 +2,3 @@ CONFIG_SYS_EXTRA_OPTIONS="AT91SAM9G20"
 CONFIG_ARM=y
 CONFIG_ARCH_AT91=y
 CONFIG_TARGET_SNAPPER9260=y
-CONFIG_DM=y
-CONFIG_DM_GPIO=y
-CONFIG_DM_SERIAL=y

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #22 lore raw

PATCH 6/12 ARM: snapper9260: use "select" instead of default value in defconfig

Quoted 7 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/mach-at91/Kconfig    | 3 +++
 configs/snapper9260_defconfig | 3 ---
 configs/snapper9g20_defconfig | 3 ---
 3 files changed, 3 insertions(+), 6 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #23 lore raw

PATCH 6/12 ARM: snapper9260: use "select" instead of default value in defconfig

Quoted 11 lines · Simon Glass

Quoted 7 lines · Masahiro Yamada
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/mach-at91/Kconfig    | 3 +++
 configs/snapper9260_defconfig | 3 ---
 configs/snapper9g20_defconfig | 3 ---
 3 files changed, 3 insertions(+), 6 deletions(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:47 UTC #24 lore raw

PATCH 7/12 ARM: mx6: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 6 ++++++
 configs/mx6dlsabreauto_defconfig   | 2 --
 configs/mx6dlsabresd_defconfig     | 2 --
 configs/mx6qsabreauto_defconfig    | 2 --
 configs/mx6qsabresd_defconfig      | 2 --
 configs/mx6sabresd_spl_defconfig   | 2 --
 configs/mx6sxsabresd_defconfig     | 2 --
 configs/mx6sxsabresd_spl_defconfig | 2 --
 8 files changed, 6 insertions(+), 14 deletions(-)

arch/arm/Kconfig +6 -0

index ad8232c..b25a4a9 100644
@@ -533,11 +533,15 @@ config TARGET_MX6QARM2
 config TARGET_MX6QSABREAUTO
 	bool "Support mx6qsabreauto"
 	select CPU_V7
+	select DM
+	select DM_THERMAL
 
 config TARGET_MX6SABRESD
 	bool "Support mx6sabresd"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_THERMAL
 
 config TARGET_MX6SLEVK
 	bool "Support mx6slevk"

@@ -547,6 +551,8 @@ config TARGET_MX6SXSABRESD
 	bool "Support mx6sxsabresd"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_THERMAL
 
 config TARGET_GW_VENTANA
 	bool "Support gw_ventana"

configs/mx6dlsabreauto_defconfig +0 -2

index 8bc5e8b..b649935 100644
@@ -1,5 +1,3 @@
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6qsabreauto/mx6dl.cfg,MX6DL"
 CONFIG_ARM=y
 CONFIG_TARGET_MX6QSABREAUTO=y
-CONFIG_DM=y
-CONFIG_DM_THERMAL=y

configs/mx6dlsabresd_defconfig +0 -2

index 6adfd55..7f6cdff 100644
@@ -1,5 +1,3 @@
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6sabresd/mx6dlsabresd.cfg,MX6DL"
 CONFIG_ARM=y
 CONFIG_TARGET_MX6SABRESD=y
-CONFIG_DM=y
-CONFIG_DM_THERMAL=y

configs/mx6qsabreauto_defconfig +0 -2

index ba9e512..7d86700 100644
@@ -1,5 +1,3 @@
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6qsabreauto/imximage.cfg,MX6Q"
 CONFIG_ARM=y
 CONFIG_TARGET_MX6QSABREAUTO=y
-CONFIG_DM=y
-CONFIG_DM_THERMAL=y

configs/mx6qsabresd_defconfig +0 -2

index 1764b39..67c1b77 100644
@@ -1,5 +1,3 @@
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6sabresd/mx6q_4x_mt41j128.cfg,MX6Q"
 CONFIG_ARM=y
 CONFIG_TARGET_MX6SABRESD=y
-CONFIG_DM=y
-CONFIG_DM_THERMAL=y

configs/mx6sabresd_spl_defconfig +0 -2

index 16a947e..7f563cd 100644
@@ -2,5 +2,3 @@ CONFIG_SPL=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,SPL,MX6Q"
 CONFIG_ARM=y
 CONFIG_TARGET_MX6SABRESD=y
-CONFIG_DM=y
-CONFIG_DM_THERMAL=y

configs/mx6sxsabresd_defconfig +0 -2

index 5c862cf..f23d48f 100644
@@ -1,5 +1,3 @@
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx6sxsabresd/imximage.cfg,MX6SX"
 CONFIG_ARM=y
 CONFIG_TARGET_MX6SXSABRESD=y
-CONFIG_DM=y
-CONFIG_DM_THERMAL=y

configs/mx6sxsabresd_spl_defconfig +0 -2

index de3d98f..b5e0635 100644
@@ -2,5 +2,3 @@ CONFIG_SPL=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6SX"
 CONFIG_ARM=y
 CONFIG_TARGET_MX6SXSABRESD=y
-CONFIG_DM=y
-CONFIG_DM_THERMAL=y

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #25 lore raw

PATCH 7/12 ARM: mx6: use "select" instead of default value in defconfig

Quoted 12 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 6 ++++++
 configs/mx6dlsabreauto_defconfig   | 2 --
 configs/mx6dlsabresd_defconfig     | 2 --
 configs/mx6qsabreauto_defconfig    | 2 --
 configs/mx6qsabresd_defconfig      | 2 --
 configs/mx6sabresd_spl_defconfig   | 2 --
 configs/mx6sxsabresd_defconfig     | 2 --
 configs/mx6sxsabresd_spl_defconfig | 2 --
 8 files changed, 6 insertions(+), 14 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #26 lore raw

PATCH 7/12 ARM: mx6: use "select" instead of default value in defconfig

Quoted 15 lines · Simon Glass

Quoted 12 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 6 ++++++
 configs/mx6dlsabreauto_defconfig   | 2 --
 configs/mx6dlsabresd_defconfig     | 2 --
 configs/mx6qsabreauto_defconfig    | 2 --
 configs/mx6qsabresd_defconfig      | 2 --
 configs/mx6sabresd_spl_defconfig   | 2 --
 configs/mx6sxsabresd_defconfig     | 2 --
 configs/mx6sxsabresd_spl_defconfig | 2 --
 8 files changed, 6 insertions(+), 14 deletions(-)

Quoted 1 line

Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:47 UTC #27 lore raw

PATCH 8/12 ARM: socfpga: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 6 ++++++
 configs/socfpga_arria5_defconfig   | 3 ---
 configs/socfpga_cyclone5_defconfig | 3 ---
 configs/socfpga_socrates_defconfig | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)

arch/arm/Kconfig +6 -0

index b25a4a9..6ae48c6 100644
@@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
 	bool "Support socfpga_arria5"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SPI_FLASH
+	select DM_SPI
 
 config TARGET_SOCFPGA_CYCLONE5
 	bool "Support socfpga_cyclone5"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SPI_FLASH
+	select DM_SPI
 
 config ARCH_SUNXI
 	bool "Support sunxi (Allwinner) SoCs"

configs/socfpga_arria5_defconfig +0 -3

index 87d6007..52032e5 100644
@@ -3,6 +3,3 @@ CONFIG_ARM=y
 CONFIG_TARGET_SOCFPGA_ARRIA5=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="socfpga_arria5_socdk"
-CONFIG_DM=y
-CONFIG_DM_SPI=y
-CONFIG_DM_SPI_FLASH=y

configs/socfpga_cyclone5_defconfig +0 -3

index 0ebfbfc..56b6183 100644
@@ -3,6 +3,3 @@ CONFIG_ARM=y
 CONFIG_TARGET_SOCFPGA_CYCLONE5=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="socfpga_cyclone5_socdk"
-CONFIG_DM=y
-CONFIG_DM_SPI=y
-CONFIG_DM_SPI_FLASH=y

configs/socfpga_socrates_defconfig +0 -3

index 873b721..d68b9cc 100644
@@ -3,6 +3,3 @@ CONFIG_ARM=y
 CONFIG_TARGET_SOCFPGA_CYCLONE5=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="socfpga_cyclone5_socrates"
-CONFIG_DM=y
-CONFIG_DM_SPI=y
-CONFIG_DM_SPI_FLASH=y

Signature · 1 line

1.9.1

Pavel Machek

2015-03-31 20:40 UTC #28 lore raw

PATCH 8/12 ARM: socfpga: use "select" instead of default value in defconfig

Hi!

Quoted 14 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 6 ++++++
 configs/socfpga_arria5_defconfig   | 3 ---
 configs/socfpga_cyclone5_defconfig | 3 ---
 configs/socfpga_socrates_defconfig | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)

arch/arm/Kconfig +0 -0

index b25a4a9..6ae48c6 100644

arch/arm/Kconfig config TARGET_SOCFPGA_ARRIA5 · line 624

Quoted 7 lines

arch/arm/Kconfig +3 -0

@@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
 	bool "Support socfpga_arria5"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SPI_FLASH
+	select DM_SPI

Are you sure?

config DM_SPI_FLASH
bool "Enable Driver Model for SPI flash"
depends on DM && SPI
help

DM_SPI_FLASH depends on SPI, you can't just select it...

Pavel

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Masahiro Yamada

author

2015-04-02 00:30 UTC #29 lore raw

PATCH 8/12 ARM: socfpga: use "select" instead of default value in defconfig

Hi Pavel,

2015-04-01 5:40 GMT+09:00 Pavel Machek <[email protected]>:

Quoted 11 lines

Hi!

Quoted 9 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 6 ++++++
 configs/socfpga_arria5_defconfig   | 3 ---
 configs/socfpga_cyclone5_defconfig | 3 ---
 configs/socfpga_socrates_defconfig | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)

Quoted 14 lines

arch/arm/Kconfig config TARGET_SOCFPGA_ARRIA5 · line 624

Quoted 12 lines

arch/arm/Kconfig +3 -0

index b25a4a9..6ae48c6 100644
@@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
      bool "Support socfpga_arria5"
      select CPU_V7
      select SUPPORT_SPL
+     select DM
+     select DM_SPI_FLASH
+     select DM_SPI

Are you sure?

Yes, I'm sure.

Quoted 7 lines

config DM_SPI_FLASH
bool "Enable Driver Model for SPI flash"
depends on DM && SPI
help
DM_SPI_FLASH depends on SPI, you can't just select it...

This dependency is wrong.
Before this patch, it must be fixed.

Please see 01/12 of this series:
http://patchwork.ozlabs.org/patch/456458/

Signature · 2 lines

Best Regards
Masahiro Yamada

Pavel Machek

2015-04-02 12:47 UTC #30 lore raw

PATCH 8/12 ARM: socfpga: use "select" instead of default value in defconfig

Hi!

Quoted 34 lines

Quoted 9 lines
Quoted 9 lines
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig                   | 6 ++++++
 configs/socfpga_arria5_defconfig   | 3 ---
 configs/socfpga_cyclone5_defconfig | 3 ---
 configs/socfpga_socrates_defconfig | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)
Quoted 13 lines
arch/arm/Kconfig config TARGET_SOCFPGA_ARRIA5 · line 623
Quoted 11 lines
arch/arm/Kconfig +3 -0
index b25a4a9..6ae48c6 100644
@@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
      bool "Support socfpga_arria5"
      select CPU_V7
      select SUPPORT_SPL
+     select DM
+     select DM_SPI_FLASH
+     select DM_SPI
Are you sure?
Yes, I'm sure.
Quoted 7 lines
config DM_SPI_FLASH
bool "Enable Driver Model for SPI flash"
depends on DM && SPI
help
DM_SPI_FLASH depends on SPI, you can't just select it...

Quoted 5 lines

This dependency is wrong.
Before this patch, it must be fixed.
Please see 01/12 of this series:
http://patchwork.ozlabs.org/patch/456458/

But I'm not sure.

With this, you made CONFIG_DM_SPI_FLASH mandatory... even for users that have no SPI flash. There must be better solution...?

Pavel

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Masahiro Yamada

author

2015-04-06 03:22 UTC #31 lore raw

PATCH 8/12 ARM: socfpga: use "select" instead of default value in defconfig

Hi Pavel,

2015-04-02 21:47 GMT+09:00 Pavel Machek <[email protected]>:

Quoted 39 lines

Hi!
Quoted 37 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig                   | 6 ++++++
 configs/socfpga_arria5_defconfig   | 3 ---
 configs/socfpga_cyclone5_defconfig | 3 ---
 configs/socfpga_socrates_defconfig | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)
Quoted 13 lines
arch/arm/Kconfig config TARGET_SOCFPGA_ARRIA5 · line 623
Quoted 11 lines
arch/arm/Kconfig +3 -0
index b25a4a9..6ae48c6 100644
@@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
      bool "Support socfpga_arria5"
      select CPU_V7
      select SUPPORT_SPL
+     select DM
+     select DM_SPI_FLASH
+     select DM_SPI
Are you sure?
Yes, I'm sure.
Quoted 7 lines
config DM_SPI_FLASH
bool "Enable Driver Model for SPI flash"
depends on DM && SPI
help
DM_SPI_FLASH depends on SPI, you can't just select it...
This dependency is wrong.
Before this patch, it must be fixed.

Quoted 7 lines

Quoted 2 lines
Please see 01/12 of this series:
http://patchwork.ozlabs.org/patch/456458/
But I'm not sure.
With this, you made CONFIG_DM_SPI_FLASH mandatory... even for users that have no SPI flash. There must be better solution...?

In my opinion,

CONFIG_DM_* should be user-unconfigurable.

CONFIG_DM_* should not enable/disable a feature,
but should define how it is implemented.

For example,

!defined(CONFIG_SPI) --> SPI is disabled

defined(CONFIG_SPI) && defined(CONFIG_DM_SPI) --> Driver Model SPI is enabled

defined(CONFIG_SPI) && !defined(CONFIG_DM_SPI) --> ad-hoc SPI is enabled

Likewise, I think CONFIG_SPI_FLASH should decide if the system has SPI flash.

Signature · 2 lines

Best Regards
Masahiro Yamada

Simon Glass

2015-04-08 02:46 UTC #32 lore raw

PATCH 8/12 ARM: socfpga: use "select" instead of default value in defconfig

Hi Masahiro,

Quoted 61 lines · Masahiro Yamada

Hi Pavel,
2015-04-02 21:47 GMT+09:00 Pavel Machek <[email protected]>:
Quoted 39 lines
Hi!
Quoted 37 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig                   | 6 ++++++
 configs/socfpga_arria5_defconfig   | 3 ---
 configs/socfpga_cyclone5_defconfig | 3 ---
 configs/socfpga_socrates_defconfig | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)
Quoted 13 lines
arch/arm/Kconfig config TARGET_SOCFPGA_ARRIA5 · line 623
Quoted 11 lines
arch/arm/Kconfig +3 -0
index b25a4a9..6ae48c6 100644
@@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
      bool "Support socfpga_arria5"
      select CPU_V7
      select SUPPORT_SPL
+     select DM
+     select DM_SPI_FLASH
+     select DM_SPI
Are you sure?
Yes, I'm sure.
Quoted 7 lines
config DM_SPI_FLASH
bool "Enable Driver Model for SPI flash"
depends on DM && SPI
help
DM_SPI_FLASH depends on SPI, you can't just select it...
This dependency is wrong.
Before this patch, it must be fixed.
Quoted 7 lines
Quoted 2 lines
Please see 01/12 of this series:
http://patchwork.ozlabs.org/patch/456458/
But I'm not sure.
With this, you made CONFIG_DM_SPI_FLASH mandatory... even for users that have no SPI flash. There must be better solution...?
In my opinion,
CONFIG_DM_* should be user-unconfigurable.
CONFIG_DM_* should not enable/disable a feature,
but should define how it is implemented.
For example,

Quoted 8 lines

!defined(CONFIG_SPI) --> SPI is disabled
defined(CONFIG_SPI) && defined(CONFIG_DM_SPI) --> Driver Model SPI is enabled
defined(CONFIG_SPI) && !defined(CONFIG_DM_SPI) --> ad-hoc SPI is enabled
Likewise, I think CONFIG_SPI_FLASH should decide if the system has SPI flash.

This sounds right to me. In fact it is important, since we want to remove the CONFIG_DM options eventually. There are only there as a migration aid.

Regards,
Simon

Simon Glass

2015-04-08 02:49 UTC #33 lore raw

PATCH 8/12 ARM: socfpga: use "select" instead of default value in defconfig

Quoted 68 lines · Simon Glass

Hi Masahiro,
Quoted 65 lines · Masahiro Yamada
Hi Pavel,
2015-04-02 21:47 GMT+09:00 Pavel Machek <[email protected]>:
Quoted 39 lines
Hi!
Quoted 37 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig                   | 6 ++++++
 configs/socfpga_arria5_defconfig   | 3 ---
 configs/socfpga_cyclone5_defconfig | 3 ---
 configs/socfpga_socrates_defconfig | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)
Quoted 13 lines
arch/arm/Kconfig config TARGET_SOCFPGA_ARRIA5 · line 623
Quoted 11 lines
arch/arm/Kconfig +3 -0
index b25a4a9..6ae48c6 100644
@@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
      bool "Support socfpga_arria5"
      select CPU_V7
      select SUPPORT_SPL
+     select DM
+     select DM_SPI_FLASH
+     select DM_SPI
Are you sure?
Yes, I'm sure.
Quoted 7 lines
config DM_SPI_FLASH
bool "Enable Driver Model for SPI flash"
depends on DM && SPI
help
DM_SPI_FLASH depends on SPI, you can't just select it...
This dependency is wrong.
Before this patch, it must be fixed.
Quoted 7 lines
Quoted 2 lines
Please see 01/12 of this series:
http://patchwork.ozlabs.org/patch/456458/
But I'm not sure.
With this, you made CONFIG_DM_SPI_FLASH mandatory... even for users that have no SPI flash. There must be better solution...?
In my opinion,
CONFIG_DM_* should be user-unconfigurable.
CONFIG_DM_* should not enable/disable a feature,
but should define how it is implemented.
For example,
!defined(CONFIG_SPI) --> SPI is disabled
defined(CONFIG_SPI) && defined(CONFIG_DM_SPI) --> Driver Model SPI is enabled

Quoted 8 lines

Quoted 4 lines
defined(CONFIG_SPI) && !defined(CONFIG_DM_SPI) --> ad-hoc SPI is enabled
Likewise, I think CONFIG_SPI_FLASH should decide if the system has SPI flash.
This sounds right to me. In fact it is important, since we want to remove the CONFIG_DM options eventually. There are only there as a migration aid.

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #34 lore raw

PATCH 8/12 ARM: socfpga: use "select" instead of default value in defconfig

Quoted 72 lines · Simon Glass

Quoted 71 lines · Simon Glass
Hi Masahiro,
Quoted 68 lines · Masahiro Yamada
Hi Pavel,
2015-04-02 21:47 GMT+09:00 Pavel Machek <[email protected]>:
Quoted 39 lines
Hi!
Quoted 37 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig                   | 6 ++++++
 configs/socfpga_arria5_defconfig   | 3 ---
 configs/socfpga_cyclone5_defconfig | 3 ---
 configs/socfpga_socrates_defconfig | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)
Quoted 13 lines
arch/arm/Kconfig config TARGET_SOCFPGA_ARRIA5 · line 623
Quoted 11 lines
arch/arm/Kconfig +3 -0
index b25a4a9..6ae48c6 100644
@@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5
      bool "Support socfpga_arria5"
      select CPU_V7
      select SUPPORT_SPL
+     select DM
+     select DM_SPI_FLASH
+     select DM_SPI
Are you sure?
Yes, I'm sure.
Quoted 7 lines
config DM_SPI_FLASH
bool "Enable Driver Model for SPI flash"
depends on DM && SPI
help
DM_SPI_FLASH depends on SPI, you can't just select it...
This dependency is wrong.
Before this patch, it must be fixed.
Quoted 7 lines
Quoted 2 lines
Please see 01/12 of this series:
http://patchwork.ozlabs.org/patch/456458/
But I'm not sure.
With this, you made CONFIG_DM_SPI_FLASH mandatory... even for users that have no SPI flash. There must be better solution...?
In my opinion,
CONFIG_DM_* should be user-unconfigurable.
CONFIG_DM_* should not enable/disable a feature,
but should define how it is implemented.
For example,
!defined(CONFIG_SPI) --> SPI is disabled
defined(CONFIG_SPI) && defined(CONFIG_DM_SPI) --> Driver Model SPI is enabled
defined(CONFIG_SPI) && !defined(CONFIG_DM_SPI) --> ad-hoc SPI is enabled

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
Likewise, I think CONFIG_SPI_FLASH should decide if the system has SPI flash.
This sounds right to me. In fact it is important, since we want to remove the CONFIG_DM options eventually. There are only there as a migration aid.
Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:48 UTC #35 lore raw

PATCH 9/12 ARM: bav335x: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 2 ++
 configs/birdland_bav335a_defconfig | 3 ---
 configs/birdland_bav335b_defconfig | 3 ---
 3 files changed, 2 insertions(+), 6 deletions(-)

arch/arm/Kconfig +2 -0

index 6ae48c6..3453ad0 100644
@@ -401,6 +401,8 @@ config TARGET_BAV335X
 	bool "Support bav335x"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
 	help
 	  The BAV335x OEM Network Processor integrates all the functions of an
 	  embedded network computer in a small, easy to use SODIMM module which

configs/birdland_bav335a_defconfig +0 -3

index 54ac4d1..43a4206 100644
@@ -1,8 +1,5 @@
 CONFIG_ARM=y
 CONFIG_TARGET_BAV335X=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
-CONFIG_SYS_MALLOC_F=y
 CONFIG_BAV_VERSION=1
 CONFIG_SPL=y
 CONFIG_SYS_EXTRA_OPTIONS="SERIAL1,CONS_INDEX=1"

configs/birdland_bav335b_defconfig +0 -3

index 9046553..7206e8e 100644
@@ -1,8 +1,5 @@
 CONFIG_ARM=y
 CONFIG_TARGET_BAV335X=y
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y
-CONFIG_SYS_MALLOC_F=y
 CONFIG_BAV_VERSION=2
 CONFIG_SPL=y
 CONFIG_SYS_EXTRA_OPTIONS="SERIAL1,CONS_INDEX=1"

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #36 lore raw

PATCH 9/12 ARM: bav335x: use "select" instead of default value in defconfig

Quoted 7 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig                   | 2 ++
 configs/birdland_bav335a_defconfig | 3 ---
 configs/birdland_bav335b_defconfig | 3 ---
 3 files changed, 2 insertions(+), 6 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #37 lore raw

PATCH 9/12 ARM: bav335x: use "select" instead of default value in defconfig

Quoted 11 lines · Simon Glass

Quoted 7 lines · Masahiro Yamada
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig                   | 2 ++
 configs/birdland_bav335a_defconfig | 3 ---
 configs/birdland_bav335b_defconfig | 3 ---
 3 files changed, 2 insertions(+), 6 deletions(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:48 UTC #38 lore raw

PATCH 10/12 ARM: stv0991: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig          | 2 ++
 configs/stv0991_defconfig | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/Kconfig +2 -0

index 3453ad0..bade196 100644
@@ -230,6 +230,8 @@ config TARGET_SPEAR600
 config TARGET_STV0991
 	bool "Support stv0991"
 	select CPU_V7
+	select DM
+	select DM_SERIAL
 
 config TARGET_X600
 	bool "Support x600"

configs/stv0991_defconfig +0 -2

index e8cf311..1884ac4 100644
@@ -2,5 +2,3 @@ CONFIG_SYS_EXTRA_OPTIONS="stv0991"
 CONFIG_ARM=y
 CONFIG_TARGET_STV0991=y
 CONFIG_SYS_MALLOC_F_LEN=0x2000
-CONFIG_DM=y
-CONFIG_DM_SERIAL=y

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #39 lore raw

PATCH 10/12 ARM: stv0991: use "select" instead of default value in defconfig

Quoted 6 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig          | 2 ++
 configs/stv0991_defconfig | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #40 lore raw

PATCH 10/12 ARM: stv0991: use "select" instead of default value in defconfig

Quoted 10 lines · Simon Glass

Quoted 6 lines · Masahiro Yamada
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig          | 2 ++
 configs/stv0991_defconfig | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

vikasm

2015-04-13 20:38 UTC #41 lore raw

PATCH 10/12 ARM: stv0991: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Quoted 6 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig          | 2 ++
 configs/stv0991_defconfig | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by Vikas Manocha <[email protected]>

Masahiro Yamada

author

2015-03-31 03:48 UTC #42 lore raw

PATCH 11/12 ARM: cm_fx6: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/arm/Kconfig         | 3 +++
 configs/cm_fx6_defconfig | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

arch/arm/Kconfig +3 -0

index bade196..735ee43 100644
@@ -617,6 +617,9 @@ config TARGET_CM_FX6
 	bool "Support cm_fx6"
 	select CPU_V7
 	select SUPPORT_SPL
+	select DM
+	select DM_SERIAL
+	select DM_GPIO
 
 config TARGET_SOCFPGA_ARRIA5
 	bool "Support socfpga_arria5"

configs/cm_fx6_defconfig +0 -3

index f10a5c2..c83a0e8 100644
@@ -2,6 +2,3 @@ CONFIG_SPL=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6QDL,SPL"
 CONFIG_ARM=y
 CONFIG_TARGET_CM_FX6=y
-CONFIG_DM=y
-CONFIG_DM_GPIO=y
-CONFIG_DM_SERIAL=y

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:50 UTC #43 lore raw

PATCH 11/12 ARM: cm_fx6: use "select" instead of default value in defconfig

Quoted 6 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig         | 3 +++
 configs/cm_fx6_defconfig | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #44 lore raw

PATCH 11/12 ARM: cm_fx6: use "select" instead of default value in defconfig

Quoted 10 lines · Simon Glass

Quoted 6 lines · Masahiro Yamada
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/arm/Kconfig         | 3 +++
 configs/cm_fx6_defconfig | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!

Masahiro Yamada

author

2015-03-31 03:48 UTC #45 lore raw

PATCH 12/12 powerpc: ids8313: use "select" instead of default value in defconfig

In reply to Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/powerpc/cpu/mpc83xx/Kconfig | 1 +
 configs/ids8313_defconfig        | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

arch/powerpc/cpu/mpc83xx/Kconfig +1 -0

index 4d6cb09..88a3bd6 100644
@@ -49,6 +49,7 @@ config TARGET_MPC837XERDB
 
 config TARGET_IDS8313
 	bool "Support ids8313"
+	select DM
 
 config TARGET_KM8360
 	bool "Support km8360"

configs/ids8313_defconfig +0 -1

index 0950ec8..8479cd4 100644
@@ -4,4 +4,3 @@ CONFIG_MPC83xx=y
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
 CONFIG_TARGET_IDS8313=y
-CONFIG_DM=y

Signature · 1 line

1.9.1

Simon Glass

2015-04-08 02:51 UTC #46 lore raw

PATCH 12/12 powerpc: ids8313: use "select" instead of default value in defconfig

Quoted 6 lines · Masahiro Yamada

Signed-off-by Masahiro Yamada <[email protected]>

---

 arch/powerpc/cpu/mpc83xx/Kconfig | 1 +
 configs/ids8313_defconfig        | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

Acked-by Simon Glass <[email protected]>

Simon Glass

2015-04-08 14:02 UTC #47 lore raw

PATCH 12/12 powerpc: ids8313: use "select" instead of default value in defconfig

Quoted 10 lines · Simon Glass

Quoted 6 lines · Masahiro Yamada
Signed-off-by Masahiro Yamada <[email protected]>
---
 arch/powerpc/cpu/mpc83xx/Kconfig | 1 +
 configs/ids8313_defconfig        | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm/next, thanks!