Skip to contentSkip to conversation

vb2: remove unused variable

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 10, 2015 – Apr 14, 2015 Media (V4L/DVB)

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 vb2: remove unused variable

A recent bug fix removed all uses of the 'fileio' variable in vb2_thread_stop(), which now causes warnings in a lot of ARM defconfig builds:

drivers/media/v4l2-core/videobuf2-core.c:3228:26: warning: unused variable 'fileio' [-Wunused-variable]

This removes the variable as well. The commit that introduced the warning was marked for 3.18+ backports, so this should probably be backported too.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 0e661006370b7 ("[media] vb2: fix 'UNBALANCED' warnings when calling vb2_thread_stop()")
Cc <[email protected]> # for v3.18 and up
drivers/media/v4l2-core/videobuf2-core.c +0 -1
index c11aee7db884..d3f7bf0db61e 100644
@@ -3225,7 +3225,6 @@ EXPORT_SYMBOL_GPL(vb2_thread_start);
 int vb2_thread_stop(struct vb2_queue *q)
 {
 	struct vb2_threadio_data *threadio = q->threadio;
-	struct vb2_fileio_data *fileio = q->fileio;
 	int err;
 
 	if (threadio == NULL)
Acked-by on v1 1/1
#1 lore raw

Hello,

Quoted 6 lines · Arnd Bergmann

A recent bug fix removed all uses of the 'fileio' variable in vb2_thread_stop(), which now causes warnings in a lot of ARM defconfig builds:

drivers/media/v4l2-core/videobuf2-core.c:3228:26: warning: unused variable 'fileio' [-Wunused-variable]

Quoted 7 lines

This removes the variable as well. The commit that introduced the warning was marked for 3.18+ backports, so this should probably be backported too.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes 0e661006370b7 ("[media] vb2: fix 'UNBALANCED' warnings when calling vb2_thread_stop()")
Cc <[email protected]> # for v3.18 and up
Acked-by Marek Szyprowski <[email protected]>
Quoted 7 lines
drivers/media/v4l2-core/videobuf2-core.c +0 -0
index c11aee7db884..d3f7bf0db61e 100644

drivers/media/v4l2-core/videobuf2-core.c EXPORT_SYMBOL_GPL(vb2_thread_start); · line 3230

Quoted 7 lines
drivers/media/v4l2-core/videobuf2-core.c +0 -1
@@ -3225,7 +3225,6 @@ EXPORT_SYMBOL_GPL(vb2_thread_start);
  int vb2_thread_stop(struct vb2_queue *q)
  {
  	struct vb2_threadio_data *threadio = q->threadio;
-	struct vb2_fileio_data *fileio = q->fileio;
  	int err;
 
  	if (threadio == NULL)

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland